Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Repository Management actions + Database changes. #3836
Implementing Repository Management actions + Database changes. #3836
Changes from all commits
fc754c1
e52afbf
7d00a02
cd2f925
6775301
9d77f68
17cc488
66f6978
8606981
241bcee
234af67
038c65b
e45e669
0d39cd6
d6f4f44
e3b552e
1d628c7
d23a431
6b7b72e
d73857d
87a1a38
5395f4c
022977a
7fe619c
5655157
2ef3922
2c44c31
cfa8f9a
0c00fca
4135ec4
5d0d7d3
e1b38ba
9220814
ce627ce
b8fd941
13367f8
73f6563
cc6f2ba
3441e1c
f30435e
f674f74
2a09abe
689e310
36a9009
fc6fca5
95bd037
fd14ae3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably add a Const value for this file name/path and add it somewhere central (like config?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I'm also not a fan of the name "DevHome.db". Mabye something like "DevHomeMachineData.db" to reflect that this is data about what's on the machine (at least that's what I think this is for) :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The database is for all of devhome.
I'll look into making the path, and name
const
DevHome.db
is for all of DevHome local for every user.Maybe
UserDevHomeData.db
?