Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feature/entities to main #180

Merged
merged 32 commits into from
Oct 18, 2023
Merged

Merge feature/entities to main #180

merged 32 commits into from
Oct 18, 2023

Conversation

davidmrdavid
Copy link
Member

As in title.

sebastianburckhardt and others added 4 commits September 14, 2023 10:18
…n. (#186)

* add factories

* implement grpc worker

* update to latest core, remove obsolete files

* Apply suggestions from code review

Co-authored-by: Jacob Viau <javia@microsoft.com>

* fix renaming of variables

* address PR feedback

* propagate changes from microsoft/durabletask-protobuf/pull/14

* revise representation of operation results

* update/simplify protobuf utils

* simplify StateShim and ContextShim

* some minor simplifications

* add missing failure details.

* simplify operationActions list useage, by always creating a fresh list when resetting.

* Apply suggestions from code review

Co-authored-by: Jacob Viau <javia@microsoft.com>

---------

Co-authored-by: Jacob Viau <javia@microsoft.com>
* Add gRPC entity runner

* Address PR comments
* draft

* implement client

* simplify query

* propagate changes from microsoft/durabletask-protobuf/pull/14

* Apply suggestions from code review

Co-authored-by: Jacob Viau <javia@microsoft.com>

* address PR feedback

* add continuation token to CleanEntityStorage operation

* fix/simplify protobuf format

* minor simplifications

* add optional continueUntilComplete argument to CleanEntityStorageAsync

* update to latest proto

---------

Co-authored-by: Jacob Viau <javia@microsoft.com>
* draft

* missing file

* update to match latest version of DT.Core

* updates

* update to latest

* minor simplification.

* address PR feedback and apply some minor simplifications.

* address more PR feedback

* latest proto
@sebastianburckhardt sebastianburckhardt added durable-entities Related to the Durable Entities support milestone and removed core-entities labels Sep 21, 2023
jviau and others added 13 commits September 25, 2023 10:30
* remove errorContext, fix how operation result is read

* add TaskEntityOperation parameter to InitializeState

* add missing parameter checking for entity IDs that are passed in

* pass entity parameters to orchestration executor
* pass entity parameters to orchestration executor

* remove erroneous check

* pass EntityMessageEvent as the original object

* latest proto
* revise EntityInstanceId implementation and checking

* address PR feedback: add switch to enable/disable entity support and associated checking

* one more validation check for entity names

* remove checks that were supposed to be removed but got re-added during merge mess

* address PR feedback
* rename StartOrchestration to ScheduleNewOrchestration and add ScheduledStartTime parameter

* specify different defaults for clean entity storage (by default, everything should be cleaned)

* support queries that return stateless entities, and add more properties to entity metadata

* make the page size an optional parameter (if absent, backend determines what page size is convenient)

* address PR feedback

* update to latest protobuf definition

* rename includeStateless to includeTransient

* update proto

* update proto submodule to latest main branch
@jviau jviau changed the title [WIP] Feature/entities Merge feature/entities to main Oct 18, 2023
@jviau jviau marked this pull request as ready for review October 18, 2023 18:34
@jviau jviau merged commit faa5fd1 into main Oct 18, 2023
3 checks passed
@jviau jviau deleted the feature/entities branch October 18, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
durable-entities Related to the Durable Entities support milestone P1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants