Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: picker attributes always true #6773

Merged
merged 12 commits into from
Jun 14, 2024
Merged

Conversation

scomea
Copy link
Collaborator

@scomea scomea commented Jul 5, 2023

Pull Request

📖 Description

As described in #6311 picker's "filter-selected" and "filter-query" attributes were incorrectly configured and always ended up being true unless set via the prop.

This change resolves this issue by:

  • remove "filter-query" and "filter-selected" attributes (never worked)
  • introduces new disableQueryFilter and disableSelectionFilter props and associated attributes, defaults to false to match current default behavior
  • deprecates the filterQuery and filterSelected props but keeps them in sync with the new props so we shouldn't break anyone who is setting these

This change also fixes an issue where the "no options available" display wasn't always showing up:

image

When initialized with no options picker could open the menu without displaying the "no options available" message. This pr simplifies the mechanism that shows that to ensure it shows up when needed.

🎫 Issues

closes #6311

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

@scomea scomea force-pushed the users/scomea/empty-no-options branch from ee98166 to 34f863b Compare August 10, 2023 00:11
Copy link
Collaborator

@radium-v radium-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have some tests to make sure that interactions with the deprecated properties are correctly reflected to the new properties, and vice versa.

@janechu janechu force-pushed the users/scomea/empty-no-options branch from c37dcf9 to 5cbcac5 Compare June 14, 2024 19:04
janechu and others added 4 commits June 14, 2024 12:05
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
@janechu janechu force-pushed the users/scomea/empty-no-options branch from d811247 to db00233 Compare June 14, 2024 19:07
@janechu janechu merged commit e499c03 into master Jun 14, 2024
10 checks passed
@janechu janechu deleted the users/scomea/empty-no-options branch June 14, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: unable to set initial boolean attributes on picker
7 participants