-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: picker attributes always true #6773
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scomea
requested review from
EisenbergEffect,
chrisdholt and
nicholasrice
as code owners
July 5, 2023 15:18
chrisdholt
reviewed
Jul 5, 2023
scomea
force-pushed
the
users/scomea/empty-no-options
branch
from
August 10, 2023 00:11
ee98166
to
34f863b
Compare
bheston
approved these changes
Aug 11, 2023
awentzel
approved these changes
Aug 14, 2023
nicholasrice
approved these changes
Aug 15, 2023
radium-v
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to have some tests to make sure that interactions with the deprecated properties are correctly reflected to the new properties, and vice versa.
janechu
force-pushed
the
users/scomea/empty-no-options
branch
from
June 14, 2024 19:04
c37dcf9
to
5cbcac5
Compare
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
janechu
force-pushed
the
users/scomea/empty-no-options
branch
from
June 14, 2024 19:07
d811247
to
db00233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
As described in #6311 picker's "filter-selected" and "filter-query" attributes were incorrectly configured and always ended up being true unless set via the prop.
This change resolves this issue by:
disableQueryFilter
anddisableSelectionFilter
props and associated attributes, defaults to false to match current default behaviorfilterQuery
andfilterSelected
props but keeps them in sync with the new props so we shouldn't break anyone who is setting theseThis change also fixes an issue where the "no options available" display wasn't always showing up:
When initialized with no options picker could open the menu without displaying the "no options available" message. This pr simplifies the mechanism that shows that to ensure it shows up when needed.
🎫 Issues
closes #6311
✅ Checklist
General
$ yarn change
Component-specific