This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
[WIP] BREAKING(refs): add support of automatic refs #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
commented
Nov 21, 2018
| status={{ | ||
| color: 'green', | ||
| icon: 'check', | ||
| title: 'Available', | ||
| size: Status.defaultProps.size * 1.5, | ||
| size: 48, |
There was a problem hiding this comment.
I will move this to a separate PR.
layershifter
commented
Nov 21, 2018
| /** | ||
| * A status graphically represents someone's or something's state. | ||
| */ | ||
| export default forwardRefFactory(Status) |
There was a problem hiding this comment.
One of side effects, a component's description should be on export.
layershifter
changed the title
kuzhelov
reviewed
Nov 28, 2018
| export const isForwardRefComponent = (Component: React.ReactType): boolean => | ||
| // Heads up! | ||
| // Any is used there because type's definitions do not contain this internal property. | ||
| typeof Component === 'object' && (Component as any).$$typeof === ForwardRef |
There was a problem hiding this comment.
is it part of public API?
There was a problem hiding this comment.
Nope, and it's a problem. I don't know any other way to perform this check, I have even made a codesandbox that shows my problem: https://codesandbox.io/s/kwkw3pq1k3
I'm open for better proposals there.
layershifter
force-pushed
the
feat/ref-factories
branch
from
22513db
to
91c086d
Compare
layershifter
force-pushed
the
feat/ref-factories
branch
from
91c086d
to
1a6c0bd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #417.
This PR will add automatic refs to all our components. The basic idea of this is quite simple, I tried to document it in comments however I also want to describe it separately in this PR.
1. Wrap all our components with
forwardRef()forwardRef()is a single API that allows you to pass down refs to elements. In fact,forwardRefFactory()is only a wrapper around it. We will wrap all components with it.This means that we will receive a
refin our factory and catch it:2. Pass down intercepted refs
forwardRefSymbolprop.forwardRefSymbolis a simple prop we will have it in unhandled propsElementTypeelement it will work without any code changes