This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
chore(docgen): remove constructorName
property
#587
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cut from #509.
This PR removes the
constructorName
property from our docgen task. This property is used only in our tests and blocks the usage of HOC, refs #509.Props
require(absPath).default
in docgen task, this require is handled byts-node
so it will increase performance (even in CI 1:30 -> 1:12 for theUnit Tests
task)Cons
isConformant()
now has one more argument. However it's not a real issue. BTW,componentName
will be compared withdisplayName
, so there is a really small change to get a typo