Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

chore(docgen): remove constructorName property #587

Closed
wants to merge 2 commits into from

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Dec 10, 2018

Cut from #509.


This PR removes the constructorName property from our docgen task. This property is used only in our tests and blocks the usage of HOC, refs #509.

Props

  • we omit require(absPath).default in docgen task, this require is handled by ts-node so it will increase performance (even in CI 1:30 -> 1:12 for the Unit Tests task)
  • unblocks the usage of HOCs in our components

Cons

  • isConformant() now has one more argument. However it's not a real issue. BTW, componentName will be compared with displayName, so there is a really small change to get a typo

@layershifter layershifter changed the title [WIP] chore(docgen): remove constructorName property chore(docgen): remove constructorName property Dec 10, 2018
@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS

@levithomason
Copy link
Member

For now, we'll close this PR. We won't wrap all components with the forwardRef HOC just yet. We're going to let the community figure out what the final solution is on refs before doing anything drastic.

@layershifter
Copy link
Member Author

But we want still to get rid of this require(), #589.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants