Adding swiftLint as a build step in CI #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrieshin
reviewed
Mar 23, 2021
rdeassis
reviewed
Mar 23, 2021
harrieshin
reviewed
Mar 26, 2021
harrieshin
approved these changes
Mar 30, 2021
7 tasks
rdeassis
added a commit
to rdeassis/fluentui-apple
that referenced
this pull request
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Removed SwiftLint check for
redundant_type_annotation.Known issue in 0.43 version of SwiftLint. explicit_type_interface collides with redundant_type_annotation for Bool realm/SwiftLint#3578
Adding SwiftLint check in CI. Enforced strict check to catch warnings as errors
Verification
Success Lint Job : https://github.com/microsoft/fluentui-apple/runs/2170521865
Failed Lint Job: https://github.com/microsoft/fluentui-apple/runs/2170396417
Microsoft Reviewers: Open in CodeFlow