Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Xcode version to 12.5. #560

Closed
wants to merge 2 commits into from

Conversation

rdeassis
Copy link
Contributor

@rdeassis rdeassis commented May 10, 2021

Platforms Impacted

  • iOS
  • macOS

Description of changes

Xcode 12.5 is available in the GitHub images now.
This change updates the pipelines to use it according to the environment info listed on the links below:

Verification

Local build using Big Sur (11.3.1) with Xcode 12.5.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
Microsoft Reviewers: Open in CodeFlow

@rdeassis rdeassis requested review from a team as code owners May 10, 2021 21:50
@@ -16,7 +16,7 @@ Fluent UI Apple contains native UIKit and AppKit controls aligned with [Microsof
#### Requirements

- iOS 13+ or macOS 10.14+
- Xcode 11+
- Xcode 12.5+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while our pipeline is updating... it doesn't mean the sdk requires 12.5 right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's not a requirement that we use Xcode 12.5, but we also don't validate previous versions once we're running on 12.5.

I can revert it or put the Xcode version in a "recommended" section instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having requires 11 makes sense for iOS 13+ requirement. yeah, maybe recommended latest Xcode might be something we could add?

@@ -1,7 +1,7 @@
jobs:
- job: fluentui_apple_publish_nuget
pool:
vmImage: 'macos-10.15'
vmImage: 'macos-11.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious if this works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OS selection seems to be working as per the log below.
But it looks like #486 changes made the work flow stop using our script to select the correct Xcode version.

Screen Shot 2021-05-10 at 3 18 57 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your screenshot is from ci.yml not fluentui-apple-pbulish-nuget-job.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though you were referring to the "macOS-11.0" string as opposed to "macOS-11.3".
We discussed/found out offline that ADO currently does not support Xcode 12.5.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no I meant curious if the ado yml change would work since it doesn't have Big Sur support. but if we don't want recall this PR at this point, that's fine.

@rdeassis
Copy link
Contributor Author

Closing this PR for now due to the lack of support for Xcode 12.5 in the ADO pipeline.
We'll get back to it once that support is available.

@rdeassis rdeassis closed this May 11, 2021
@rdeassis
Copy link
Contributor Author

GitHub issue tracking Xcode 12.5/Big Sur support in ADO:
actions/runner-images#2072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants