-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Xcode version to 12.5. #560
Conversation
@@ -16,7 +16,7 @@ Fluent UI Apple contains native UIKit and AppKit controls aligned with [Microsof | |||
#### Requirements | |||
|
|||
- iOS 13+ or macOS 10.14+ | |||
- Xcode 11+ | |||
- Xcode 12.5+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while our pipeline is updating... it doesn't mean the sdk requires 12.5 right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it's not a requirement that we use Xcode 12.5, but we also don't validate previous versions once we're running on 12.5.
I can revert it or put the Xcode version in a "recommended" section instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having requires 11 makes sense for iOS 13+ requirement. yeah, maybe recommended latest Xcode might be something we could add?
@@ -1,7 +1,7 @@ | |||
jobs: | |||
- job: fluentui_apple_publish_nuget | |||
pool: | |||
vmImage: 'macos-10.15' | |||
vmImage: 'macos-11.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious if this works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OS selection seems to be working as per the log below.
But it looks like #486 changes made the work flow stop using our script to select the correct Xcode version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your screenshot is from ci.yml not fluentui-apple-pbulish-nuget-job.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I though you were referring to the "macOS-11.0" string as opposed to "macOS-11.3".
We discussed/found out offline that ADO currently does not support Xcode 12.5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no I meant curious if the ado yml change would work since it doesn't have Big Sur support. but if we don't want recall this PR at this point, that's fine.
Closing this PR for now due to the lack of support for Xcode 12.5 in the ADO pipeline. |
GitHub issue tracking Xcode 12.5/Big Sur support in ADO: |
Platforms Impacted
Description of changes
Xcode 12.5 is available in the GitHub images now.
This change updates the pipelines to use it according to the environment info listed on the links below:
Verification
Local build using Big Sur (11.3.1) with Xcode 12.5.
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow