Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Xcode version to 12.5. #560

Closed
wants to merge 2 commits into from
Closed

Updating Xcode version to 12.5. #560

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ae15f2
Updating Xcode version to 12.5.
rdeassis May 10, 2021
09ce65c
Adding call to switch Xcode version back after change in #486.
rdeassis May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ado/templates/fluentui-apple-publish-nuget-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
jobs:
- job: fluentui_apple_publish_nuget
pool:
vmImage: 'macos-10.15'
vmImage: 'macos-11.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious if this works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OS selection seems to be working as per the log below.
But it looks like #486 changes made the work flow stop using our script to select the correct Xcode version.

Screen Shot 2021-05-10 at 3 18 57 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your screenshot is from ci.yml not fluentui-apple-pbulish-nuget-job.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though you were referring to the "macOS-11.0" string as opposed to "macOS-11.3".
We discussed/found out offline that ADO currently does not support Xcode 12.5.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no I meant curious if the ado yml change would work since it doesn't have Big Sur support. but if we don't want recall this PR at this point, that's fine.

displayName: FluentUI Apple Publish NuGet
timeoutInMinutes: 60 # how long to run the job before automatically cancelling
cancelTimeoutInMinutes: 5 # how much time to give 'run always even if cancelled tasks' before killing them
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:

jobs:
validation:
runs-on: macos-10.15
runs-on: macos-11.0
strategy:
fail-fast: true
steps:
Expand All @@ -26,7 +26,7 @@ jobs:
- name: validation
run: scripts/validation.sh
xcodebuild:
runs-on: macos-10.15
runs-on: macos-11.0
strategy:
fail-fast: false
matrix:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/podPublish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
jobs:
Pod-Publish:
if: github.event.base_ref == 'refs/heads/main'
runs-on: macOS-10.15
runs-on: macOS-11.0

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Fluent UI Apple contains native UIKit and AppKit controls aligned with [Microsof
#### Requirements

- iOS 13+ or macOS 10.14+
- Xcode 11+
- Xcode 12.5+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while our pipeline is updating... it doesn't mean the sdk requires 12.5 right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's not a requirement that we use Xcode 12.5, but we also don't validate previous versions once we're running on 12.5.

I can revert it or put the Xcode version in a "recommended" section instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having requires 11 makes sense for iOS 13+ requirement. yeah, maybe recommended latest Xcode might be something we could add?

- Swift 5.0+

#### Using Carthage
Expand Down
2 changes: 1 addition & 1 deletion scripts/xcode_select_current_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
if [ -n "$XCODE_PATH_OVERRIDE" ]; then # If someone calls this with the XCODE_PATH_OVERRIDE variable set to a path to a developer dir, use it instead
XCODE_PATH="$XCODE_PATH_OVERRIDE"
else
XCODE_PATH='/Applications/Xcode_12.2.app/Contents/Developer'
XCODE_PATH='/Applications/Xcode_12.5.app/Contents/Developer'
fi

echo "Running command: sudo xcode-select --switch $XCODE_PATH"
Expand Down