Add react-native-svg compatible package #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut up paths doesn't work in windows
…package. This is a modified version of the react-icons package designed to output a package compatible with react-native-svg. To accomplish this we we need to use a later version of SVGR which has some changes with file templates and possibly sizing output that are incompatible with the current react-icons code. Ideally we might want to produce some common code between the two but I don't want to risk breaking anything in react-icons with this additional package.
Add a new package to publish a react-native-svg version of this icon package. This is a modified version of the react-icons package designed to output a package compatible with react-native-svg.
To accomplish this we we need to use a later version of SVGR which has some changes with file templates and possibly sizing output that are incompatible with the current react-icons code.
Ideally we might want to produce some common code between the two but I don't want to risk breaking anything in react-icons with this additional package.
…is icon package. This is a modified version of the react-icons package designed to output a package compatible with react-native-svg." This reverts commit 35729cf.
tomi-msft
previously approved these changes
Mar 3, 2023
Using the git web editor isn't the best.
tomi-msft
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this change adds a new package to publish a react-native-svg version of this icon package. This is a modified version of the react-icons package process designed to output a package compatible with react-native-svg.
To accomplish this, I needed to use a later version of SVGR which additionally has some changes with file templates and sizing output that are incompatible with the current react-icons code. Ideally, we might want to produce some common code between the two but I don't want to risk breaking anything in react-icons with this change.
Also, this fixes an issue in importer.js which tries to determine the name of containing folder in a path by looking for the last '/', but this does not work in windows since backslashes can be used here. This made the script copy a bunch of stuff to the wrong place when run in windows when I was doing local testing.