Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable publish to npm registry #624

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Re-enable publish to npm registry #624

merged 4 commits into from
Aug 21, 2023

Conversation

winstonhong15
Copy link
Contributor

@winstonhong15 winstonhong15 commented Aug 9, 2023

The @fluentui/svg-icons package hasn't been updated since version 1.1.198 (see @fluentui/svg-icons - npm). After some investigation, I discovered that the npm-publish task was removed in this pull request #548 probably by accident.

Add back the npm-publish task to re-enable publish to npm. This should also resolve #623.

@winstonhong15
Copy link
Contributor Author

The react-native-icons package seems to be built and published twice in the publish.yml file. Not sure whether this is by design.

image

image

@warren-ms Any thoughts on this?

warren-ms
warren-ms previously approved these changes Aug 14, 2023
Copy link
Collaborator

@warren-ms warren-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have removed this accidently while merging 😰

@spencer-nelson spencer-nelson merged commit 149092b into microsoft:main Aug 21, 2023
8 checks passed
@winstonhong15 winstonhong15 deleted the 23-08-08-publish-svg-icons-package branch August 23, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing icons in @fluentui/svg-icons package
3 participants