Skip to content

Commit

Permalink
Fixes low contrast in dark mode (#28766)
Browse files Browse the repository at this point in the history
* Fixes contrast on web component badge

* Adds change
  • Loading branch information
procload authored and radium-v committed May 2, 2024
1 parent 55c8ff3 commit 1356d9a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Fixes low contrast in dark mode for web component badge",
"packageName": "@fluentui/web-components",
"email": "ryan@ryanmerrill.net",
"dependentChangeType": "patch"
}
5 changes: 3 additions & 2 deletions packages/web-components/src/styles/partials/badge.partials.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
colorNeutralBackground4,
colorNeutralBackground5,
colorNeutralForeground1,
colorNeutralForeground1Static,
colorNeutralForeground3,
colorNeutralForegroundInverted,
colorNeutralForegroundOnBrand,
Expand Down Expand Up @@ -188,7 +189,7 @@ export const badgeFilledStyles = css.partial`
:host([color='warning']) {
background-color: ${colorPaletteYellowBackground3};
color: ${colorNeutralForeground1};
color: ${colorNeutralForeground1Static};
}
`;

Expand All @@ -198,7 +199,7 @@ export const badgeFilledStyles = css.partial`
*/
export const badgeGhostStyles = css.partial`
:host([appearance='ghost']) {
color: ${colorBrandBackground};
color: ${colorBrandForeground1};
background-color: initial;
}
Expand Down

0 comments on commit 1356d9a

Please sign in to comment.