Fixes low contrast in dark mode #28766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
procload
requested review from
levithomason,
miroslavstastny and
brianchristopherbrady
…com/procload/fluentui into users/procload/badgeDarkContrastFix
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
📊 Bundle size report🤖 This report was generated against f74d0d2869e5d1eb46ff78c3fb1198e1924997c9 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f74d0d2869e5d1eb46ff78c3fb1198e1924997c9 (build) |
miroslavstastny
approved these changes
Aug 7, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 62cc26c:
|
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Fixes contrast on web component badge * Adds change
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* Fixes contrast on web component badge * Adds change
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* Fixes contrast on web component badge * Adds change
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* Fixes contrast on web component badge * Adds change
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Fixes contrast on web component badge * Adds change
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* Fixes contrast on web component badge * Adds change
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* Fixes contrast on web component badge * Adds change
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* Fixes contrast on web component badge * Adds change
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* Fixes contrast on web component badge * Adds change
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* Fixes contrast on web component badge * Adds change
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* Fixes contrast on web component badge * Adds change
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* Fixes contrast on web component badge * Adds change
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* Fixes contrast on web component badge * Adds change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates badge's tokens to use correct values to render correctly in dark mode. Fixes bug described below:
Dark Mode
Appearance: ghost
Element has insufficient color contrast of 2.47 (foreground color: #115ea3, background color: #1f1f1f, font size: 9.0pt (12px), font weight: normal). Expected contrast ratio of 4.5:1Element has insufficient color contrast of 2.47 (foreground color: #115ea3, background color: #1f1f1f, font size: 9.0pt (12px), font weight: normal). Expected contrast ratio of 4.5:1
Color: warning
Element has insufficient color contrast of 1.29 (foreground color: #ffffff, background color: #fde300, font size: 9.0pt (12px), font weight: normal). Expected contrast ratio of 4.5:1Element has insufficient color contrast of 1.29 (foreground color: #ffffff, background color: #fde300, font size: 9.0pt (12px), font weight: normal). Expected contrast ratio of 4.5:1