Web components are missing a component definition file #18987
Assignees
Labels
Comments
5 tasks
|
Fixed by #19087 |
janechu
added a commit
to microsoft/fast
that referenced
this issue
Jul 23, 2021
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. What problem does this change solve? Is this a breaking change, chore, fix, feature, etc? --> This change adds the Fluent UI web component library to Creator. There is a slight issue in Fluent UI which means the build will fail until a publish in Fluent UI fixes the issue. See microsoft/fluentui#18987. ## 👩💻 Reviewer Notes <!--- Provide some notes for reviewers to help them provide targeted feedback and testing. Do you recommend a smoke test for this PR? What steps should be followed? Are there particular areas of the code the reviewer should focus on? --> Once this is unblocked by microsoft/fluentui#18987 you will see that two buttons now show up in the left tab, FAST components and Fluent UI components. Both can be added, there are a few caveats however, we are using the Design Tokens from FAST for editing in the right pane. This means that when adding Fluent UI components, the accent color is available but will not affect any components. Additionally, if both component libraries are added, there may be some discrepancies between packages. There is also an issue where both libraries have components that are named the same. This will need to be resolved by prefixing or affixing the library name. See next steps for a future resolution. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [ ] I have included a change request file using `$ yarn change` - [ ] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. - [x] I have read the [CONTRIBUTING](https://github.com/Microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](https://www.fast.design/docs/community/code-of-conduct/#our-standards) for this project. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Allow libraries to add an additional pane to the right rail for configuration, this will be used for the Design Tokens for FAST and Fluent UI component libraries but should be open ended enough to allow for any extra library configuration to take place - Prefix or affix the library name to the component name in the Form and Navigation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
A missing import is present in the
component-definitions.tsfile, the component definition fortoolbar, the file does not exist yet it is being imported and exported which causes build errors when attempting to use the file.Environment Information
Actual behavior:
Error when building a package importing the component-definitions file.
Expected behavior:
No build errors.
Suggested fix
I suggest this is removed or if the code is ready to go, add the toolbar and its definition to the package.
Priorities and help requested:
I have made @chrisdholt aware of the issue.
Requested priority: Blocking
Products/sites affected: FAST Creator
The text was updated successfully, but these errors were encountered: