Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(web-components) remove incorrectly added toolbar from component definitions #19087

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Removes incorrectly added toolbar component form definitions

Focus areas to test

(optional)

@chrisdholt chrisdholt force-pushed the users/chhol/remove-missing-toolbar-from-component-definitions branch from 53e8682 to 024bbd1 Compare July 23, 2021 05:24
@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against a5b02f9926703acf085370ae6ecbcc41782c5f5c

@size-auditor
Copy link

size-auditor bot commented Jul 23, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a5b02f9926703acf085370ae6ecbcc41782c5f5c (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 810 795 5000
BaseButton mount 891 882 5000
Breadcrumb mount 2644 2629 1000
ButtonNext mount 418 417 5000
Checkbox mount 1482 1485 5000
CheckboxBase mount 1273 1275 5000
ChoiceGroup mount 4614 4697 5000
ComboBox mount 952 976 1000
CommandBar mount 10066 10077 1000
ContextualMenu mount 6232 6189 1000
DefaultButton mount 1117 1115 5000
DetailsRow mount 3676 3726 5000
DetailsRowFast mount 3673 3682 5000
DetailsRowNoStyles mount 3466 3540 5000
Dialog mount 2090 2108 1000
DocumentCardTitle mount 148 137 1000
Dropdown mount 3203 3451 5000
FluentProviderNext mount 7231 7299 5000
FocusTrapZone mount 1750 1808 5000
FocusZone mount 1813 1794 5000
IconButton mount 1693 1732 5000
Label mount 335 325 5000
Layer mount 1803 1757 5000
Link mount 439 449 5000
MakeStyles mount 1839 1780 50000
MenuButton mount 1459 1428 5000
MessageBar mount 2004 2011 5000
Nav mount 3210 3262 1000
OverflowSet mount 1026 1029 5000
Panel mount 2048 2050 1000
Persona mount 802 811 1000
Pivot mount 1388 1394 1000
PrimaryButton mount 1239 1260 5000
Rating mount 7555 7498 5000
SearchBox mount 1289 1292 5000
Shimmer mount 2462 2476 5000
Slider mount 1913 1951 5000
SpinButton mount 4975 4883 5000
Spinner mount 416 415 5000
SplitButton mount 3167 3129 5000
Stack mount 504 486 5000
StackWithIntrinsicChildren mount 1511 1527 5000
StackWithTextChildren mount 4477 4460 5000
SwatchColorPicker mount 10144 10004 5000
Tabs mount 1400 1411 1000
TagPicker mount 2393 2401 5000
TeachingBubble mount 11720 11835 5000
Text mount 421 410 5000
TextField mount 1367 1342 5000
ThemeProvider mount 1159 1185 5000
ThemeProvider virtual-rerender 599 590 5000
Toggle mount 789 790 5000
buttonNative mount 115 113 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 157 144 1.09:1
BoxMinimalPerf.default 356 329 1.08:1
RadioGroupMinimalPerf.default 462 436 1.06:1
ButtonMinimalPerf.default 162 155 1.05:1
ImageMinimalPerf.default 375 359 1.04:1
PortalMinimalPerf.default 178 171 1.04:1
RefMinimalPerf.default 240 231 1.04:1
TableMinimalPerf.default 404 390 1.04:1
TextAreaMinimalPerf.default 496 476 1.04:1
CardMinimalPerf.default 547 533 1.03:1
LabelMinimalPerf.default 379 367 1.03:1
AvatarMinimalPerf.default 198 194 1.02:1
CarouselMinimalPerf.default 456 447 1.02:1
GridMinimalPerf.default 342 334 1.02:1
HeaderMinimalPerf.default 353 347 1.02:1
HeaderSlotsPerf.default 750 732 1.02:1
LayoutMinimalPerf.default 358 352 1.02:1
ProviderMinimalPerf.default 992 977 1.02:1
ReactionMinimalPerf.default 372 365 1.02:1
SegmentMinimalPerf.default 346 339 1.02:1
IconMinimalPerf.default 600 588 1.02:1
TableManyItemsPerf.default 1886 1847 1.02:1
ToolbarMinimalPerf.default 928 913 1.02:1
TreeMinimalPerf.default 787 775 1.02:1
AnimationMinimalPerf.default 412 406 1.01:1
AttachmentMinimalPerf.default 150 149 1.01:1
ButtonOverridesMissPerf.default 1678 1660 1.01:1
ChatWithPopoverPerf.default 346 343 1.01:1
DividerMinimalPerf.default 345 342 1.01:1
DropdownManyItemsPerf.default 668 663 1.01:1
EmbedMinimalPerf.default 4056 4032 1.01:1
ListCommonPerf.default 613 604 1.01:1
ListNestedPerf.default 543 535 1.01:1
MenuMinimalPerf.default 845 833 1.01:1
MenuButtonMinimalPerf.default 1626 1614 1.01:1
PopupMinimalPerf.default 586 583 1.01:1
SplitButtonMinimalPerf.default 3765 3712 1.01:1
CustomToolbarPrototype.default 3902 3862 1.01:1
TreeWith60ListItems.default 177 175 1.01:1
VideoMinimalPerf.default 612 606 1.01:1
AlertMinimalPerf.default 261 262 1:1
CheckboxMinimalPerf.default 2675 2667 1:1
DialogMinimalPerf.default 729 726 1:1
DropdownMinimalPerf.default 3100 3089 1:1
InputMinimalPerf.default 1249 1244 1:1
StatusMinimalPerf.default 664 661 1:1
AttachmentSlotsPerf.default 1041 1052 0.99:1
ChatDuplicateMessagesPerf.default 274 276 0.99:1
ChatMinimalPerf.default 639 645 0.99:1
ListMinimalPerf.default 503 508 0.99:1
ListWith60ListItems.default 628 634 0.99:1
RosterPerf.default 1148 1158 0.99:1
ProviderMergeThemesPerf.default 1639 1650 0.99:1
SkeletonMinimalPerf.default 342 346 0.99:1
DatepickerMinimalPerf.default 5237 5366 0.98:1
FormMinimalPerf.default 383 389 0.98:1
ItemLayoutMinimalPerf.default 1199 1227 0.98:1
LoaderMinimalPerf.default 676 687 0.98:1
SliderMinimalPerf.default 1554 1579 0.98:1
TextMinimalPerf.default 338 345 0.98:1
TooltipMinimalPerf.default 976 996 0.98:1
FlexMinimalPerf.default 274 282 0.97:1
ButtonSlotsPerf.default 546 566 0.96:1

@chrisdholt chrisdholt merged commit 77b27c3 into microsoft:master Jul 23, 2021
@chrisdholt chrisdholt deleted the users/chhol/remove-missing-toolbar-from-component-definitions branch July 23, 2021 06:12
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/web-components@v1.2.3 has been released which incorporates this pull request.:tada:

Handy links:

PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
…nitions (microsoft#19087)

* remove incorrectly added component definition for toolbar

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants