Refactoring module css for PeoplePicker. #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Newline at the end of file.
| display: table-cell; | ||
| vertical-align: bottom; | ||
| } | ||
| .pickerMenuItem.resultContent { |
There was a problem hiding this comment.
this can be just resultContent, or itemResultContent if it needs to be unique.
| user-select: none; | ||
| max-width: 100%; | ||
|
|
||
| .pickerPersonaContainer { |
There was a problem hiding this comment.
remove everying .pickerPersona or any other block level names. You only need "container", or if there are multiple containers, "personaContainer". CSS modules means everything is scoped to this component already.
| .ms-Persona-details { | ||
| flex: 0 1 auto; | ||
| } | ||
| .pickerItemContent { |
There was a problem hiding this comment.
I have updated the PR to address the above comments. Thanks!
dzearing
added a commit
that referenced
this pull request
Mar 9, 2017
* CSS modules: Buttons and Links (#1033) * Default/Primary fixed. * Fixed Link. * Updates to link and primary, default, and compound buttons. * Fixing command button. * Updating Command and Icon button styles. * Adding change file. * Updating comments. * CSS modules: Breadcrumb (#1035) * Updating breadcrumb to be css module compliant. * Updating breadcrumb. * CSS modules: Calendar, DatePicker (#1053) * Updated Calendar and PeoplePicker to use css modules. * Updating change file. * Fixing whitespace in test. * Updating calendar. * Fixing logic. * CSS modules: Callout, ContextualMenu, Tooltip, TeachingBubble, Dialog (#1051) * CSS modulifying callout. * Updating ContextualMenu and TeachingBubble. * Updating Tooltip * Fixing dialog. * Fixing teaching bubble names. * CSS modules: DetailsList, GroupedList (#1052) * Fixing check. * Totally fixing DetailsHeader, css modules, resizing addressed correctly. * Updating DetailsRow, Check, Fields. * Updating DetailsList rules. * Updating GroupedList, GroupHeader, GroupFooter, GroupSpacer, and addressing missing key in DetailsHeader. * Adding detailslist change file. * Code review feedback. * Fixed a few more. * fixing checked. * Found one more. * MessageBar: Convert to CSS modules (#1086) * modulify Overlay and MessageBar * Dzearing component css form (#1102) * Updated checkbox to use css modules. * Fixing indentation * Updating choicegroup. * Fixing checkmark icon. * Fixing Icon and Image. * Updating ColorPicker. * Layer, MarqueeSelection. * Fixing dropdown. * Fixing TextField. * Updates to Slider, Spinner, Checkbox. * Updating ProgressIndicator and Rating. * Added change file. * Fixing icon. * Fixing choicegroup feedback. * Addressing feedback. * Updating tetxfield. * Updated checkbox with full elelment name selectors * Updated spinner with full element class names * UPdated more classes to use full name * CSS modules for dropdown, added base button flexContainer to be able … (#1103) * CSS modules for dropdown, added base button flexContainer to be able to target * CHanged to long class names * Refactoring module css for PeoplePicker. (#1069) * Refactoring module css. * - Remove none used class name. - Newline at the end of file. * Add change file. * Address CR. * Updating classname. * Pivot css module. (#1066) * Pivot css module. * typo * naming convention * Adding Searchbox css modules (#1068) * Adding Searchbox css modules * Fixing PR Comments * Fixing a bug on Fabric Website * Pickers: css modularize to keep it consistent (#1065) * modularized pickers css * adding change file) * correctly using global) * CSS Module Persona (#1109) * Remove global and unindent the CSS code. * liaye * change css to module css about persona * update sass from 229-416 * change sass before 227 * Convert the CSS to Module CSS. * change sm, lg, xl * Update the Persona.tsx reference. * change constants * update persona.tsx return part * change persona.test.tsx to use module css. * update css styles * add '.' for find class for persona. * Updated persona classes, added on render function for initials * Fixed rooIsReadOnly * Fixed a missed merge conflict * CLeaned up duplicate getInitials function * Converts Nav component into modular css (#1089) * Nav component converts to module css * Flatting nested class selectors * Refactor element selectors into class based selectors * Feedback from team, naming * Fixing bugs. * Fixing another issue with focus rects in nav chevron buttons. * Module css: commandbar (#1125) * CommandBar updates. * Fixing commandbar issues. * Deleting unused classes. * CSS Modules: Facepile (#1128) * Converting to module css * Init fix for persona add button, need to fix persona first * Refactored facepile to use onRenderIcon of persona * CLeanup and fix tests * Update Facepile.scss * Fixing some typos in checkbox. * Fixing padding rule in groupedlist. * Fixing ui nits in picker. * Polish on css. Making command buttons correctly left aligned. * Updates to Panel for module css. (#1137) * Fixing Dropdown styling and focus issues. * CSS Modules: Document Card (#1149) * DetailsList: Fixing scroll utilities to handle body scroll better. (#384) * Fixing scroll utilities to handle body scroll better. * Updating appstate to support navigating directly to example pages. http://localhost:4321/index.html#/tests/detailslistbasicexample * If header is not displayed, we nullref pressing key up. * Updating to measure window correctly. * Fixing keys error. * Moving getClientRect to utility for window-sensitive scenarios. * Updating marquee selection and autoscroll to work with body scroll. * lint fixes. * Fix FacePile example onclick for RK. Remove stray commas from Layer/Button pages (#383) * Fix parameter order for FacePile example props * Fix FacePile example onClick handler. Remove 2 stray commas from Button and Layer component pages * Implement: Contextualmenu gets window from target element. (#387) * added in the ability for contextualmenu projection. * fixed lint problems * v0.56.2 * Update ListPage.tsx * CSSify DocumentCard * Change classnames in document card and fix visual regressions * Move DocumentCard styles into one root scss file and move style from global to example page * Update document card to not rely on persona * Moved details styles into global class in document card * isFileList to previewIsFilesList * Fixing test failure. * More polish. * Fixing ImageFit.cover * Setting version to beta1. * Fixed breadcrumb overflow bg on hover (#1159) * Changed button label to button text, added prop and fixed examples (#1160) * Changed button label to button text, added prop and fixed examples * put gulpfile back * Update Button.Primary.Example.tsx * Update Button.Primary.Example.tsx * Addressing tslint problems. * Bumping version. * Remove width from icon in buttons (#1167) * allow icon button to render children * #791 Fixes command bar button layout shifting on hover in HighContrast mode (#1122) * #314439 -- #791 Fixes button shifting on hover in HC mode * #314439 -- #791 Using psedo::after element to draw hover box instead of LR borders * #314439 -- #791 formatting feedback * #314439 -- #791 formatting feedback * add rush change * Changes to change file * Updates to the Panel to position absolutely. Should unbreak Outlook. * Updating package. * Add style property to IContextualMenuItem * Add change file * Fixing lint. * Fixing conflicts. * Fixes * bump. * Updated changes file * #1128 -- Fixes missing truncation in IE 11 for Persona text (#1219)
aleksandrjPersonal
pushed a commit
to aleksandrjPersonal/office-ui-fabric-react
that referenced
this pull request
Mar 9, 2017
* Refactoring module css. * - Remove none used class name. - Newline at the end of file. * Add change file. * Address CR. * Updating classname.
aleksandrjPersonal
pushed a commit
to aleksandrjPersonal/office-ui-fabric-react
that referenced
this pull request
Mar 10, 2017
* CSS modules: Buttons and Links (microsoft#1033) * Default/Primary fixed. * Fixed Link. * Updates to link and primary, default, and compound buttons. * Fixing command button. * Updating Command and Icon button styles. * Adding change file. * Updating comments. * CSS modules: Breadcrumb (microsoft#1035) * Updating breadcrumb to be css module compliant. * Updating breadcrumb. * CSS modules: Calendar, DatePicker (microsoft#1053) * Updated Calendar and PeoplePicker to use css modules. * Updating change file. * Fixing whitespace in test. * Updating calendar. * Fixing logic. * CSS modules: Callout, ContextualMenu, Tooltip, TeachingBubble, Dialog (microsoft#1051) * CSS modulifying callout. * Updating ContextualMenu and TeachingBubble. * Updating Tooltip * Fixing dialog. * Fixing teaching bubble names. * CSS modules: DetailsList, GroupedList (microsoft#1052) * Fixing check. * Totally fixing DetailsHeader, css modules, resizing addressed correctly. * Updating DetailsRow, Check, Fields. * Updating DetailsList rules. * Updating GroupedList, GroupHeader, GroupFooter, GroupSpacer, and addressing missing key in DetailsHeader. * Adding detailslist change file. * Code review feedback. * Fixed a few more. * fixing checked. * Found one more. * MessageBar: Convert to CSS modules (microsoft#1086) * modulify Overlay and MessageBar * Dzearing component css form (microsoft#1102) * Updated checkbox to use css modules. * Fixing indentation * Updating choicegroup. * Fixing checkmark icon. * Fixing Icon and Image. * Updating ColorPicker. * Layer, MarqueeSelection. * Fixing dropdown. * Fixing TextField. * Updates to Slider, Spinner, Checkbox. * Updating ProgressIndicator and Rating. * Added change file. * Fixing icon. * Fixing choicegroup feedback. * Addressing feedback. * Updating tetxfield. * Updated checkbox with full elelment name selectors * Updated spinner with full element class names * UPdated more classes to use full name * CSS modules for dropdown, added base button flexContainer to be able … (microsoft#1103) * CSS modules for dropdown, added base button flexContainer to be able to target * CHanged to long class names * Refactoring module css for PeoplePicker. (microsoft#1069) * Refactoring module css. * - Remove none used class name. - Newline at the end of file. * Add change file. * Address CR. * Updating classname. * Pivot css module. (microsoft#1066) * Pivot css module. * typo * naming convention * Adding Searchbox css modules (microsoft#1068) * Adding Searchbox css modules * Fixing PR Comments * Fixing a bug on Fabric Website * Pickers: css modularize to keep it consistent (microsoft#1065) * modularized pickers css * adding change file) * correctly using global) * CSS Module Persona (microsoft#1109) * Remove global and unindent the CSS code. * liaye * change css to module css about persona * update sass from 229-416 * change sass before 227 * Convert the CSS to Module CSS. * change sm, lg, xl * Update the Persona.tsx reference. * change constants * update persona.tsx return part * change persona.test.tsx to use module css. * update css styles * add '.' for find class for persona. * Updated persona classes, added on render function for initials * Fixed rooIsReadOnly * Fixed a missed merge conflict * CLeaned up duplicate getInitials function * Converts Nav component into modular css (microsoft#1089) * Nav component converts to module css * Flatting nested class selectors * Refactor element selectors into class based selectors * Feedback from team, naming * Fixing bugs. * Fixing another issue with focus rects in nav chevron buttons. * Module css: commandbar (microsoft#1125) * CommandBar updates. * Fixing commandbar issues. * Deleting unused classes. * CSS Modules: Facepile (microsoft#1128) * Converting to module css * Init fix for persona add button, need to fix persona first * Refactored facepile to use onRenderIcon of persona * CLeanup and fix tests * Update Facepile.scss * Fixing some typos in checkbox. * Fixing padding rule in groupedlist. * Fixing ui nits in picker. * Polish on css. Making command buttons correctly left aligned. * Updates to Panel for module css. (microsoft#1137) * Fixing Dropdown styling and focus issues. * CSS Modules: Document Card (microsoft#1149) * DetailsList: Fixing scroll utilities to handle body scroll better. (microsoft#384) * Fixing scroll utilities to handle body scroll better. * Updating appstate to support navigating directly to example pages. http://localhost:4321/index.html#/tests/detailslistbasicexample * If header is not displayed, we nullref pressing key up. * Updating to measure window correctly. * Fixing keys error. * Moving getClientRect to utility for window-sensitive scenarios. * Updating marquee selection and autoscroll to work with body scroll. * lint fixes. * Fix FacePile example onclick for RK. Remove stray commas from Layer/Button pages (microsoft#383) * Fix parameter order for FacePile example props * Fix FacePile example onClick handler. Remove 2 stray commas from Button and Layer component pages * Implement: Contextualmenu gets window from target element. (microsoft#387) * added in the ability for contextualmenu projection. * fixed lint problems * v0.56.2 * Update ListPage.tsx * CSSify DocumentCard * Change classnames in document card and fix visual regressions * Move DocumentCard styles into one root scss file and move style from global to example page * Update document card to not rely on persona * Moved details styles into global class in document card * isFileList to previewIsFilesList * Fixing test failure. * More polish. * Fixing ImageFit.cover * Setting version to beta1. * Fixed breadcrumb overflow bg on hover (microsoft#1159) * Changed button label to button text, added prop and fixed examples (microsoft#1160) * Changed button label to button text, added prop and fixed examples * put gulpfile back * Update Button.Primary.Example.tsx * Update Button.Primary.Example.tsx * Addressing tslint problems. * Bumping version. * Remove width from icon in buttons (microsoft#1167) * allow icon button to render children * microsoft#791 Fixes command bar button layout shifting on hover in HighContrast mode (microsoft#1122) * #314439 -- microsoft#791 Fixes button shifting on hover in HC mode * #314439 -- microsoft#791 Using psedo::after element to draw hover box instead of LR borders * #314439 -- microsoft#791 formatting feedback * #314439 -- microsoft#791 formatting feedback * add rush change * Changes to change file * Updates to the Panel to position absolutely. Should unbreak Outlook. * Updating package. * Add style property to IContextualMenuItem * Add change file * Fixing lint. * Fixing conflicts. * Fixes * bump. * Updated changes file * microsoft#1128 -- Fixes missing truncation in IE 11 for Persona text (microsoft#1219)
aleksandrjPersonal
pushed a commit
to aleksandrjPersonal/office-ui-fabric-react
that referenced
this pull request
Mar 10, 2017
* CSS modules: Buttons and Links (microsoft#1033) * Default/Primary fixed. * Fixed Link. * Updates to link and primary, default, and compound buttons. * Fixing command button. * Updating Command and Icon button styles. * Adding change file. * Updating comments. * CSS modules: Breadcrumb (microsoft#1035) * Updating breadcrumb to be css module compliant. * Updating breadcrumb. * CSS modules: Calendar, DatePicker (microsoft#1053) * Updated Calendar and PeoplePicker to use css modules. * Updating change file. * Fixing whitespace in test. * Updating calendar. * Fixing logic. * CSS modules: Callout, ContextualMenu, Tooltip, TeachingBubble, Dialog (microsoft#1051) * CSS modulifying callout. * Updating ContextualMenu and TeachingBubble. * Updating Tooltip * Fixing dialog. * Fixing teaching bubble names. * CSS modules: DetailsList, GroupedList (microsoft#1052) * Fixing check. * Totally fixing DetailsHeader, css modules, resizing addressed correctly. * Updating DetailsRow, Check, Fields. * Updating DetailsList rules. * Updating GroupedList, GroupHeader, GroupFooter, GroupSpacer, and addressing missing key in DetailsHeader. * Adding detailslist change file. * Code review feedback. * Fixed a few more. * fixing checked. * Found one more. * MessageBar: Convert to CSS modules (microsoft#1086) * modulify Overlay and MessageBar * Dzearing component css form (microsoft#1102) * Updated checkbox to use css modules. * Fixing indentation * Updating choicegroup. * Fixing checkmark icon. * Fixing Icon and Image. * Updating ColorPicker. * Layer, MarqueeSelection. * Fixing dropdown. * Fixing TextField. * Updates to Slider, Spinner, Checkbox. * Updating ProgressIndicator and Rating. * Added change file. * Fixing icon. * Fixing choicegroup feedback. * Addressing feedback. * Updating tetxfield. * Updated checkbox with full elelment name selectors * Updated spinner with full element class names * UPdated more classes to use full name * CSS modules for dropdown, added base button flexContainer to be able … (microsoft#1103) * CSS modules for dropdown, added base button flexContainer to be able to target * CHanged to long class names * Refactoring module css for PeoplePicker. (microsoft#1069) * Refactoring module css. * - Remove none used class name. - Newline at the end of file. * Add change file. * Address CR. * Updating classname. * Pivot css module. (microsoft#1066) * Pivot css module. * typo * naming convention * Adding Searchbox css modules (microsoft#1068) * Adding Searchbox css modules * Fixing PR Comments * Fixing a bug on Fabric Website * Pickers: css modularize to keep it consistent (microsoft#1065) * modularized pickers css * adding change file) * correctly using global) * CSS Module Persona (microsoft#1109) * Remove global and unindent the CSS code. * liaye * change css to module css about persona * update sass from 229-416 * change sass before 227 * Convert the CSS to Module CSS. * change sm, lg, xl * Update the Persona.tsx reference. * change constants * update persona.tsx return part * change persona.test.tsx to use module css. * update css styles * add '.' for find class for persona. * Updated persona classes, added on render function for initials * Fixed rooIsReadOnly * Fixed a missed merge conflict * CLeaned up duplicate getInitials function * Converts Nav component into modular css (microsoft#1089) * Nav component converts to module css * Flatting nested class selectors * Refactor element selectors into class based selectors * Feedback from team, naming * Fixing bugs. * Fixing another issue with focus rects in nav chevron buttons. * Module css: commandbar (microsoft#1125) * CommandBar updates. * Fixing commandbar issues. * Deleting unused classes. * CSS Modules: Facepile (microsoft#1128) * Converting to module css * Init fix for persona add button, need to fix persona first * Refactored facepile to use onRenderIcon of persona * CLeanup and fix tests * Update Facepile.scss * Fixing some typos in checkbox. * Fixing padding rule in groupedlist. * Fixing ui nits in picker. * Polish on css. Making command buttons correctly left aligned. * Updates to Panel for module css. (microsoft#1137) * Fixing Dropdown styling and focus issues. * CSS Modules: Document Card (microsoft#1149) * DetailsList: Fixing scroll utilities to handle body scroll better. (microsoft#384) * Fixing scroll utilities to handle body scroll better. * Updating appstate to support navigating directly to example pages. http://localhost:4321/index.html#/tests/detailslistbasicexample * If header is not displayed, we nullref pressing key up. * Updating to measure window correctly. * Fixing keys error. * Moving getClientRect to utility for window-sensitive scenarios. * Updating marquee selection and autoscroll to work with body scroll. * lint fixes. * Fix FacePile example onclick for RK. Remove stray commas from Layer/Button pages (microsoft#383) * Fix parameter order for FacePile example props * Fix FacePile example onClick handler. Remove 2 stray commas from Button and Layer component pages * Implement: Contextualmenu gets window from target element. (microsoft#387) * added in the ability for contextualmenu projection. * fixed lint problems * v0.56.2 * Update ListPage.tsx * CSSify DocumentCard * Change classnames in document card and fix visual regressions * Move DocumentCard styles into one root scss file and move style from global to example page * Update document card to not rely on persona * Moved details styles into global class in document card * isFileList to previewIsFilesList * Fixing test failure. * More polish. * Fixing ImageFit.cover * Setting version to beta1. * Fixed breadcrumb overflow bg on hover (microsoft#1159) * Changed button label to button text, added prop and fixed examples (microsoft#1160) * Changed button label to button text, added prop and fixed examples * put gulpfile back * Update Button.Primary.Example.tsx * Update Button.Primary.Example.tsx * Addressing tslint problems. * Bumping version. * Remove width from icon in buttons (microsoft#1167) * allow icon button to render children * microsoft#791 Fixes command bar button layout shifting on hover in HighContrast mode (microsoft#1122) * #314439 -- microsoft#791 Fixes button shifting on hover in HC mode * #314439 -- microsoft#791 Using psedo::after element to draw hover box instead of LR borders * #314439 -- microsoft#791 formatting feedback * #314439 -- microsoft#791 formatting feedback * add rush change * Changes to change file * Updates to the Panel to position absolutely. Should unbreak Outlook. * Updating package. * Add style property to IContextualMenuItem * Add change file * Fixing lint. * Fixing conflicts. * Fixes * bump. * Updated changes file * microsoft#1128 -- Fixes missing truncation in IE 11 for Persona text (microsoft#1219)
aleksandrjPersonal
pushed a commit
to aleksandrjPersonal/office-ui-fabric-react
that referenced
this pull request
Mar 10, 2017
* CSS modules: Buttons and Links (microsoft#1033) * Default/Primary fixed. * Fixed Link. * Updates to link and primary, default, and compound buttons. * Fixing command button. * Updating Command and Icon button styles. * Adding change file. * Updating comments. * CSS modules: Breadcrumb (microsoft#1035) * Updating breadcrumb to be css module compliant. * Updating breadcrumb. * CSS modules: Calendar, DatePicker (microsoft#1053) * Updated Calendar and PeoplePicker to use css modules. * Updating change file. * Fixing whitespace in test. * Updating calendar. * Fixing logic. * CSS modules: Callout, ContextualMenu, Tooltip, TeachingBubble, Dialog (microsoft#1051) * CSS modulifying callout. * Updating ContextualMenu and TeachingBubble. * Updating Tooltip * Fixing dialog. * Fixing teaching bubble names. * CSS modules: DetailsList, GroupedList (microsoft#1052) * Fixing check. * Totally fixing DetailsHeader, css modules, resizing addressed correctly. * Updating DetailsRow, Check, Fields. * Updating DetailsList rules. * Updating GroupedList, GroupHeader, GroupFooter, GroupSpacer, and addressing missing key in DetailsHeader. * Adding detailslist change file. * Code review feedback. * Fixed a few more. * fixing checked. * Found one more. * MessageBar: Convert to CSS modules (microsoft#1086) * modulify Overlay and MessageBar * Dzearing component css form (microsoft#1102) * Updated checkbox to use css modules. * Fixing indentation * Updating choicegroup. * Fixing checkmark icon. * Fixing Icon and Image. * Updating ColorPicker. * Layer, MarqueeSelection. * Fixing dropdown. * Fixing TextField. * Updates to Slider, Spinner, Checkbox. * Updating ProgressIndicator and Rating. * Added change file. * Fixing icon. * Fixing choicegroup feedback. * Addressing feedback. * Updating tetxfield. * Updated checkbox with full elelment name selectors * Updated spinner with full element class names * UPdated more classes to use full name * CSS modules for dropdown, added base button flexContainer to be able … (microsoft#1103) * CSS modules for dropdown, added base button flexContainer to be able to target * CHanged to long class names * Refactoring module css for PeoplePicker. (microsoft#1069) * Refactoring module css. * - Remove none used class name. - Newline at the end of file. * Add change file. * Address CR. * Updating classname. * Pivot css module. (microsoft#1066) * Pivot css module. * typo * naming convention * Adding Searchbox css modules (microsoft#1068) * Adding Searchbox css modules * Fixing PR Comments * Fixing a bug on Fabric Website * Pickers: css modularize to keep it consistent (microsoft#1065) * modularized pickers css * adding change file) * correctly using global) * CSS Module Persona (microsoft#1109) * Remove global and unindent the CSS code. * liaye * change css to module css about persona * update sass from 229-416 * change sass before 227 * Convert the CSS to Module CSS. * change sm, lg, xl * Update the Persona.tsx reference. * change constants * update persona.tsx return part * change persona.test.tsx to use module css. * update css styles * add '.' for find class for persona. * Updated persona classes, added on render function for initials * Fixed rooIsReadOnly * Fixed a missed merge conflict * CLeaned up duplicate getInitials function * Converts Nav component into modular css (microsoft#1089) * Nav component converts to module css * Flatting nested class selectors * Refactor element selectors into class based selectors * Feedback from team, naming * Fixing bugs. * Fixing another issue with focus rects in nav chevron buttons. * Module css: commandbar (microsoft#1125) * CommandBar updates. * Fixing commandbar issues. * Deleting unused classes. * CSS Modules: Facepile (microsoft#1128) * Converting to module css * Init fix for persona add button, need to fix persona first * Refactored facepile to use onRenderIcon of persona * CLeanup and fix tests * Update Facepile.scss * Fixing some typos in checkbox. * Fixing padding rule in groupedlist. * Fixing ui nits in picker. * Polish on css. Making command buttons correctly left aligned. * Updates to Panel for module css. (microsoft#1137) * Fixing Dropdown styling and focus issues. * CSS Modules: Document Card (microsoft#1149) * DetailsList: Fixing scroll utilities to handle body scroll better. (microsoft#384) * Fixing scroll utilities to handle body scroll better. * Updating appstate to support navigating directly to example pages. http://localhost:4321/index.html#/tests/detailslistbasicexample * If header is not displayed, we nullref pressing key up. * Updating to measure window correctly. * Fixing keys error. * Moving getClientRect to utility for window-sensitive scenarios. * Updating marquee selection and autoscroll to work with body scroll. * lint fixes. * Fix FacePile example onclick for RK. Remove stray commas from Layer/Button pages (microsoft#383) * Fix parameter order for FacePile example props * Fix FacePile example onClick handler. Remove 2 stray commas from Button and Layer component pages * Implement: Contextualmenu gets window from target element. (microsoft#387) * added in the ability for contextualmenu projection. * fixed lint problems * v0.56.2 * Update ListPage.tsx * CSSify DocumentCard * Change classnames in document card and fix visual regressions * Move DocumentCard styles into one root scss file and move style from global to example page * Update document card to not rely on persona * Moved details styles into global class in document card * isFileList to previewIsFilesList * Fixing test failure. * More polish. * Fixing ImageFit.cover * Setting version to beta1. * Fixed breadcrumb overflow bg on hover (microsoft#1159) * Changed button label to button text, added prop and fixed examples (microsoft#1160) * Changed button label to button text, added prop and fixed examples * put gulpfile back * Update Button.Primary.Example.tsx * Update Button.Primary.Example.tsx * Addressing tslint problems. * Bumping version. * Remove width from icon in buttons (microsoft#1167) * allow icon button to render children * microsoft#791 Fixes command bar button layout shifting on hover in HighContrast mode (microsoft#1122) * #314439 -- microsoft#791 Fixes button shifting on hover in HC mode * #314439 -- microsoft#791 Using psedo::after element to draw hover box instead of LR borders * #314439 -- microsoft#791 formatting feedback * #314439 -- microsoft#791 formatting feedback * add rush change * Changes to change file * Updates to the Panel to position absolutely. Should unbreak Outlook. * Updating package. * Add style property to IContextualMenuItem * Add change file * Fixing lint. * Fixing conflicts. * Fixes * bump. * Updated changes file * microsoft#1128 -- Fixes missing truncation in IE 11 for Persona text (microsoft#1219)
aleksandrjPersonal
pushed a commit
to aleksandrjPersonal/office-ui-fabric-react
that referenced
this pull request
Mar 10, 2017
* CSS modules: Buttons and Links (microsoft#1033) * Default/Primary fixed. * Fixed Link. * Updates to link and primary, default, and compound buttons. * Fixing command button. * Updating Command and Icon button styles. * Adding change file. * Updating comments. * CSS modules: Breadcrumb (microsoft#1035) * Updating breadcrumb to be css module compliant. * Updating breadcrumb. * CSS modules: Calendar, DatePicker (microsoft#1053) * Updated Calendar and PeoplePicker to use css modules. * Updating change file. * Fixing whitespace in test. * Updating calendar. * Fixing logic. * CSS modules: Callout, ContextualMenu, Tooltip, TeachingBubble, Dialog (microsoft#1051) * CSS modulifying callout. * Updating ContextualMenu and TeachingBubble. * Updating Tooltip * Fixing dialog. * Fixing teaching bubble names. * CSS modules: DetailsList, GroupedList (microsoft#1052) * Fixing check. * Totally fixing DetailsHeader, css modules, resizing addressed correctly. * Updating DetailsRow, Check, Fields. * Updating DetailsList rules. * Updating GroupedList, GroupHeader, GroupFooter, GroupSpacer, and addressing missing key in DetailsHeader. * Adding detailslist change file. * Code review feedback. * Fixed a few more. * fixing checked. * Found one more. * MessageBar: Convert to CSS modules (microsoft#1086) * modulify Overlay and MessageBar * Dzearing component css form (microsoft#1102) * Updated checkbox to use css modules. * Fixing indentation * Updating choicegroup. * Fixing checkmark icon. * Fixing Icon and Image. * Updating ColorPicker. * Layer, MarqueeSelection. * Fixing dropdown. * Fixing TextField. * Updates to Slider, Spinner, Checkbox. * Updating ProgressIndicator and Rating. * Added change file. * Fixing icon. * Fixing choicegroup feedback. * Addressing feedback. * Updating tetxfield. * Updated checkbox with full elelment name selectors * Updated spinner with full element class names * UPdated more classes to use full name * CSS modules for dropdown, added base button flexContainer to be able … (microsoft#1103) * CSS modules for dropdown, added base button flexContainer to be able to target * CHanged to long class names * Refactoring module css for PeoplePicker. (microsoft#1069) * Refactoring module css. * - Remove none used class name. - Newline at the end of file. * Add change file. * Address CR. * Updating classname. * Pivot css module. (microsoft#1066) * Pivot css module. * typo * naming convention * Adding Searchbox css modules (microsoft#1068) * Adding Searchbox css modules * Fixing PR Comments * Fixing a bug on Fabric Website * Pickers: css modularize to keep it consistent (microsoft#1065) * modularized pickers css * adding change file) * correctly using global) * CSS Module Persona (microsoft#1109) * Remove global and unindent the CSS code. * liaye * change css to module css about persona * update sass from 229-416 * change sass before 227 * Convert the CSS to Module CSS. * change sm, lg, xl * Update the Persona.tsx reference. * change constants * update persona.tsx return part * change persona.test.tsx to use module css. * update css styles * add '.' for find class for persona. * Updated persona classes, added on render function for initials * Fixed rooIsReadOnly * Fixed a missed merge conflict * CLeaned up duplicate getInitials function * Converts Nav component into modular css (microsoft#1089) * Nav component converts to module css * Flatting nested class selectors * Refactor element selectors into class based selectors * Feedback from team, naming * Fixing bugs. * Fixing another issue with focus rects in nav chevron buttons. * Module css: commandbar (microsoft#1125) * CommandBar updates. * Fixing commandbar issues. * Deleting unused classes. * CSS Modules: Facepile (microsoft#1128) * Converting to module css * Init fix for persona add button, need to fix persona first * Refactored facepile to use onRenderIcon of persona * CLeanup and fix tests * Update Facepile.scss * Fixing some typos in checkbox. * Fixing padding rule in groupedlist. * Fixing ui nits in picker. * Polish on css. Making command buttons correctly left aligned. * Updates to Panel for module css. (microsoft#1137) * Fixing Dropdown styling and focus issues. * CSS Modules: Document Card (microsoft#1149) * DetailsList: Fixing scroll utilities to handle body scroll better. (microsoft#384) * Fixing scroll utilities to handle body scroll better. * Updating appstate to support navigating directly to example pages. http://localhost:4321/index.html#/tests/detailslistbasicexample * If header is not displayed, we nullref pressing key up. * Updating to measure window correctly. * Fixing keys error. * Moving getClientRect to utility for window-sensitive scenarios. * Updating marquee selection and autoscroll to work with body scroll. * lint fixes. * Fix FacePile example onclick for RK. Remove stray commas from Layer/Button pages (microsoft#383) * Fix parameter order for FacePile example props * Fix FacePile example onClick handler. Remove 2 stray commas from Button and Layer component pages * Implement: Contextualmenu gets window from target element. (microsoft#387) * added in the ability for contextualmenu projection. * fixed lint problems * v0.56.2 * Update ListPage.tsx * CSSify DocumentCard * Change classnames in document card and fix visual regressions * Move DocumentCard styles into one root scss file and move style from global to example page * Update document card to not rely on persona * Moved details styles into global class in document card * isFileList to previewIsFilesList * Fixing test failure. * More polish. * Fixing ImageFit.cover * Setting version to beta1. * Fixed breadcrumb overflow bg on hover (microsoft#1159) * Changed button label to button text, added prop and fixed examples (microsoft#1160) * Changed button label to button text, added prop and fixed examples * put gulpfile back * Update Button.Primary.Example.tsx * Update Button.Primary.Example.tsx * Addressing tslint problems. * Bumping version. * Remove width from icon in buttons (microsoft#1167) * allow icon button to render children * microsoft#791 Fixes command bar button layout shifting on hover in HighContrast mode (microsoft#1122) * #314439 -- microsoft#791 Fixes button shifting on hover in HC mode * #314439 -- microsoft#791 Using psedo::after element to draw hover box instead of LR borders * #314439 -- microsoft#791 formatting feedback * #314439 -- microsoft#791 formatting feedback * add rush change * Changes to change file * Updates to the Panel to position absolutely. Should unbreak Outlook. * Updating package. * Add style property to IContextualMenuItem * Add change file * Fixing lint. * Fixing conflicts. * Fixes * bump. * Updated changes file * microsoft#1128 -- Fixes missing truncation in IE 11 for Persona text (microsoft#1219)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update People Picker with module css.