Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to module css! #1211

Merged
merged 62 commits into from
Mar 9, 2017
Merged

Migration to module css! #1211

merged 62 commits into from
Mar 9, 2017

Conversation

dzearing
Copy link
Member

@dzearing dzearing commented Mar 8, 2017

IMPORTANT:

This pull request converts ALL components over to use module css. What does this mean?

  • All classnames, such as ms-Button, will now be obfuscated to be unique.
  • Pages that host multiple versions of the same component will not stomp on each other and will be safe.
  • All existing class names are left intact, so current customizations should not break.

Going forward, we will adhere to using local scoped module rules specifically to avoid breaking ourselves when multiple versions. Additionally we are evaluating a much more robust and contractual way of defining our styles.

Problems that still exist:

  1. You must rely on class names to customize, and if those class names change, your customizations are broken.
  2. Specificity of our rules is an implicit contract that is easy to break. It is often unclear and partners usually give up early fighting the specificity war and use !important to stomp on it, which is not ideal. If a partner does use "more specific" rules today, tomorrow they many not be specific enough.
  3. RTL rules in particular are very specific. When something that was once not RTL specific is changed to RTL, it becomes implicitly more specific, and thus breaks specificity contract.
  4. The bundles themselves have a lot of duplicate css. Because we generate rtl rules and theme tokens at build time rather than at runtime, we must download extra code, which bulks up the download size.
  5. Fabric core rules, which we implicitly rely on, are a hard thing to chase. If your page depends on core 6, and you're also using react components, you will find bugs. We'd like to eliminate this dependency so that it is reliable and contractual to use components. If you use a ContextualMenu, it should animate without depending on fabric-core css to be loaded.

We are planning to address these and evaluating library options. Issue being tracked here: #983

dzearing and others added 30 commits February 21, 2017 15:43
* Default/Primary fixed.

* Fixed Link.

* Updates to link and primary, default, and compound buttons.

* Fixing command button.

* Updating Command and Icon button styles.

* Adding change file.

* Updating comments.
* Updating breadcrumb to be css module compliant.

* Updating breadcrumb.
* Updated Calendar and PeoplePicker to use css modules.

* Updating change file.

* Fixing whitespace in test.

* Updating calendar.

* Fixing logic.
…#1051)

* CSS modulifying callout.

* Updating ContextualMenu and TeachingBubble.

* Updating Tooltip

* Fixing dialog.

* Fixing teaching bubble names.
* Fixing check.

* Totally fixing DetailsHeader, css modules, resizing addressed correctly.

* Updating DetailsRow, Check, Fields.

* Updating DetailsList rules.

* Updating GroupedList, GroupHeader, GroupFooter, GroupSpacer, and addressing missing key in DetailsHeader.

* Adding detailslist change file.

* Code review feedback.

* Fixed a few more.

* fixing checked.

* Found one more.
* modulify Overlay and MessageBar
* Updated checkbox to use css modules.

* Fixing indentation

* Updating choicegroup.

* Fixing checkmark icon.

* Fixing Icon and Image.

* Updating ColorPicker.

* Layer, MarqueeSelection.

* Fixing dropdown.

* Fixing TextField.

* Updates to Slider, Spinner, Checkbox.

* Updating ProgressIndicator and Rating.

* Added change file.

* Fixing icon.

* Fixing choicegroup feedback.

* Addressing feedback.

* Updating tetxfield.

* Updated checkbox with full elelment name selectors

* Updated spinner with full element class names

* UPdated more classes to use full name
#1103)

* CSS modules for dropdown, added base button flexContainer to be able to target

* CHanged to long class names
* Refactoring module css.

* - Remove none used class name.
- Newline at the end of file.

* Add change file.

* Address CR.

* Updating classname.
* Pivot css module.

* typo

* naming convention
…c-react into module-css-updates

# Conflicts:
#	packages/office-ui-fabric-react/src/components/DetailsList/DetailsHeader.tsx
* Adding Searchbox css modules

* Fixing PR Comments

* Fixing a bug on Fabric Website
* modularized pickers css

* adding change file)

* correctly using global)
* Remove global and unindent the CSS code.

* liaye

* change css to module css about persona

* update sass from 229-416

* change sass before 227

* Convert the CSS to Module CSS.

* change sm, lg, xl

* Update the Persona.tsx reference.

* change constants

* update persona.tsx return part

* change persona.test.tsx to use module css.

* update css styles

* add '.' for find class for persona.

* Updated persona classes, added on render function for initials

* Fixed rooIsReadOnly

* Fixed a missed merge conflict

* CLeaned up duplicate getInitials function
* Nav component converts to module css

* Flatting nested class selectors

* Refactor element selectors into class based selectors

* Feedback from team, naming

* Fixing bugs.

* Fixing another issue with focus rects in nav chevron buttons.
* CommandBar updates.

* Fixing commandbar issues.

* Deleting unused classes.
…c-react into module-css-updates

# Conflicts:
#	common/npm-shrinkwrap.json
#	common/temp_modules/rush-example-app-base/package.json
#	common/temp_modules/rush-fabric-examples/package.json
#	common/temp_modules/rush-fabric-website/package.json
#	common/temp_modules/rush-ssr-tests/package.json
#	common/temp_modules/rush-todo-app/package.json
* Converting to module css

* Init fix for persona add button, need to fix persona first

* Refactored facepile to use onRenderIcon of persona

* CLeanup and fix tests

* Update Facepile.scss
* DetailsList: Fixing scroll utilities to handle body scroll better. (#384)

* Fixing scroll utilities to handle body scroll better.

* Updating appstate to support navigating directly to example pages. http://localhost:4321/index.html#/tests/detailslistbasicexample

* If header is not displayed, we nullref pressing key up.

* Updating to measure window correctly.

* Fixing keys error.

* Moving getClientRect to utility for window-sensitive scenarios.

* Updating marquee selection and autoscroll to work with body scroll.

* lint fixes.

* Fix FacePile example onclick for RK.  Remove stray commas from Layer/Button pages (#383)

* Fix parameter order for FacePile example props

* Fix FacePile example onClick handler.  Remove 2 stray commas from Button and Layer component pages

* Implement: Contextualmenu gets window from target element. (#387)

* added in the ability for contextualmenu projection.

* fixed lint problems

* v0.56.2

* Update ListPage.tsx

* CSSify DocumentCard

* Change classnames in document card and fix visual regressions

* Move DocumentCard styles into one root scss file and move style from global to example page

* Update document card to not rely on persona

* Moved details styles into global class in document card

* isFileList to previewIsFilesList
micahgodbolt and others added 15 commits March 2, 2017 11:28
…t mode (#1122)

* #314439 -- #791 Fixes button shifting on hover in HC mode

* #314439 -- #791 Using psedo::after element to draw hover box instead of LR borders

* #314439 -- #791 formatting feedback

* #314439 -- #791 formatting feedback

* add rush change

* Changes to change file
Add style property to IContextualMenuItem
…c-react into module-css-updates

# Conflicts:
#	packages/office-ui-fabric-react/package.json
#	packages/office-ui-fabric-react/src/components/Image/Image.tsx
#	packages/office-ui-fabric-react/src/components/Persona/Persona.tsx
…c-react into module-css-updates

# Conflicts:
#	apps/fabric-examples/src/pages/DropdownPage/examples/Dropdown.Basic.Example.tsx
#	packages/office-ui-fabric-react/src/components/Breadcrumb/Breadcrumb.tsx
#	packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.tsx
#	packages/office-ui-fabric-react/src/components/MessageBar/MessageBar.test.tsx
#	packages/office-ui-fabric-react/src/components/MessageBar/MessageBar.tsx
#	packages/office-ui-fabric-react/src/components/TextField/TextField.tsx
@dzearing dzearing merged commit 39deee7 into master Mar 9, 2017
aleksandrjPersonal pushed a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this pull request Mar 10, 2017
* CSS modules: Buttons and Links (microsoft#1033)

* Default/Primary fixed.

* Fixed Link.

* Updates to link and primary, default, and compound buttons.

* Fixing command button.

* Updating Command and Icon button styles.

* Adding change file.

* Updating comments.

* CSS modules: Breadcrumb (microsoft#1035)

* Updating breadcrumb to be css module compliant.

* Updating breadcrumb.

* CSS modules: Calendar, DatePicker (microsoft#1053)

* Updated Calendar and PeoplePicker to use css modules.

* Updating change file.

* Fixing whitespace in test.

* Updating calendar.

* Fixing logic.

* CSS modules: Callout, ContextualMenu, Tooltip, TeachingBubble, Dialog (microsoft#1051)

* CSS modulifying callout.

* Updating ContextualMenu and TeachingBubble.

* Updating Tooltip

* Fixing dialog.

* Fixing teaching bubble names.

* CSS modules: DetailsList, GroupedList (microsoft#1052)

* Fixing check.

* Totally fixing DetailsHeader, css modules, resizing addressed correctly.

* Updating DetailsRow, Check, Fields.

* Updating DetailsList rules.

* Updating GroupedList, GroupHeader, GroupFooter, GroupSpacer, and addressing missing key in DetailsHeader.

* Adding detailslist change file.

* Code review feedback.

* Fixed a few more.

* fixing checked.

* Found one more.

* MessageBar: Convert to CSS modules (microsoft#1086)

* modulify Overlay and MessageBar

* Dzearing component css form (microsoft#1102)

* Updated checkbox to use css modules.

* Fixing indentation

* Updating choicegroup.

* Fixing checkmark icon.

* Fixing Icon and Image.

* Updating ColorPicker.

* Layer, MarqueeSelection.

* Fixing dropdown.

* Fixing TextField.

* Updates to Slider, Spinner, Checkbox.

* Updating ProgressIndicator and Rating.

* Added change file.

* Fixing icon.

* Fixing choicegroup feedback.

* Addressing feedback.

* Updating tetxfield.

* Updated checkbox with full elelment name selectors

* Updated spinner with full element class names

* UPdated more classes to use full name

* CSS modules for dropdown, added base button flexContainer to be able … (microsoft#1103)

* CSS modules for dropdown, added base button flexContainer to be able to target

* CHanged to long class names

* Refactoring module css for PeoplePicker. (microsoft#1069)

* Refactoring module css.

* - Remove none used class name.
- Newline at the end of file.

* Add change file.

* Address CR.

* Updating classname.

* Pivot css module. (microsoft#1066)

* Pivot css module.

* typo

* naming convention

* Adding Searchbox css modules (microsoft#1068)

* Adding Searchbox css modules

* Fixing PR Comments

* Fixing a bug on Fabric Website

* Pickers: css modularize to keep it consistent (microsoft#1065)

* modularized pickers css

* adding change file)

* correctly using global)

* CSS Module Persona (microsoft#1109)

* Remove global and unindent the CSS code.

* liaye

* change css to module css about persona

* update sass from 229-416

* change sass before 227

* Convert the CSS to Module CSS.

* change sm, lg, xl

* Update the Persona.tsx reference.

* change constants

* update persona.tsx return part

* change persona.test.tsx to use module css.

* update css styles

* add '.' for find class for persona.

* Updated persona classes, added on render function for initials

* Fixed rooIsReadOnly

* Fixed a missed merge conflict

* CLeaned up duplicate getInitials function

* Converts Nav component into modular css (microsoft#1089)

* Nav component converts to module css

* Flatting nested class selectors

* Refactor element selectors into class based selectors

* Feedback from team, naming

* Fixing bugs.

* Fixing another issue with focus rects in nav chevron buttons.

* Module css: commandbar (microsoft#1125)

* CommandBar updates.

* Fixing commandbar issues.

* Deleting unused classes.

* CSS Modules: Facepile (microsoft#1128)

* Converting to module css

* Init fix for persona add button, need to fix persona first

* Refactored facepile to use onRenderIcon of persona

* CLeanup and fix tests

* Update Facepile.scss

* Fixing some typos in checkbox.

* Fixing padding rule in groupedlist.

* Fixing ui nits in picker.

* Polish on css. Making command buttons correctly left aligned.

* Updates to Panel for module css. (microsoft#1137)

* Fixing Dropdown styling and focus issues.

* CSS Modules: Document Card (microsoft#1149)

* DetailsList: Fixing scroll utilities to handle body scroll better. (microsoft#384)

* Fixing scroll utilities to handle body scroll better.

* Updating appstate to support navigating directly to example pages. http://localhost:4321/index.html#/tests/detailslistbasicexample

* If header is not displayed, we nullref pressing key up.

* Updating to measure window correctly.

* Fixing keys error.

* Moving getClientRect to utility for window-sensitive scenarios.

* Updating marquee selection and autoscroll to work with body scroll.

* lint fixes.

* Fix FacePile example onclick for RK.  Remove stray commas from Layer/Button pages (microsoft#383)

* Fix parameter order for FacePile example props

* Fix FacePile example onClick handler.  Remove 2 stray commas from Button and Layer component pages

* Implement: Contextualmenu gets window from target element. (microsoft#387)

* added in the ability for contextualmenu projection.

* fixed lint problems

* v0.56.2

* Update ListPage.tsx

* CSSify DocumentCard

* Change classnames in document card and fix visual regressions

* Move DocumentCard styles into one root scss file and move style from global to example page

* Update document card to not rely on persona

* Moved details styles into global class in document card

* isFileList to previewIsFilesList

* Fixing test failure.

* More polish.

* Fixing ImageFit.cover

* Setting version to beta1.

* Fixed breadcrumb overflow bg on hover (microsoft#1159)

* Changed button label to button text, added prop and fixed examples (microsoft#1160)

* Changed button label to button text, added prop and fixed examples

* put gulpfile back

* Update Button.Primary.Example.tsx

* Update Button.Primary.Example.tsx

* Addressing tslint problems.

* Bumping version.

* Remove width from icon in buttons (microsoft#1167)

* allow icon button to render children

* microsoft#791 Fixes command bar button layout shifting on hover in HighContrast mode (microsoft#1122)

* #314439 -- microsoft#791 Fixes button shifting on hover in HC mode

* #314439 -- microsoft#791 Using psedo::after element to draw hover box instead of LR borders

* #314439 -- microsoft#791 formatting feedback

* #314439 -- microsoft#791 formatting feedback

* add rush change

* Changes to change file

* Updates to the Panel to position absolutely. Should unbreak Outlook.

* Updating package.

* Add style property to IContextualMenuItem

* Add change file

* Fixing lint.

* Fixing conflicts.

* Fixes

* bump.

* Updated changes file

* microsoft#1128 -- Fixes missing truncation in IE 11 for Persona text (microsoft#1219)
aleksandrjPersonal pushed a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this pull request Mar 10, 2017
* CSS modules: Buttons and Links (microsoft#1033)

* Default/Primary fixed.

* Fixed Link.

* Updates to link and primary, default, and compound buttons.

* Fixing command button.

* Updating Command and Icon button styles.

* Adding change file.

* Updating comments.

* CSS modules: Breadcrumb (microsoft#1035)

* Updating breadcrumb to be css module compliant.

* Updating breadcrumb.

* CSS modules: Calendar, DatePicker (microsoft#1053)

* Updated Calendar and PeoplePicker to use css modules.

* Updating change file.

* Fixing whitespace in test.

* Updating calendar.

* Fixing logic.

* CSS modules: Callout, ContextualMenu, Tooltip, TeachingBubble, Dialog (microsoft#1051)

* CSS modulifying callout.

* Updating ContextualMenu and TeachingBubble.

* Updating Tooltip

* Fixing dialog.

* Fixing teaching bubble names.

* CSS modules: DetailsList, GroupedList (microsoft#1052)

* Fixing check.

* Totally fixing DetailsHeader, css modules, resizing addressed correctly.

* Updating DetailsRow, Check, Fields.

* Updating DetailsList rules.

* Updating GroupedList, GroupHeader, GroupFooter, GroupSpacer, and addressing missing key in DetailsHeader.

* Adding detailslist change file.

* Code review feedback.

* Fixed a few more.

* fixing checked.

* Found one more.

* MessageBar: Convert to CSS modules (microsoft#1086)

* modulify Overlay and MessageBar

* Dzearing component css form (microsoft#1102)

* Updated checkbox to use css modules.

* Fixing indentation

* Updating choicegroup.

* Fixing checkmark icon.

* Fixing Icon and Image.

* Updating ColorPicker.

* Layer, MarqueeSelection.

* Fixing dropdown.

* Fixing TextField.

* Updates to Slider, Spinner, Checkbox.

* Updating ProgressIndicator and Rating.

* Added change file.

* Fixing icon.

* Fixing choicegroup feedback.

* Addressing feedback.

* Updating tetxfield.

* Updated checkbox with full elelment name selectors

* Updated spinner with full element class names

* UPdated more classes to use full name

* CSS modules for dropdown, added base button flexContainer to be able … (microsoft#1103)

* CSS modules for dropdown, added base button flexContainer to be able to target

* CHanged to long class names

* Refactoring module css for PeoplePicker. (microsoft#1069)

* Refactoring module css.

* - Remove none used class name.
- Newline at the end of file.

* Add change file.

* Address CR.

* Updating classname.

* Pivot css module. (microsoft#1066)

* Pivot css module.

* typo

* naming convention

* Adding Searchbox css modules (microsoft#1068)

* Adding Searchbox css modules

* Fixing PR Comments

* Fixing a bug on Fabric Website

* Pickers: css modularize to keep it consistent (microsoft#1065)

* modularized pickers css

* adding change file)

* correctly using global)

* CSS Module Persona (microsoft#1109)

* Remove global and unindent the CSS code.

* liaye

* change css to module css about persona

* update sass from 229-416

* change sass before 227

* Convert the CSS to Module CSS.

* change sm, lg, xl

* Update the Persona.tsx reference.

* change constants

* update persona.tsx return part

* change persona.test.tsx to use module css.

* update css styles

* add '.' for find class for persona.

* Updated persona classes, added on render function for initials

* Fixed rooIsReadOnly

* Fixed a missed merge conflict

* CLeaned up duplicate getInitials function

* Converts Nav component into modular css (microsoft#1089)

* Nav component converts to module css

* Flatting nested class selectors

* Refactor element selectors into class based selectors

* Feedback from team, naming

* Fixing bugs.

* Fixing another issue with focus rects in nav chevron buttons.

* Module css: commandbar (microsoft#1125)

* CommandBar updates.

* Fixing commandbar issues.

* Deleting unused classes.

* CSS Modules: Facepile (microsoft#1128)

* Converting to module css

* Init fix for persona add button, need to fix persona first

* Refactored facepile to use onRenderIcon of persona

* CLeanup and fix tests

* Update Facepile.scss

* Fixing some typos in checkbox.

* Fixing padding rule in groupedlist.

* Fixing ui nits in picker.

* Polish on css. Making command buttons correctly left aligned.

* Updates to Panel for module css. (microsoft#1137)

* Fixing Dropdown styling and focus issues.

* CSS Modules: Document Card (microsoft#1149)

* DetailsList: Fixing scroll utilities to handle body scroll better. (microsoft#384)

* Fixing scroll utilities to handle body scroll better.

* Updating appstate to support navigating directly to example pages. http://localhost:4321/index.html#/tests/detailslistbasicexample

* If header is not displayed, we nullref pressing key up.

* Updating to measure window correctly.

* Fixing keys error.

* Moving getClientRect to utility for window-sensitive scenarios.

* Updating marquee selection and autoscroll to work with body scroll.

* lint fixes.

* Fix FacePile example onclick for RK.  Remove stray commas from Layer/Button pages (microsoft#383)

* Fix parameter order for FacePile example props

* Fix FacePile example onClick handler.  Remove 2 stray commas from Button and Layer component pages

* Implement: Contextualmenu gets window from target element. (microsoft#387)

* added in the ability for contextualmenu projection.

* fixed lint problems

* v0.56.2

* Update ListPage.tsx

* CSSify DocumentCard

* Change classnames in document card and fix visual regressions

* Move DocumentCard styles into one root scss file and move style from global to example page

* Update document card to not rely on persona

* Moved details styles into global class in document card

* isFileList to previewIsFilesList

* Fixing test failure.

* More polish.

* Fixing ImageFit.cover

* Setting version to beta1.

* Fixed breadcrumb overflow bg on hover (microsoft#1159)

* Changed button label to button text, added prop and fixed examples (microsoft#1160)

* Changed button label to button text, added prop and fixed examples

* put gulpfile back

* Update Button.Primary.Example.tsx

* Update Button.Primary.Example.tsx

* Addressing tslint problems.

* Bumping version.

* Remove width from icon in buttons (microsoft#1167)

* allow icon button to render children

* microsoft#791 Fixes command bar button layout shifting on hover in HighContrast mode (microsoft#1122)

* #314439 -- microsoft#791 Fixes button shifting on hover in HC mode

* #314439 -- microsoft#791 Using psedo::after element to draw hover box instead of LR borders

* #314439 -- microsoft#791 formatting feedback

* #314439 -- microsoft#791 formatting feedback

* add rush change

* Changes to change file

* Updates to the Panel to position absolutely. Should unbreak Outlook.

* Updating package.

* Add style property to IContextualMenuItem

* Add change file

* Fixing lint.

* Fixing conflicts.

* Fixes

* bump.

* Updated changes file

* microsoft#1128 -- Fixes missing truncation in IE 11 for Persona text (microsoft#1219)
aleksandrjPersonal pushed a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this pull request Mar 10, 2017
* CSS modules: Buttons and Links (microsoft#1033)

* Default/Primary fixed.

* Fixed Link.

* Updates to link and primary, default, and compound buttons.

* Fixing command button.

* Updating Command and Icon button styles.

* Adding change file.

* Updating comments.

* CSS modules: Breadcrumb (microsoft#1035)

* Updating breadcrumb to be css module compliant.

* Updating breadcrumb.

* CSS modules: Calendar, DatePicker (microsoft#1053)

* Updated Calendar and PeoplePicker to use css modules.

* Updating change file.

* Fixing whitespace in test.

* Updating calendar.

* Fixing logic.

* CSS modules: Callout, ContextualMenu, Tooltip, TeachingBubble, Dialog (microsoft#1051)

* CSS modulifying callout.

* Updating ContextualMenu and TeachingBubble.

* Updating Tooltip

* Fixing dialog.

* Fixing teaching bubble names.

* CSS modules: DetailsList, GroupedList (microsoft#1052)

* Fixing check.

* Totally fixing DetailsHeader, css modules, resizing addressed correctly.

* Updating DetailsRow, Check, Fields.

* Updating DetailsList rules.

* Updating GroupedList, GroupHeader, GroupFooter, GroupSpacer, and addressing missing key in DetailsHeader.

* Adding detailslist change file.

* Code review feedback.

* Fixed a few more.

* fixing checked.

* Found one more.

* MessageBar: Convert to CSS modules (microsoft#1086)

* modulify Overlay and MessageBar

* Dzearing component css form (microsoft#1102)

* Updated checkbox to use css modules.

* Fixing indentation

* Updating choicegroup.

* Fixing checkmark icon.

* Fixing Icon and Image.

* Updating ColorPicker.

* Layer, MarqueeSelection.

* Fixing dropdown.

* Fixing TextField.

* Updates to Slider, Spinner, Checkbox.

* Updating ProgressIndicator and Rating.

* Added change file.

* Fixing icon.

* Fixing choicegroup feedback.

* Addressing feedback.

* Updating tetxfield.

* Updated checkbox with full elelment name selectors

* Updated spinner with full element class names

* UPdated more classes to use full name

* CSS modules for dropdown, added base button flexContainer to be able … (microsoft#1103)

* CSS modules for dropdown, added base button flexContainer to be able to target

* CHanged to long class names

* Refactoring module css for PeoplePicker. (microsoft#1069)

* Refactoring module css.

* - Remove none used class name.
- Newline at the end of file.

* Add change file.

* Address CR.

* Updating classname.

* Pivot css module. (microsoft#1066)

* Pivot css module.

* typo

* naming convention

* Adding Searchbox css modules (microsoft#1068)

* Adding Searchbox css modules

* Fixing PR Comments

* Fixing a bug on Fabric Website

* Pickers: css modularize to keep it consistent (microsoft#1065)

* modularized pickers css

* adding change file)

* correctly using global)

* CSS Module Persona (microsoft#1109)

* Remove global and unindent the CSS code.

* liaye

* change css to module css about persona

* update sass from 229-416

* change sass before 227

* Convert the CSS to Module CSS.

* change sm, lg, xl

* Update the Persona.tsx reference.

* change constants

* update persona.tsx return part

* change persona.test.tsx to use module css.

* update css styles

* add '.' for find class for persona.

* Updated persona classes, added on render function for initials

* Fixed rooIsReadOnly

* Fixed a missed merge conflict

* CLeaned up duplicate getInitials function

* Converts Nav component into modular css (microsoft#1089)

* Nav component converts to module css

* Flatting nested class selectors

* Refactor element selectors into class based selectors

* Feedback from team, naming

* Fixing bugs.

* Fixing another issue with focus rects in nav chevron buttons.

* Module css: commandbar (microsoft#1125)

* CommandBar updates.

* Fixing commandbar issues.

* Deleting unused classes.

* CSS Modules: Facepile (microsoft#1128)

* Converting to module css

* Init fix for persona add button, need to fix persona first

* Refactored facepile to use onRenderIcon of persona

* CLeanup and fix tests

* Update Facepile.scss

* Fixing some typos in checkbox.

* Fixing padding rule in groupedlist.

* Fixing ui nits in picker.

* Polish on css. Making command buttons correctly left aligned.

* Updates to Panel for module css. (microsoft#1137)

* Fixing Dropdown styling and focus issues.

* CSS Modules: Document Card (microsoft#1149)

* DetailsList: Fixing scroll utilities to handle body scroll better. (microsoft#384)

* Fixing scroll utilities to handle body scroll better.

* Updating appstate to support navigating directly to example pages. http://localhost:4321/index.html#/tests/detailslistbasicexample

* If header is not displayed, we nullref pressing key up.

* Updating to measure window correctly.

* Fixing keys error.

* Moving getClientRect to utility for window-sensitive scenarios.

* Updating marquee selection and autoscroll to work with body scroll.

* lint fixes.

* Fix FacePile example onclick for RK.  Remove stray commas from Layer/Button pages (microsoft#383)

* Fix parameter order for FacePile example props

* Fix FacePile example onClick handler.  Remove 2 stray commas from Button and Layer component pages

* Implement: Contextualmenu gets window from target element. (microsoft#387)

* added in the ability for contextualmenu projection.

* fixed lint problems

* v0.56.2

* Update ListPage.tsx

* CSSify DocumentCard

* Change classnames in document card and fix visual regressions

* Move DocumentCard styles into one root scss file and move style from global to example page

* Update document card to not rely on persona

* Moved details styles into global class in document card

* isFileList to previewIsFilesList

* Fixing test failure.

* More polish.

* Fixing ImageFit.cover

* Setting version to beta1.

* Fixed breadcrumb overflow bg on hover (microsoft#1159)

* Changed button label to button text, added prop and fixed examples (microsoft#1160)

* Changed button label to button text, added prop and fixed examples

* put gulpfile back

* Update Button.Primary.Example.tsx

* Update Button.Primary.Example.tsx

* Addressing tslint problems.

* Bumping version.

* Remove width from icon in buttons (microsoft#1167)

* allow icon button to render children

* microsoft#791 Fixes command bar button layout shifting on hover in HighContrast mode (microsoft#1122)

* #314439 -- microsoft#791 Fixes button shifting on hover in HC mode

* #314439 -- microsoft#791 Using psedo::after element to draw hover box instead of LR borders

* #314439 -- microsoft#791 formatting feedback

* #314439 -- microsoft#791 formatting feedback

* add rush change

* Changes to change file

* Updates to the Panel to position absolutely. Should unbreak Outlook.

* Updating package.

* Add style property to IContextualMenuItem

* Add change file

* Fixing lint.

* Fixing conflicts.

* Fixes

* bump.

* Updated changes file

* microsoft#1128 -- Fixes missing truncation in IE 11 for Persona text (microsoft#1219)
aleksandrjPersonal pushed a commit to aleksandrjPersonal/office-ui-fabric-react that referenced this pull request Mar 10, 2017
* CSS modules: Buttons and Links (microsoft#1033)

* Default/Primary fixed.

* Fixed Link.

* Updates to link and primary, default, and compound buttons.

* Fixing command button.

* Updating Command and Icon button styles.

* Adding change file.

* Updating comments.

* CSS modules: Breadcrumb (microsoft#1035)

* Updating breadcrumb to be css module compliant.

* Updating breadcrumb.

* CSS modules: Calendar, DatePicker (microsoft#1053)

* Updated Calendar and PeoplePicker to use css modules.

* Updating change file.

* Fixing whitespace in test.

* Updating calendar.

* Fixing logic.

* CSS modules: Callout, ContextualMenu, Tooltip, TeachingBubble, Dialog (microsoft#1051)

* CSS modulifying callout.

* Updating ContextualMenu and TeachingBubble.

* Updating Tooltip

* Fixing dialog.

* Fixing teaching bubble names.

* CSS modules: DetailsList, GroupedList (microsoft#1052)

* Fixing check.

* Totally fixing DetailsHeader, css modules, resizing addressed correctly.

* Updating DetailsRow, Check, Fields.

* Updating DetailsList rules.

* Updating GroupedList, GroupHeader, GroupFooter, GroupSpacer, and addressing missing key in DetailsHeader.

* Adding detailslist change file.

* Code review feedback.

* Fixed a few more.

* fixing checked.

* Found one more.

* MessageBar: Convert to CSS modules (microsoft#1086)

* modulify Overlay and MessageBar

* Dzearing component css form (microsoft#1102)

* Updated checkbox to use css modules.

* Fixing indentation

* Updating choicegroup.

* Fixing checkmark icon.

* Fixing Icon and Image.

* Updating ColorPicker.

* Layer, MarqueeSelection.

* Fixing dropdown.

* Fixing TextField.

* Updates to Slider, Spinner, Checkbox.

* Updating ProgressIndicator and Rating.

* Added change file.

* Fixing icon.

* Fixing choicegroup feedback.

* Addressing feedback.

* Updating tetxfield.

* Updated checkbox with full elelment name selectors

* Updated spinner with full element class names

* UPdated more classes to use full name

* CSS modules for dropdown, added base button flexContainer to be able … (microsoft#1103)

* CSS modules for dropdown, added base button flexContainer to be able to target

* CHanged to long class names

* Refactoring module css for PeoplePicker. (microsoft#1069)

* Refactoring module css.

* - Remove none used class name.
- Newline at the end of file.

* Add change file.

* Address CR.

* Updating classname.

* Pivot css module. (microsoft#1066)

* Pivot css module.

* typo

* naming convention

* Adding Searchbox css modules (microsoft#1068)

* Adding Searchbox css modules

* Fixing PR Comments

* Fixing a bug on Fabric Website

* Pickers: css modularize to keep it consistent (microsoft#1065)

* modularized pickers css

* adding change file)

* correctly using global)

* CSS Module Persona (microsoft#1109)

* Remove global and unindent the CSS code.

* liaye

* change css to module css about persona

* update sass from 229-416

* change sass before 227

* Convert the CSS to Module CSS.

* change sm, lg, xl

* Update the Persona.tsx reference.

* change constants

* update persona.tsx return part

* change persona.test.tsx to use module css.

* update css styles

* add '.' for find class for persona.

* Updated persona classes, added on render function for initials

* Fixed rooIsReadOnly

* Fixed a missed merge conflict

* CLeaned up duplicate getInitials function

* Converts Nav component into modular css (microsoft#1089)

* Nav component converts to module css

* Flatting nested class selectors

* Refactor element selectors into class based selectors

* Feedback from team, naming

* Fixing bugs.

* Fixing another issue with focus rects in nav chevron buttons.

* Module css: commandbar (microsoft#1125)

* CommandBar updates.

* Fixing commandbar issues.

* Deleting unused classes.

* CSS Modules: Facepile (microsoft#1128)

* Converting to module css

* Init fix for persona add button, need to fix persona first

* Refactored facepile to use onRenderIcon of persona

* CLeanup and fix tests

* Update Facepile.scss

* Fixing some typos in checkbox.

* Fixing padding rule in groupedlist.

* Fixing ui nits in picker.

* Polish on css. Making command buttons correctly left aligned.

* Updates to Panel for module css. (microsoft#1137)

* Fixing Dropdown styling and focus issues.

* CSS Modules: Document Card (microsoft#1149)

* DetailsList: Fixing scroll utilities to handle body scroll better. (microsoft#384)

* Fixing scroll utilities to handle body scroll better.

* Updating appstate to support navigating directly to example pages. http://localhost:4321/index.html#/tests/detailslistbasicexample

* If header is not displayed, we nullref pressing key up.

* Updating to measure window correctly.

* Fixing keys error.

* Moving getClientRect to utility for window-sensitive scenarios.

* Updating marquee selection and autoscroll to work with body scroll.

* lint fixes.

* Fix FacePile example onclick for RK.  Remove stray commas from Layer/Button pages (microsoft#383)

* Fix parameter order for FacePile example props

* Fix FacePile example onClick handler.  Remove 2 stray commas from Button and Layer component pages

* Implement: Contextualmenu gets window from target element. (microsoft#387)

* added in the ability for contextualmenu projection.

* fixed lint problems

* v0.56.2

* Update ListPage.tsx

* CSSify DocumentCard

* Change classnames in document card and fix visual regressions

* Move DocumentCard styles into one root scss file and move style from global to example page

* Update document card to not rely on persona

* Moved details styles into global class in document card

* isFileList to previewIsFilesList

* Fixing test failure.

* More polish.

* Fixing ImageFit.cover

* Setting version to beta1.

* Fixed breadcrumb overflow bg on hover (microsoft#1159)

* Changed button label to button text, added prop and fixed examples (microsoft#1160)

* Changed button label to button text, added prop and fixed examples

* put gulpfile back

* Update Button.Primary.Example.tsx

* Update Button.Primary.Example.tsx

* Addressing tslint problems.

* Bumping version.

* Remove width from icon in buttons (microsoft#1167)

* allow icon button to render children

* microsoft#791 Fixes command bar button layout shifting on hover in HighContrast mode (microsoft#1122)

* #314439 -- microsoft#791 Fixes button shifting on hover in HC mode

* #314439 -- microsoft#791 Using psedo::after element to draw hover box instead of LR borders

* #314439 -- microsoft#791 formatting feedback

* #314439 -- microsoft#791 formatting feedback

* add rush change

* Changes to change file

* Updates to the Panel to position absolutely. Should unbreak Outlook.

* Updating package.

* Add style property to IContextualMenuItem

* Add change file

* Fixing lint.

* Fixing conflicts.

* Fixes

* bump.

* Updated changes file

* microsoft#1128 -- Fixes missing truncation in IE 11 for Persona text (microsoft#1219)
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants