Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persona: Migrate Persona and PersonaCoin to function components #13645

Merged
merged 22 commits into from
Jun 22, 2020

Conversation

MLoughry
Copy link
Contributor

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

Migrate Persona and PersonaCoin to function components in the react-next package

Focus areas to test

(optional)

@size-auditor
Copy link

size-auditor bot commented Jun 17, 2020

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 5be1ae0

Possible causes

  • The baseline build 5be1ae0 is broken
  • The Size Auditor run for the baseline build 5be1ae0 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Jun 17, 2020

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 891 841 5000
ButtonNext mount 525 488 5000
Checkbox mount 1627 1583 5000
CheckboxBase mount 1296 1272 5000
CheckboxNext mount 1568 1617 5000
ChoiceGroup mount 5140 5024 5000
ComboBox mount 919 882 1000
CommandBar mount 7593 7659 1000
ContextualMenu mount 13748 13508 1000
DefaultButton mount 1098 1134 5000
DetailsRow mount 3589 3505 5000
DetailsRowFast mount 3414 3606 5000
DetailsRowNoStyles mount 3338 3368 5000
Dialog mount 1483 1503 1000
DocumentCardTitle mount 1747 1768 1000
Dropdown mount 2427 2447 5000
FocusZone mount 1749 1774 5000
IconButton mount 1739 1787 5000
Label mount 342 339 5000
Link mount 428 430 5000
LinkNext mount 450 424 5000
MenuButton mount 1381 1410 5000
Nav mount 3306 3191 1000
Panel mount 1450 1475 1000
Persona mount 803 819 1000
Pivot mount 1361 1382 1000
PivotNext mount 1388 1371 1000
PrimaryButton mount 1279 1244 5000
SearchBox mount 1303 1298 5000
Slider mount 1503 1543 5000
SliderNext mount 1944 1869 5000
Spinner mount 446 454 5000
SplitButton mount 3140 3162 5000
Stack mount 515 502 5000
StackWithIntrinsicChildren mount 1943 1977 5000
StackWithTextChildren mount 4955 5026 5000
TagPicker mount 2825 2711 5000
Text mount 409 421 5000
TextField mount 1464 1424 5000
ThemeProvider mount 2815 2892 5000
ThemeProvider virtual-rerender 505 513 5000
Toggle mount 799 823 5000
ToggleNext mount 829 805 5000
button mount 98 111 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.42 0.46 0.91:1 2000 846
🦄 Button.Fluent 0.1 0.18 0.56:1 5000 511
🔧 Checkbox.Fluent 0.6 0.33 1.82:1 1000 603
🦄 Dialog.Fluent 0.15 0.22 0.68:1 5000 727
🔧 Dropdown.Fluent 3.25 0.46 7.07:1 1000 3246
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 686
🎯 Image.Fluent 0.07 0.1 0.7:1 5000 337
🔧 Slider.Fluent 1.49 0.33 4.52:1 1000 1486
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 329
🦄 Tooltip.Fluent 0.1 17.24 0.01:1 5000 490

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
CardMinimalPerf.default 554 517 1.07:1
BoxMinimalPerf.default 325 306 1.06:1
FlexMinimalPerf.default 276 261 1.06:1
ImageMinimalPerf.default 366 345 1.06:1
ButtonSlotsPerf.default 595 566 1.05:1
SegmentMinimalPerf.default 322 308 1.05:1
TextAreaMinimalPerf.default 469 447 1.05:1
TooltipMinimalPerf.default 746 709 1.05:1
Image.Fluent 337 321 1.05:1
EmbedMinimalPerf.default 1869 1798 1.04:1
FormMinimalPerf.default 374 358 1.04:1
ListWith60ListItems.default 1066 1025 1.04:1
RadioGroupMinimalPerf.default 411 395 1.04:1
AttachmentSlotsPerf.default 1092 1059 1.03:1
ChatWithPopoverPerf.default 476 463 1.03:1
DividerMinimalPerf.default 334 324 1.03:1
DropdownManyItemsPerf.default 1428 1388 1.03:1
ListCommonPerf.default 941 914 1.03:1
PopupMinimalPerf.default 648 627 1.03:1
PortalMinimalPerf.default 118 115 1.03:1
ItemLayoutMinimalPerf.default 1330 1308 1.02:1
SliderMinimalPerf.default 1560 1529 1.02:1
IconMinimalPerf.default 653 641 1.02:1
TableMinimalPerf.default 373 365 1.02:1
TextMinimalPerf.default 340 332 1.02:1
Tooltip.Fluent 490 480 1.02:1
AttachmentMinimalPerf.default 143 141 1.01:1
CarouselMinimalPerf.default 454 448 1.01:1
CheckboxMinimalPerf.default 2711 2693 1.01:1
DialogMinimalPerf.default 718 708 1.01:1
LayoutMinimalPerf.default 388 383 1.01:1
ListNestedPerf.default 846 834 1.01:1
MenuMinimalPerf.default 848 840 1.01:1
Avatar.Fluent 846 839 1.01:1
AnimationMinimalPerf.default 354 353 1:1
ChatDuplicateMessagesPerf.default 416 417 1:1
HeaderSlotsPerf.default 759 757 1:1
HierarchicalTreeMinimalPerf.default 407 409 1:1
MenuButtonMinimalPerf.default 1482 1477 1:1
ReactionMinimalPerf.default 363 363 1:1
SplitButtonMinimalPerf.default 3586 3589 1:1
TableManyItemsPerf.default 2163 2163 1:1
CustomToolbarPrototype.default 3958 3974 1:1
Dialog.Fluent 727 730 1:1
Dropdown.Fluent 3246 3242 1:1
AccordionMinimalPerf.default 135 136 0.99:1
ButtonMinimalPerf.default 172 174 0.99:1
GridMinimalPerf.default 621 630 0.99:1
ListMinimalPerf.default 456 462 0.99:1
ProviderMergeThemesPerf.default 2159 2181 0.99:1
Checkbox.Fluent 603 607 0.99:1
Icon.Fluent 686 692 0.99:1
Text.Fluent 329 332 0.99:1
AlertMinimalPerf.default 278 285 0.98:1
ChatMinimalPerf.default 582 591 0.98:1
DropdownMinimalPerf.default 3263 3323 0.98:1
HeaderMinimalPerf.default 324 332 0.98:1
ProviderMinimalPerf.default 855 874 0.98:1
TreeMinimalPerf.default 817 833 0.98:1
AvatarMinimalPerf.default 466 480 0.97:1
RefMinimalPerf.default 196 202 0.97:1
InputMinimalPerf.default 988 1031 0.96:1
ToolbarMinimalPerf.default 893 930 0.96:1
Button.Fluent 511 533 0.96:1
LabelMinimalPerf.default 396 417 0.95:1
LoaderMinimalPerf.default 659 694 0.95:1
StatusMinimalPerf.default 639 676 0.95:1
TreeWith60ListItems.default 196 207 0.95:1
Slider.Fluent 1486 1570 0.95:1
VideoMinimalPerf.default 556 597 0.93:1

@MLoughry MLoughry requested a review from xugao June 17, 2020 18:02
@MLoughry MLoughry merged commit e36e674 into microsoft:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants