Persona: Move persona to react-internal #15386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e27c4a3:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
joschect
requested review from
ecraig12345,
dzearing and
Markionium
and removed request for
ecraig12345 and
dzearing
Asset size changes
Baseline commit: 02a94bd839b1b96f4b86bccdddd50cc8973ce3e0 (build) |
ecraig12345
reviewed
Oct 6, 2020
There was a problem hiding this comment.
Mostly looks good but can you also update the examples?
Usually what I've been doing is:
- Delete
react-examples/src/react/ComponentName - Move
react-examples/src/react-next/ComponentNameto the path in 1 - Look at the changes and see if there are any real changes which need to be preserved.
- Any files with just import path changes can be reverted
- All changes under
docsshould be ignored (thereactversion is authoritative) - In any files with real changes, be sure to update the imports to be from
reactnotreact-next.
You'll probably also need to run update-snapshots in react-internal and react-examples.
ecraig12345
approved these changes
Oct 7, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Moving function component conversion changes from #13645 back to the main package.