Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Avoid React.Children.count traversal for empty state early return #15503

Merged
merged 7 commits into from
Nov 13, 2020
Merged

[Perf] Avoid React.Children.count traversal for empty state early return #15503

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
421ecad
Refactor empty child conditionals
KevinTCoughlin Oct 13, 2020
a41cdc2
Change files
KevinTCoughlin Oct 13, 2020
ce3d9bb
Explicitly check children are undefined to handle 0 as falsey
KevinTCoughlin Oct 14, 2020
5d3e0fe
Prefer == null per review comment
KevinTCoughlin Oct 14, 2020
165e68f
Update change/@fluentui-react-internal-2020-10-13-16-47-27-keco-react…
ecraig12345 Oct 24, 2020
341f12b
Update change/@uifabric-react-cards-2020-10-13-16-47-27-keco-react-ch…
ecraig12345 Oct 24, 2020
c3def6f
Merge branch 'master' into keco/react-children-for-empty
ecraig12345 Oct 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/@fluentui-react-internal-2020-10-13-16-47-27-keco-react-children-for-empty.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
ecraig12345 marked this conversation as resolved.
Show resolved Hide resolved
"comment": "Avoid React.Children traversal for early return cases",
"packageName": "@fluentui/react-internal",
"email": "KevinTCoughlin@users.noreply.github.com",
"dependentChangeType": "patch",
"date": "2020-10-13T23:47:26.980Z"
}
8 changes: 8 additions & 0 deletions change/@uifabric-react-cards-2020-10-13-16-47-27-keco-react-children-for-empty.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "Avoid React.Children traversal for early return cases",
"packageName": "@uifabric/react-cards",
ecraig12345 marked this conversation as resolved.
Show resolved Hide resolved
"email": "KevinTCoughlin@users.noreply.github.com",
"dependentChangeType": "patch",
"date": "2020-10-13T23:47:14.293Z"
}
3 changes: 1 addition & 2 deletions packages/react-cards/src/components/Card/CardSection/CardSection.view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
/** @jsx withSlots */
import * as React from 'react';
import { withSlots, getSlots } from '@uifabric/foundation';
import { Stack } from '@fluentui/react/lib/Stack';
import { ICardSectionComponent, ICardSectionProps, ICardSectionSlots } from './CardSection.types';

export const CardSectionView: ICardSectionComponent['view'] = props => {
const { children, ...rest } = props;
if (React.Children.count(children) < 1) {
if (children === undefined) {
KevinTCoughlin marked this conversation as resolved.
Show resolved Hide resolved
return null;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/react-internal/src/components/Stack/StackItem/StackItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { StackItemStyles as styles } from './StackItem.styles';

const StackItemView: IStackItemComponent['view'] = props => {
const { children } = props;
if (React.Children.count(children) < 1) {
if (children === undefined) {
return null;
}

Expand Down
3 changes: 1 addition & 2 deletions packages/react-internal/src/components/Text/Text.view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
/** @jsx withSlots */
import * as React from 'react';
import { withSlots, getSlots } from '@uifabric/foundation';
import { getNativeProps, htmlElementProperties } from '../../Utilities';
import { ITextComponent, ITextProps, ITextSlots } from './Text.types';

export const TextView: ITextComponent['view'] = props => {
if (React.Children.count(props.children) === 0) {
if (props.children === undefined) {
return null;
}

Expand Down