Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stories for react-image, use images from CDN #15545

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

layershifter
Copy link
Member

This PR fixes stories for react-image.

@msft-github-bot
Copy link
Contributor

Thanks for submitting this change, but due to work currently in progress to prepare master for our version 8 beta release, we're asking contributors to either wait a couple weeks to submit changes (if it's not urgent) or submit to the new 7.0 branch (if it's urgent). See #15222 for more details. Thank you for your contribution and understanding!

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f6fd0ec:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 826 857 5000
BaseButtonCompat mount 911 938 5000
Breadcrumb mount 160305 160423 5000
Checkbox mount 1488 1518 5000
CheckboxBase mount 1277 1242 5000
ChoiceGroup mount 4735 4755 5000
ComboBox mount 982 957 1000
CommandBar mount 21993 21970 1000
ContextualMenu mount 6175 6090 1000
DefaultButtonCompat mount 1127 1142 5000
DetailsRow mount 3714 3725 5000
DetailsRowFast mount 3662 3679 5000
DetailsRowNoStyles mount 3493 3479 5000
Dialog mount 1523 1514 1000
DocumentCardTitle mount 1847 1856 1000
Dropdown mount 3751 3738 5000
FocusTrapZone mount 1887 1843 5000
FocusZone mount 1816 1788 5000
IconButtonCompat mount 1744 1932 5000
Label mount 329 338 5000
Layer mount 1802 1824 5000
Link mount 454 481 5000
MenuButtonCompat mount 1495 1456 5000
MessageBar mount 2110 2004 5000
Nav mount 3236 3302 1000
OverflowSet mount 1037 1056 5000
Panel mount 1479 1446 1000
Persona mount 868 890 1000
Pivot mount 1406 1393 1000
PrimaryButtonCompat mount 1296 1292 5000
Rating mount 7477 7402 5000
SearchBox mount 1329 1318 5000
Shimmer mount 2536 2565 5000
Slider mount 1943 1947 5000
SpinButton mount 5146 5157 5000
Spinner mount 428 432 5000
SplitButtonCompat mount 3174 3213 5000
Stack mount 534 516 5000
StackWithIntrinsicChildren mount 1958 1958 5000
StackWithTextChildren mount 4988 4981 5000
SwatchColorPicker mount 10354 10326 5000
TagPicker mount 2800 2748 5000
TeachingBubble mount 11685 11684 5000
Text mount 428 421 5000
TextField mount 1373 1379 5000
ThemeProvider mount 2021 2001 5000
ThemeProvider virtual-rerender 642 663 5000
Toggle mount 808 830 5000
button mount 558 536 5000
buttonNative mount 108 122 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.45 0.52 0.87:1 2000 905
🦄 Button.Fluent 0.12 0.2 0.6:1 5000 594
🔧 Checkbox.Fluent 0.66 0.34 1.94:1 1000 662
🎯 Dialog.Fluent 0.16 0.23 0.7:1 5000 814
🔧 Dropdown.Fluent 3.05 0.44 6.93:1 1000 3048
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 739
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 404
🔧 Slider.Fluent 1.66 0.46 3.61:1 1000 1663
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 390
🦄 Tooltip.Fluent 0.12 0.92 0.13:1 5000 594

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ReactionMinimalPerf.default 454 424 1.07:1
ButtonMinimalPerf.default 189 178 1.06:1
DropdownManyItemsPerf.default 797 755 1.06:1
BoxMinimalPerf.default 393 375 1.05:1
CardMinimalPerf.default 598 570 1.05:1
ListNestedPerf.default 609 582 1.05:1
SkeletonMinimalPerf.default 465 444 1.05:1
TableMinimalPerf.default 446 426 1.05:1
AccordionMinimalPerf.default 165 158 1.04:1
LabelMinimalPerf.default 449 433 1.04:1
ListWith60ListItems.default 963 926 1.04:1
TextMinimalPerf.default 382 368 1.04:1
VideoMinimalPerf.default 660 633 1.04:1
AttachmentMinimalPerf.default 163 158 1.03:1
FormMinimalPerf.default 439 428 1.03:1
InputMinimalPerf.default 1375 1339 1.03:1
MenuButtonMinimalPerf.default 1649 1606 1.03:1
PortalMinimalPerf.default 180 175 1.03:1
RadioGroupMinimalPerf.default 472 458 1.03:1
RefMinimalPerf.default 246 239 1.03:1
StatusMinimalPerf.default 764 744 1.03:1
IconMinimalPerf.default 696 676 1.03:1
Slider.Fluent 1663 1614 1.03:1
ButtonSlotsPerf.default 618 605 1.02:1
CarouselMinimalPerf.default 481 470 1.02:1
HeaderSlotsPerf.default 817 803 1.02:1
LoaderMinimalPerf.default 773 759 1.02:1
MenuMinimalPerf.default 907 892 1.02:1
PopupMinimalPerf.default 736 721 1.02:1
TreeWith60ListItems.default 221 216 1.02:1
Checkbox.Fluent 662 651 1.02:1
Icon.Fluent 739 725 1.02:1
Text.Fluent 390 381 1.02:1
Tooltip.Fluent 594 580 1.02:1
AlertMinimalPerf.default 313 310 1.01:1
AttachmentSlotsPerf.default 1160 1150 1.01:1
ChatMinimalPerf.default 646 637 1.01:1
CheckboxMinimalPerf.default 2946 2910 1.01:1
DialogMinimalPerf.default 821 815 1.01:1
SliderMinimalPerf.default 1660 1643 1.01:1
TableManyItemsPerf.default 2235 2206 1.01:1
TooltipMinimalPerf.default 854 847 1.01:1
Dialog.Fluent 814 806 1.01:1
AvatarMinimalPerf.default 496 494 1:1
ButtonUseCssPerf.default 846 842 1:1
ButtonUseCssNestingPerf.default 1117 1116 1:1
EmbedMinimalPerf.default 1951 1957 1:1
ImageMinimalPerf.default 404 403 1:1
LayoutMinimalPerf.default 436 437 1:1
ProviderMergeThemesPerf.default 2131 2138 1:1
ProviderMinimalPerf.default 1060 1063 1:1
SegmentMinimalPerf.default 377 378 1:1
CustomToolbarPrototype.default 4018 4009 1:1
ToolbarMinimalPerf.default 970 969 1:1
Button.Fluent 594 594 1:1
Dropdown.Fluent 3048 3048 1:1
AnimationMinimalPerf.default 428 431 0.99:1
ButtonOverridesMissPerf.default 1745 1758 0.99:1
ChatDuplicateMessagesPerf.default 442 445 0.99:1
DropdownMinimalPerf.default 3023 3047 0.99:1
FlexMinimalPerf.default 317 321 0.99:1
GridMinimalPerf.default 366 371 0.99:1
ListMinimalPerf.default 504 509 0.99:1
SplitButtonMinimalPerf.default 3836 3864 0.99:1
TreeMinimalPerf.default 912 921 0.99:1
Avatar.Fluent 905 912 0.99:1
ChatWithPopoverPerf.default 472 483 0.98:1
DividerMinimalPerf.default 381 390 0.98:1
ItemLayoutMinimalPerf.default 1292 1313 0.98:1
Image.Fluent 404 413 0.98:1
ListCommonPerf.default 648 668 0.97:1
TextAreaMinimalPerf.default 498 520 0.96:1
HeaderMinimalPerf.default 385 411 0.94:1

@size-auditor
Copy link

size-auditor bot commented Oct 16, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3bb035feb873962ac9aded0278a58430f858e49e (build)

@layershifter layershifter merged commit ad0cdab into master Oct 19, 2020
@ecraig12345 ecraig12345 deleted the fix/image-stories branch October 28, 2020 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants