Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stories for react-image, use images from CDN #15545

Merged
merged 1 commit into from
Oct 19, 2020
Merged

fix stories for react-image, use images from CDN #15545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/@fluentui-react-image-2020-10-16-10-32-13-fix-image-stories.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "none",
"comment": "fix stories for `react-image`, use images from CDN",
"packageName": "@fluentui/react-image",
"email": "olfedias@microsoft.com",
"dependentChangeType": "none",
"date": "2020-10-16T08:32:13.798Z"
}
0 ...amples/src/react-image/Image.stories.scss → .../src/react-image/Image/Image.stories.scss
View file
Open in desktop
File renamed without changes.
88 changes: 77 additions & 11 deletions ...xamples/src/react-image/Image.stories.tsx → ...s/src/react-image/Image/Image.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,31 +13,97 @@ const Stack = (props: React.PropsWithChildren<{ horizontal?: boolean }>) => {

export const ImageAppearanceShape = () => (
<Stack horizontal>
<Image alt="Ade's avatar" src="images/avatar/ade.jpg" height={200} width={200} />
<Image alt="Chris's avatar" rounded src="images/avatar/chris.jpg" height={200} width={200} />
<Image alt="Laura's avatar" circular src="images/avatar/laura.jpg" height={200} width={200} />
<Image
alt="Ade's avatar"
src="https://fabricweb.azureedge.net/fabric-website/assets/images/avatar/large/ade.jpg"
height={200}
width={200}
/>
<Image
alt="Chris's avatar"
rounded
src="https://fabricweb.azureedge.net/fabric-website/assets/images/avatar/large/chris.jpg"
height={200}
width={200}
/>
<Image
alt="Laura's avatar"
circular
src="https://fabricweb.azureedge.net/fabric-website/assets/images/avatar/large/laura.jpg"
height={200}
width={200}
/>
</Stack>
);

export const ImageVariationsBorder = () => (
<Stack horizontal>
<Stack horizontal>
<Image alt="Ade's avatar" src="images/avatar/ade.jpg" height={200} width={200} />
<Image alt="Chris's avatar" rounded src="images/avatar/chris.jpg" height={200} width={200} />
<Image alt="Laura's avatar" circular src="images/avatar/laura.jpg" height={200} width={200} />
<Image
alt="Ade's avatar"
src="https://fabricweb.azureedge.net/fabric-website/assets/images/avatar/large/ade.jpg"
height={200}
width={200}
/>
<Image
alt="Chris's avatar"
rounded
src="https://fabricweb.azureedge.net/fabric-website/assets/images/avatar/large/chris.jpg"
height={200}
width={200}
/>
<Image
alt="Laura's avatar"
circular
src="https://fabricweb.azureedge.net/fabric-website/assets/images/avatar/large/laura.jpg"
height={200}
width={200}
/>
</Stack>
<Stack horizontal>
<Image alt="Ade's avatar" bordered src="images/avatar/ade.jpg" height={200} width={200} />
<Image alt="Chris's avatar" bordered rounded src="images/avatar/chris.jpg" height={200} width={200} />
<Image alt="Laura's avatar" bordered circular src="images/avatar/laura.jpg" height={200} width={200} />
<Image
alt="Ade's avatar"
bordered
src="https://fabricweb.azureedge.net/fabric-website/assets/images/avatar/large/ade.jpg"
height={200}
width={200}
/>
<Image
alt="Chris's avatar"
bordered
rounded
src="https://fabricweb.azureedge.net/fabric-website/assets/images/avatar/large/chris.jpg"
height={200}
width={200}
/>
<Image
alt="Laura's avatar"
bordered
circular
src="https://fabricweb.azureedge.net/fabric-website/assets/images/avatar/large/laura.jpg"
height={200}
width={200}
/>
</Stack>
</Stack>
);

export const ImageVariationsFallback = () => (
<Stack horizontal>
<Image alt="Ade's avatar" bordered src="images/avatar/ade.jpg" height={200} width={200} />
<Image alt="Non-existing avatar" bordered src="images/avatar/non-existing-png.jpg" height={200} width={200} />
<Image
alt="Ade's avatar"
bordered
src="https://fabricweb.azureedge.net/fabric-website/assets/images/avatar/large/ade.jpg"
height={200}
width={200}
/>
<Image
alt="Non-existing avatar"
bordered
src="https://fabricweb.azureedge.net/fabric-website/assets/images/avatar/large/non-existing-png.jpg"
height={200}
width={200}
/>
</Stack>
);

Expand Down
Binary file removed packages/react-image/static/images/avatar/ade.jpg
View file
Open in desktop
Binary file not shown.
Binary file removed packages/react-image/static/images/avatar/chris.jpg
View file
Open in desktop
Binary file not shown.
Binary file removed packages/react-image/static/images/avatar/laura.jpg
View file
Open in desktop
Binary file not shown.