CompoundButton: Re-introducing CompoundButton using latest version of makeStyles #17534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7065a11:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a8767b680206226010a1a3e6cf9b426ed66612b1 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
dzearing
reviewed
Mar 23, 2021
| } = state; | ||
| state.className = undefined; | ||
| if (state.children) { | ||
| state.children.className = undefined; |
There was a problem hiding this comment.
What is state.children? is this guaranteed to be a props object, or can it be jsx or a string?
There was a problem hiding this comment.
It is treated as a slot so it can be any of those.
There was a problem hiding this comment.
In here it is guaranteed to be an object after going through useCompoundButton though.
dzearing
reviewed
Mar 23, 2021
| selectors.size === 'large' && styles.secondaryContentLarge, | ||
| selectors.primary && styles.secondaryContentPrimary, | ||
| selectors.disabled && styles.secondaryContentDisabled, | ||
| state.secondaryContent.className, |
There was a problem hiding this comment.
I'm don't know the internals of what ax does, but I see some inconsistencies in the ordering of the input. In the root, I see that state.className (the user's input) comes as the first param. Same with icon. But with secondaryContent, the user's input comes last.
Is that intended? Does it matter, is there an ordering here to ensure user overrides are more important?
There was a problem hiding this comment.
It is intended, it should normally come in the end but it's coming here first because that's actually the result of the useButtonStyles call before that. If you take a closer look I actually get the classnames that are applied at the end at the beginning of the function.
dzearing
approved these changes
Mar 24, 2021
|
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
2 tasks
|
🎉 Handy links: |
|
🎉 Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
… makeStyles (microsoft#17534) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes This PR re-introduces the `CompoundButton` component with the latest `makeStyles` changes under `@fluentui/react-button` after having been removed for the initial release of `@fluentui/react-components`. PRs reintroducing `MenuButton`, `SplitButton` and `ToggleButton` will follow. PRs reintroducing the `block`, `subtle` and `transparent` props will follow.
This was referenced Apr 1, 2021
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
… makeStyles (microsoft#17534) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes This PR re-introduces the `CompoundButton` component with the latest `makeStyles` changes under `@fluentui/react-button` after having been removed for the initial release of `@fluentui/react-components`. PRs reintroducing `MenuButton`, `SplitButton` and `ToggleButton` will follow. PRs reintroducing the `block`, `subtle` and `transparent` props will follow.
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR re-introduces the
CompoundButtoncomponent with the latestmakeStyleschanges under@fluentui/react-buttonafter having been removed for the initial release of@fluentui/react-components.PRs reintroducing
MenuButton,SplitButtonandToggleButtonwill follow.PRs reintroducing the
block,subtleandtransparentprops will follow.