ToggleButton: Re-introducing ToggleButton using the latest version of makeStyles #17566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 02c99b6:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0913259cdea5a3d692720299516aec613b7c072a (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
|
Let me know when this is ready and I'll approve for the package.json changes (not really the right person to look at the rest) |
dzearing
reviewed
Mar 25, 2021
| @@ -122,17 +129,19 @@ export const makeButtonTokens = (theme: Theme): ButtonVariantTokens => ({ | |||
| background: theme.alias.color.brand.brandBackgroundHover, | |||
| borderColor: 'transparent', | |||
| color: theme.alias.color.neutral.neutralForegroundInvertedAccessible, | |||
There was a problem hiding this comment.
This in particular seems weird - background is using brand and foreground is using something which doesn't relate to brand. Shouldn't foregrounds and backgrounds use the same color group?
There was a problem hiding this comment.
@dzearing and I spoke offline about this and it does seem like we are missing some logic in here to add the brand foreground colors. There should also probably be a way to catch that we're not using foreground and background colors from the same alias group on any one variant that we also need to follow up with.
dzearing
approved these changes
Mar 25, 2021
ecraig12345
approved these changes
Mar 26, 2021
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
2 tasks
2 tasks
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
… makeStyles (microsoft#17566) * ToggleButton: Re-introducing ToggleButton using the latest version of makeStyles. * Change files * Adding checked VR test. * Renaming draftState to state. * Updating API. * Adding primary checked vr tests.
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR follows #17534.
This PR re-introduces the
ToggleButtoncomponent with the latestmakeStyleschanges under@fluentui/react-buttonafter having been removed for the initial release of@fluentui/react-components.PRs re-introducing
MenuButtonandSplitButton.PRs reintroducing the
block,circular,subtleandtransparentprops will follow.