-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement table cell layout components #24773
Conversation
Implements table cell layout components from microsoft#24762 to break up the aforementioned PR
📊 Bundle size reportUnchanged fixtures
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5be62aa:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a40ef34fa6d1122bdfdb708f79b90de9edb2827d (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 1273 | 1256 | 5000 | |
Button | mount | 923 | 944 | 5000 | |
FluentProvider | mount | 1508 | 1479 | 5000 | |
FluentProviderWithTheme | mount | 585 | 584 | 10 | |
FluentProviderWithTheme | virtual-rerender | 535 | 556 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 577 | 569 | 10 | |
MakeStyles | mount | 1946 | 1948 | 50000 | |
SpinButton | mount | 2378 | 2311 | 5000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
import type { ComponentProps, ComponentState, Slot } from '@fluentui/react-utilities'; | ||
|
||
export type TableCellLayoutSlots = { | ||
root: Slot<'div'>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
root: Slot<'div'>; | |
root: NonNullable<Slot<'div'>>; |
export { | ||
TableCellLayout, | ||
useTableCellLayoutStyles_unstable, | ||
useTableCellLayout_unstable, | ||
renderTableCellLayout_unstable, | ||
tableCellLayoutClassNames, | ||
} from './TableCellLayout'; | ||
export type { TableCellLayoutProps, TableCellLayoutSlots, TableCellLayoutState } from './TableCellLayout'; | ||
|
||
export { | ||
TableCellPrimaryLayout, | ||
tableCellPrimaryLayoutClassNames, | ||
useTableCellPrimaryLayoutStyles_unstable, | ||
useTableCellPrimaryLayout_unstable, | ||
renderTableCellPrimaryLayout_unstable, | ||
} from './TableCellPrimaryLayout'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I think that we can get this in a single component, https://fluentsite.z22.web.core.windows.net/0.64.0/components/item-layout/definition
And may be it should not be connected to Table at all
* master: (28 commits) Fix value font-weight inside heatmap chart (microsoft#24726) Fix legend overflow-indication-text role (microsoft#24756) Support custom locale in date axis (microsoft#24753) Cleanup env variables (microsoft#24739) ci(github): add GH Action to add issue labels based on new GH issue template (microsoft#24788) Update disallowedChangeTypes for newly created packages, to allow only 'prerelease' change types by default (microsoft#24763) feat(react-components): Adding missing AvatarGroup exports (microsoft#24770) remove unnecessary nohoist (microsoft#24760) feat(react-dialog): supports 1st rule of ARIA (microsoft#24525) BREAKING: TableCell layouts are handled by layout components (microsoft#24762) feat: Implement table cell layout components (microsoft#24773) applying package updates fix: remove readonly from DetailsList (microsoft#24615) chore: Cleaning up tokens in Button components so they better adhere to the design spec (microsoft#24732) fix: react-combobox listbox popup width matches trigger width (microsoft#24733) fix: react-combobox Option focus outline only shows with keyboard nav (microsoft#24700) feat: Publish react-field package, and export from react-components/unstable (microsoft#24235) fix: Replacing bottom border styles with text decoration underline in Link (microsoft#24734) docs(react-theme): Update readme (microsoft#24755) Add tests for hover states (microsoft#24390) ...
Implements table cell layout components from #24762 to break up the aforementioned PR