Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): add GH Action to add issue labels based on new GH issue template #24788

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Sep 14, 2022

Current Behavior

  • issue is created for particular project but manual work needs to be done to properly assign project label

New Behavior

  • based on picked project, we will automatically add proper label.

image

↓↓↓

image

Note: Adding to unified board will be done in separate PR after internal team discussion

Related Issue(s)

Follows #22337

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd61ac5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 14, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e0a0ab1481d0fb64f2a9804376ad17e4f4f8ea01 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1310 1329 5000
Button mount 953 955 5000
FluentProvider mount 1570 1591 5000
FluentProviderWithTheme mount 635 621 10
FluentProviderWithTheme virtual-rerender 592 578 10
FluentProviderWithTheme virtual-rerender-with-unmount 626 623 10
MakeStyles mount 1896 1914 50000
SpinButton mount 2495 2543 5000

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 126 103 1.22:1
ListCommonPerf.default 517 441 1.17:1
ReactionMinimalPerf.default 312 269 1.16:1
RefMinimalPerf.default 180 157 1.15:1
TableMinimalPerf.default 333 289 1.15:1
BoxMinimalPerf.default 269 237 1.14:1
TextMinimalPerf.default 268 240 1.12:1
ToolbarMinimalPerf.default 759 699 1.09:1
ButtonMinimalPerf.default 122 113 1.08:1
ButtonSlotsPerf.default 430 398 1.08:1
InputMinimalPerf.default 895 825 1.08:1
LabelMinimalPerf.default 309 285 1.08:1
TreeWith60ListItems.default 128 118 1.08:1
AccordionMinimalPerf.default 105 98 1.07:1
AvatarMinimalPerf.default 140 132 1.06:1
CarouselMinimalPerf.default 361 340 1.06:1
HeaderSlotsPerf.default 580 553 1.05:1
IconMinimalPerf.default 484 460 1.05:1
AnimationMinimalPerf.default 397 382 1.04:1
ChatWithPopoverPerf.default 278 268 1.04:1
DatepickerMinimalPerf.default 4499 4312 1.04:1
GridMinimalPerf.default 242 232 1.04:1
ListMinimalPerf.default 379 366 1.04:1
TooltipMinimalPerf.default 1773 1710 1.04:1
AlertMinimalPerf.default 195 190 1.03:1
ListWith60ListItems.default 453 441 1.03:1
MenuButtonMinimalPerf.default 1297 1257 1.03:1
PopupMinimalPerf.default 477 465 1.03:1
ProviderMinimalPerf.default 303 294 1.03:1
CardMinimalPerf.default 385 377 1.02:1
HeaderMinimalPerf.default 255 251 1.02:1
ItemLayoutMinimalPerf.default 867 849 1.02:1
ListNestedPerf.default 395 389 1.02:1
SplitButtonMinimalPerf.default 3286 3213 1.02:1
DividerMinimalPerf.default 255 253 1.01:1
DropdownManyItemsPerf.default 492 487 1.01:1
LoaderMinimalPerf.default 483 479 1.01:1
RadioGroupMinimalPerf.default 318 316 1.01:1
TreeMinimalPerf.default 587 582 1.01:1
VideoMinimalPerf.default 569 566 1.01:1
CheckboxMinimalPerf.default 1586 1581 1:1
DialogMinimalPerf.default 568 569 1:1
EmbedMinimalPerf.default 2690 2694 1:1
LayoutMinimalPerf.default 255 255 1:1
ProviderMergeThemesPerf.default 939 943 1:1
TableManyItemsPerf.default 1377 1376 1:1
ButtonOverridesMissPerf.default 967 974 0.99:1
DropdownMinimalPerf.default 2000 2013 0.99:1
TextAreaMinimalPerf.default 341 343 0.99:1
CustomToolbarPrototype.default 1996 2033 0.98:1
SegmentMinimalPerf.default 263 272 0.97:1
ChatDuplicateMessagesPerf.default 215 223 0.96:1
FlexMinimalPerf.default 202 211 0.96:1
FormMinimalPerf.default 264 275 0.96:1
ChatMinimalPerf.default 558 588 0.95:1
MenuMinimalPerf.default 613 643 0.95:1
RosterPerf.default 1658 1737 0.95:1
ImageMinimalPerf.default 270 288 0.94:1
StatusMinimalPerf.default 496 529 0.94:1
AttachmentSlotsPerf.default 812 879 0.92:1
PortalMinimalPerf.default 117 127 0.92:1
SliderMinimalPerf.default 1221 1328 0.92:1
SkeletonMinimalPerf.default 249 279 0.89:1

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
2.936 kB
1.212 kB
react-accordion
Accordion (including children components)
78.914 kB
24.06 kB
react-alert
Alert
83.511 kB
20.921 kB
react-avatar
Avatar
48.381 kB
13.696 kB
react-avatar
AvatarGroup
14.95 kB
5.989 kB
react-avatar
AvatarGroupItem
68.349 kB
19.039 kB
react-badge
Badge
22.6 kB
7.205 kB
react-badge
CounterBadge
23.503 kB
7.497 kB
react-badge
PresenceBadge
24.05 kB
7.067 kB
react-button
Button
36.119 kB
9.647 kB
react-button
CompoundButton
43.144 kB
10.86 kB
react-button
MenuButton
38.737 kB
10.521 kB
react-button
SplitButton
46.136 kB
11.9 kB
react-button
ToggleButton
51.888 kB
11.127 kB
react-card
Card - All
67.002 kB
19.261 kB
react-card
Card
62.684 kB
18.177 kB
react-card
CardFooter
8.561 kB
3.601 kB
react-card
CardHeader
9.604 kB
3.94 kB
react-card
CardPreview
8.662 kB
3.656 kB
react-combobox
Combobox (including child components)
74.636 kB
24.186 kB
react-combobox
Dropdown (including child components)
74.236 kB
24.086 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
187.939 kB
52.05 kB
react-components
react-components: FluentProvider & webLightTheme
33.359 kB
11.004 kB
react-dialog
Dialog (including children components)
81.048 kB
24.208 kB
react-divider
Divider
16.459 kB
5.902 kB
react-image
Image
10.78 kB
4.264 kB
react-input
Input
23.598 kB
7.661 kB
react-label
Label
9.338 kB
3.86 kB
react-link
Link
11.784 kB
4.867 kB
react-menu
Menu (including children components)
115.735 kB
35.419 kB
react-menu
Menu (including selectable components)
118.934 kB
35.916 kB
react-overflow
hooks only
10.685 kB
4.104 kB
react-popover
Popover
102.938 kB
31.542 kB
react-portal
Portal
10.576 kB
3.875 kB
react-portal-compat
PortalCompatProvider
5.851 kB
1.964 kB
react-positioning
usePositioning
19.7 kB
7.404 kB
react-provider
FluentProvider
15.755 kB
5.883 kB
react-radio
Radio
35.56 kB
11.929 kB
react-radio
RadioGroup
14.248 kB
5.7 kB
react-select
Select
20.846 kB
7.346 kB
react-slider
Slider
31.526 kB
10.046 kB
react-spinbutton
SpinButton
43.943 kB
12.382 kB
react-spinner
Spinner
19.977 kB
6.438 kB
react-switch
Switch
32.097 kB
10.27 kB
react-text
Text - Default
11.782 kB
4.605 kB
react-text
Text - Wrappers
15.092 kB
5.044 kB
react-textarea
Textarea
23.988 kB
8.011 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.548 kB
6.434 kB
react-theme
Teams: Light theme
17.452 kB
5.054 kB
react-tooltip
Tooltip
41.502 kB
14.623 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against e0a0ab1481d0fb64f2a9804376ad17e4f4f8ea01

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1039 1066 5000
Breadcrumb mount 3032 3029 1000
Checkbox mount 2852 2897 5000
CheckboxBase mount 2537 2574 5000
ChoiceGroup mount 5235 5317 5000
ComboBox mount 1055 1070 1000
CommandBar mount 11227 11213 1000
ContextualMenu mount 12745 13037 1000
DefaultButton mount 1260 1283 5000
DetailsRow mount 4078 4174 5000
DetailsRowFast mount 4183 4294 5000
DetailsRowNoStyles mount 4065 4010 5000
Dialog mount 3375 3385 1000
DocumentCardTitle mount 187 208 1000
Dropdown mount 3805 3784 5000
FocusTrapZone mount 1970 2003 5000
FocusZone mount 1868 1917 5000
IconButton mount 2015 2013 5000
Label mount 379 382 5000
Layer mount 4862 4893 5000
Link mount 540 519 5000
MenuButton mount 1667 1663 5000
MessageBar mount 2365 2320 5000
Nav mount 3686 3782 1000
OverflowSet mount 1229 1194 5000
Panel mount 2666 2713 1000
Persona mount 1102 1131 1000
Pivot mount 1604 1597 1000
PrimaryButton mount 1479 1471 5000
Rating mount 8809 8883 5000
SearchBox mount 1489 1495 5000
Shimmer mount 3251 3211 5000
Slider mount 2197 2123 5000
SpinButton mount 5519 5462 5000
Spinner mount 485 468 5000
SplitButton mount 3512 3526 5000
Stack mount 555 598 5000
StackWithIntrinsicChildren mount 2685 2713 5000
StackWithTextChildren mount 6027 6073 5000
SwatchColorPicker mount 12884 12888 5000
TagPicker mount 2953 2992 5000
TeachingBubble mount 104147 104251 5000
Text mount 479 473 5000
TextField mount 1554 1557 5000
ThemeProvider mount 1391 1394 5000
ThemeProvider virtual-rerender 832 815 5000
ThemeProvider virtual-rerender-with-unmount 2210 2199 5000
Toggle mount 920 898 5000
buttonNative mount 144 149 5000

@Hotell Hotell marked this pull request as ready for review September 14, 2022 09:18
@Hotell Hotell requested a review from a team as a code owner September 14, 2022 09:18
@Hotell Hotell removed their assignment Sep 14, 2022
@Hotell Hotell merged commit 335c79e into microsoft:master Sep 14, 2022
@Hotell Hotell deleted the hotell/ci/gh-triage-bot branch September 14, 2022 12:43
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 14, 2022
* master: (28 commits)
  Fix value font-weight inside heatmap chart (microsoft#24726)
  Fix legend overflow-indication-text role (microsoft#24756)
  Support custom locale in date axis  (microsoft#24753)
  Cleanup env variables (microsoft#24739)
  ci(github): add GH Action to add issue labels based on new GH issue template (microsoft#24788)
  Update disallowedChangeTypes for newly created packages, to allow only 'prerelease' change types by default (microsoft#24763)
  feat(react-components): Adding missing AvatarGroup exports (microsoft#24770)
  remove unnecessary nohoist (microsoft#24760)
  feat(react-dialog): supports 1st rule of ARIA (microsoft#24525)
  BREAKING: TableCell layouts are handled by layout components (microsoft#24762)
  feat: Implement table cell layout components (microsoft#24773)
  applying package updates
  fix: remove readonly from DetailsList (microsoft#24615)
  chore: Cleaning up tokens in Button components so they better adhere to the design spec (microsoft#24732)
  fix: react-combobox listbox popup width matches trigger width (microsoft#24733)
  fix: react-combobox Option focus outline only shows with keyboard nav (microsoft#24700)
  feat: Publish react-field package, and export from react-components/unstable (microsoft#24235)
  fix: Replacing bottom border styles with text decoration underline in Link (microsoft#24734)
  docs(react-theme): Update readme (microsoft#24755)
  Add tests for hover states (microsoft#24390)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants