feat(scripts): implement triage-bot module #24911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a16631d:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b415287e740508fbd3c64597bacc5efc6592c910 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1175 | 1167 | 5000 | |
| Button | mount | 935 | 924 | 5000 | |
| FluentProvider | mount | 1496 | 1539 | 5000 | |
| FluentProviderWithTheme | mount | 621 | 559 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 523 | 511 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 559 | 620 | 10 | |
| MakeStyles | mount | 1717 | 1668 | 50000 | |
| SpinButton | mount | 2245 | 2284 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 145 | 128 | 1.13:1 |
| TextAreaMinimalPerf.default | 392 | 368 | 1.07:1 |
| GridMinimalPerf.default | 280 | 266 | 1.05:1 |
| LabelMinimalPerf.default | 314 | 303 | 1.04:1 |
| ListNestedPerf.default | 458 | 442 | 1.04:1 |
| PortalMinimalPerf.default | 140 | 134 | 1.04:1 |
| TooltipMinimalPerf.default | 1957 | 1884 | 1.04:1 |
| TreeWith60ListItems.default | 131 | 126 | 1.04:1 |
| CardMinimalPerf.default | 438 | 427 | 1.03:1 |
| ReactionMinimalPerf.default | 306 | 297 | 1.03:1 |
| SegmentMinimalPerf.default | 282 | 275 | 1.03:1 |
| TableMinimalPerf.default | 333 | 324 | 1.03:1 |
| TextMinimalPerf.default | 286 | 279 | 1.03:1 |
| AttachmentSlotsPerf.default | 921 | 907 | 1.02:1 |
| DividerMinimalPerf.default | 292 | 286 | 1.02:1 |
| FormMinimalPerf.default | 309 | 303 | 1.02:1 |
| HeaderMinimalPerf.default | 289 | 284 | 1.02:1 |
| ListCommonPerf.default | 514 | 502 | 1.02:1 |
| ListMinimalPerf.default | 420 | 413 | 1.02:1 |
| StatusMinimalPerf.default | 560 | 549 | 1.02:1 |
| AttachmentMinimalPerf.default | 122 | 121 | 1.01:1 |
| BoxMinimalPerf.default | 274 | 270 | 1.01:1 |
| ChatWithPopoverPerf.default | 299 | 297 | 1.01:1 |
| DatepickerMinimalPerf.default | 4791 | 4753 | 1.01:1 |
| DropdownMinimalPerf.default | 2248 | 2227 | 1.01:1 |
| EmbedMinimalPerf.default | 3046 | 3002 | 1.01:1 |
| FlexMinimalPerf.default | 236 | 234 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 966 | 956 | 1.01:1 |
| ListWith60ListItems.default | 521 | 518 | 1.01:1 |
| MenuMinimalPerf.default | 697 | 691 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1400 | 1382 | 1.01:1 |
| RosterPerf.default | 1761 | 1748 | 1.01:1 |
| PopupMinimalPerf.default | 523 | 520 | 1.01:1 |
| RadioGroupMinimalPerf.default | 367 | 362 | 1.01:1 |
| RefMinimalPerf.default | 180 | 179 | 1.01:1 |
| SliderMinimalPerf.default | 1318 | 1307 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3661 | 3617 | 1.01:1 |
| VideoMinimalPerf.default | 603 | 595 | 1.01:1 |
| AnimationMinimalPerf.default | 439 | 441 | 1:1 |
| InputMinimalPerf.default | 935 | 935 | 1:1 |
| ProviderMergeThemesPerf.default | 1056 | 1053 | 1:1 |
| ProviderMinimalPerf.default | 336 | 336 | 1:1 |
| TableManyItemsPerf.default | 1537 | 1536 | 1:1 |
| ToolbarMinimalPerf.default | 760 | 757 | 1:1 |
| TreeMinimalPerf.default | 661 | 662 | 1:1 |
| AvatarMinimalPerf.default | 152 | 153 | 0.99:1 |
| ButtonOverridesMissPerf.default | 1066 | 1082 | 0.99:1 |
| ChatMinimalPerf.default | 592 | 597 | 0.99:1 |
| CheckboxMinimalPerf.default | 1705 | 1718 | 0.99:1 |
| DialogMinimalPerf.default | 639 | 643 | 0.99:1 |
| DropdownManyItemsPerf.default | 549 | 556 | 0.99:1 |
| ImageMinimalPerf.default | 313 | 316 | 0.99:1 |
| LayoutMinimalPerf.default | 290 | 292 | 0.99:1 |
| LoaderMinimalPerf.default | 543 | 549 | 0.99:1 |
| IconMinimalPerf.default | 551 | 557 | 0.99:1 |
| CustomToolbarPrototype.default | 2218 | 2240 | 0.99:1 |
| ButtonSlotsPerf.default | 444 | 452 | 0.98:1 |
| SkeletonMinimalPerf.default | 274 | 279 | 0.98:1 |
| AccordionMinimalPerf.default | 116 | 119 | 0.97:1 |
| CarouselMinimalPerf.default | 374 | 387 | 0.97:1 |
| HeaderSlotsPerf.default | 617 | 640 | 0.96:1 |
| ChatDuplicateMessagesPerf.default | 212 | 223 | 0.95:1 |
| AlertMinimalPerf.default | 208 | 224 | 0.93:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1217 | 1178 | 5000 | |
| Breadcrumb | mount | 2797 | 2814 | 1000 | |
| Checkbox | mount | 2633 | 2600 | 5000 | |
| CheckboxBase | mount | 2326 | 2366 | 5000 | |
| ChoiceGroup | mount | 4226 | 4247 | 5000 | |
| ComboBox | mount | 1159 | 1166 | 1000 | |
| CommandBar | mount | 9189 | 9252 | 1000 | |
| ContextualMenu | mount | 10088 | 10121 | 1000 | |
| DefaultButton | mount | 1355 | 1353 | 5000 | |
| DetailsRow | mount | 3379 | 3364 | 5000 | |
| DetailsRowFast | mount | 3390 | 3369 | 5000 | |
| DetailsRowNoStyles | mount | 3232 | 3208 | 5000 | |
| Dialog | mount | 2951 | 2961 | 1000 | |
| DocumentCardTitle | mount | 595 | 587 | 1000 | |
| Dropdown | mount | 3159 | 3171 | 5000 | |
| FocusTrapZone | mount | 1982 | 1957 | 5000 | |
| FocusZone | mount | 1961 | 1911 | 5000 | |
| GroupedList | mount | 47442 | 54086 | 2 | |
| GroupedList | virtual-rerender | 23380 | 23066 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 83095 | 81510 | 2 | |
| GroupedListV2 | mount | 564 | 567 | 2 | |
| GroupedListV2 | virtual-rerender | 540 | 531 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 558 | 549 | 2 | |
| IconButton | mount | 1798 | 1787 | 5000 | |
| Label | mount | 756 | 749 | 5000 | |
| Layer | mount | 4166 | 4171 | 5000 | |
| Link | mount | 847 | 857 | 5000 | |
| MenuButton | mount | 1617 | 1611 | 5000 | |
| MessageBar | mount | 2371 | 2393 | 5000 | |
| Nav | mount | 3079 | 3092 | 1000 | |
| OverflowSet | mount | 1406 | 1409 | 5000 | |
| Panel | mount | 2482 | 2519 | 1000 | |
| Persona | mount | 1248 | 1265 | 1000 | |
| Pivot | mount | 1522 | 1514 | 1000 | |
| PrimaryButton | mount | 1486 | 1491 | 5000 | |
| Rating | mount | 6975 | 6983 | 5000 | |
| SearchBox | mount | 1481 | 1491 | 5000 | |
| Shimmer | mount | 2924 | 2927 | 5000 | |
| Slider | mount | 2102 | 2121 | 5000 | |
| SpinButton | mount | 4256 | 4200 | 5000 | |
| Spinner | mount | 830 | 817 | 5000 | |
| SplitButton | mount | 2866 | 2795 | 5000 | |
| Stack | mount | 909 | 891 | 5000 | |
| StackWithIntrinsicChildren | mount | 2238 | 2250 | 5000 | |
| StackWithTextChildren | mount | 4957 | 4928 | 5000 | |
| SwatchColorPicker | mount | 9490 | 9593 | 5000 | |
| TagPicker | mount | 2337 | 2339 | 5000 | |
| TeachingBubble | mount | 73968 | 73601 | 5000 | |
| Text | mount | 817 | 819 | 5000 | |
| TextField | mount | 1563 | 1555 | 5000 | |
| ThemeProvider | mount | 1440 | 1439 | 5000 | |
| ThemeProvider | virtual-rerender | 1143 | 1145 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2012 | 1983 | 5000 | |
| Toggle | mount | 1146 | 1135 | 5000 | |
| buttonNative | mount | 538 | 542 | 5000 |
Hotell
commented
Sep 23, 2022
Hotell
force-pushed
the
hotell/ci/triage-bot-custom
branch
from
d1e64bd
to
faf9ca5
Compare
tudorpopams
approved these changes
Sep 23, 2022
Hotell
force-pushed
the
hotell/ci/triage-bot-custom
branch
from
faf9ca5
to
95ef824
Compare
Hotell
commented
Sep 23, 2022
scripts/package.json
Outdated
| @@ -14,7 +14,6 @@ | |||
| "@mdx-js/loader": "^1.5.5", | |||
| "@microsoft/load-themed-styles": "^1.10.26", | |||
| "@microsoft/loader-load-themed-styles": "^1.7.205", | |||
| "@octokit/rest": "^16.28.2", | |||
There was a problem hiding this comment.
single version policy move and pinned to actual version installed
Hotell
force-pushed
the
hotell/ci/triage-bot-custom
branch
from
95ef824
to
3466291
Compare
Hotell
force-pushed
the
hotell/ci/triage-bot-custom
branch
from
3466291
to
a16631d
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 28, 2022
* master: (21 commits) chore: Migrate react-avatar to use new build (microsoft#24969) applying package updates chore(react-input, react-textarea): Deprecating filled with shadow appearance variants (microsoft#24900) fix: v8 Dropdown no longer sets incorrect and unnecessary aria-activedescendant (microsoft#24593) feat: v0 Tooltip migration from v9 (microsoft#24908) chore: bump devDeps to fix critical security vulnerability (microsoft#24891) Fixing Tree chart issues (microsoft#24752) init: new package react-avatar-context (microsoft#24968) ci(.github): add issues write permisions to triage-bot worflow (microsoft#24963) applying package updates fix(Toolbar): close previous submenu when opening another submenu (microsoft#24836) fix: update non-focus-trap Popover role to be group (microsoft#24897) feat: Avatar's aria label includes 'active' or 'inactive' when using the active prop (microsoft#24901) feat(scripts): implement triage-bot module (microsoft#24911) chore: bump @octokit/rest to v18 (microsoft#24919) stress test: add "build-fixture" command (microsoft#24928) BREAKING-CHANGE: new ChatMessageContent for style caching (microsoft#24691) bugfix: fix changefile to properly update version of react-components with a patch (microsoft#24949) feat(scripts): enable strict checking for additional sub-folders(packages) (microsoft#24526) chore: exports DialogContent as unstable (microsoft#24943) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* feat(scripts): implement triage-bot module * ci(github): setup triage bot * chore: move octokit to single version policy, add @actions packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
we use existing github action which doesn't work and have very limited use case coverage
New Behavior
bump to @octokit/rest v18 ( introduces lot of changes in type space - we can remove that part from this PR )chore: bump @octokit/rest to v18 #24919Learn more 💡
Related Issue(s)
Follows #24788
Implements #24817 (1. project label assignment)