fix(Toolbar): close previous submenu when opening another submenu #24836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 84e0df1:
|
Asset size changes
Baseline commit: 0e50bf23a6604793d0eaa2626c87dbec9cd600d8 (build) |
📊 Bundle size report🤖 This report was generated against 0e50bf23a6604793d0eaa2626c87dbec9cd600d8 |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
github-actions
bot
modified the milestones:
July Project Cycle Q3 2022,
September Project Cycle Q1 2022
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 124 | 102 | 1.22:1 |
| ChatWithPopoverPerf.default | 310 | 262 | 1.18:1 |
| HeaderSlotsPerf.default | 621 | 537 | 1.16:1 |
| DropdownManyItemsPerf.default | 552 | 484 | 1.14:1 |
| FlexMinimalPerf.default | 230 | 206 | 1.12:1 |
| TreeWith60ListItems.default | 127 | 113 | 1.12:1 |
| AvatarMinimalPerf.default | 160 | 146 | 1.1:1 |
| DropdownMinimalPerf.default | 2177 | 1978 | 1.1:1 |
| TextAreaMinimalPerf.default | 370 | 337 | 1.1:1 |
| SkeletonMinimalPerf.default | 257 | 238 | 1.08:1 |
| ButtonMinimalPerf.default | 123 | 116 | 1.06:1 |
| EmbedMinimalPerf.default | 2798 | 2645 | 1.06:1 |
| LayoutMinimalPerf.default | 262 | 250 | 1.05:1 |
| MenuMinimalPerf.default | 624 | 595 | 1.05:1 |
| RosterPerf.default | 1609 | 1537 | 1.05:1 |
| ReactionMinimalPerf.default | 276 | 263 | 1.05:1 |
| SliderMinimalPerf.default | 1186 | 1133 | 1.05:1 |
| DividerMinimalPerf.default | 256 | 245 | 1.04:1 |
| PortalMinimalPerf.default | 124 | 119 | 1.04:1 |
| TableManyItemsPerf.default | 1472 | 1415 | 1.04:1 |
| AlertMinimalPerf.default | 189 | 183 | 1.03:1 |
| ImageMinimalPerf.default | 273 | 266 | 1.03:1 |
| RefMinimalPerf.default | 157 | 153 | 1.03:1 |
| TextMinimalPerf.default | 247 | 240 | 1.03:1 |
| AccordionMinimalPerf.default | 103 | 101 | 1.02:1 |
| CarouselMinimalPerf.default | 334 | 328 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 194 | 190 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 912 | 893 | 1.02:1 |
| ListWith60ListItems.default | 462 | 455 | 1.02:1 |
| MenuButtonMinimalPerf.default | 1254 | 1234 | 1.02:1 |
| PopupMinimalPerf.default | 462 | 455 | 1.02:1 |
| AttachmentSlotsPerf.default | 808 | 802 | 1.01:1 |
| InputMinimalPerf.default | 834 | 824 | 1.01:1 |
| ListMinimalPerf.default | 368 | 364 | 1.01:1 |
| ProviderMinimalPerf.default | 299 | 295 | 1.01:1 |
| StatusMinimalPerf.default | 491 | 485 | 1.01:1 |
| CustomToolbarPrototype.default | 2000 | 1975 | 1.01:1 |
| ToolbarMinimalPerf.default | 669 | 665 | 1.01:1 |
| GridMinimalPerf.default | 239 | 239 | 1:1 |
| HeaderMinimalPerf.default | 290 | 291 | 1:1 |
| LoaderMinimalPerf.default | 485 | 485 | 1:1 |
| TableMinimalPerf.default | 307 | 306 | 1:1 |
| TreeMinimalPerf.default | 665 | 662 | 1:1 |
| AnimationMinimalPerf.default | 383 | 386 | 0.99:1 |
| CheckboxMinimalPerf.default | 1521 | 1531 | 0.99:1 |
| LabelMinimalPerf.default | 270 | 272 | 0.99:1 |
| ProviderMergeThemesPerf.default | 938 | 949 | 0.99:1 |
| TooltipMinimalPerf.default | 1753 | 1778 | 0.99:1 |
| VideoMinimalPerf.default | 538 | 548 | 0.98:1 |
| ChatMinimalPerf.default | 531 | 546 | 0.97:1 |
| DatepickerMinimalPerf.default | 4246 | 4359 | 0.97:1 |
| ButtonOverridesMissPerf.default | 959 | 999 | 0.96:1 |
| SplitButtonMinimalPerf.default | 3243 | 3369 | 0.96:1 |
| IconMinimalPerf.default | 500 | 522 | 0.96:1 |
| SegmentMinimalPerf.default | 255 | 269 | 0.95:1 |
| CardMinimalPerf.default | 376 | 398 | 0.94:1 |
| ButtonSlotsPerf.default | 388 | 416 | 0.93:1 |
| FormMinimalPerf.default | 278 | 300 | 0.93:1 |
| ListCommonPerf.default | 445 | 477 | 0.93:1 |
| DialogMinimalPerf.default | 562 | 622 | 0.9:1 |
| RadioGroupMinimalPerf.default | 313 | 350 | 0.89:1 |
| BoxMinimalPerf.default | 236 | 269 | 0.88:1 |
| ListNestedPerf.default | 391 | 444 | 0.88:1 |
layershifter
approved these changes
Sep 26, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 28, 2022
* master: (21 commits) chore: Migrate react-avatar to use new build (microsoft#24969) applying package updates chore(react-input, react-textarea): Deprecating filled with shadow appearance variants (microsoft#24900) fix: v8 Dropdown no longer sets incorrect and unnecessary aria-activedescendant (microsoft#24593) feat: v0 Tooltip migration from v9 (microsoft#24908) chore: bump devDeps to fix critical security vulnerability (microsoft#24891) Fixing Tree chart issues (microsoft#24752) init: new package react-avatar-context (microsoft#24968) ci(.github): add issues write permisions to triage-bot worflow (microsoft#24963) applying package updates fix(Toolbar): close previous submenu when opening another submenu (microsoft#24836) fix: update non-focus-trap Popover role to be group (microsoft#24897) feat: Avatar's aria label includes 'active' or 'inactive' when using the active prop (microsoft#24901) feat(scripts): implement triage-bot module (microsoft#24911) chore: bump @octokit/rest to v18 (microsoft#24919) stress test: add "build-fixture" command (microsoft#24928) BREAKING-CHANGE: new ChatMessageContent for style caching (microsoft#24691) bugfix: fix changefile to properly update version of react-components with a patch (microsoft#24949) feat(scripts): enable strict checking for additional sub-folders(packages) (microsoft#24526) chore: exports DialogContent as unstable (microsoft#24943) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…crosoft#24836) * fix(Toolbar): close previous submenu when opening another submenu * bump screener * fix screener test selectors * Listen for outside click in capture * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
To close a
Toolbarsubmenu when another submenu is opened, there was a DOM event listener applied todocumentin bubble phase.At the same time, in
ToolbarMenuItemReact click handler, the click event propagation is stopped when there is a menu (or popup) attached to the item.In React < 17, React attaches its event listeners to the
documentelement. With that, even though the event propagation is stopped in the click handler, it is still processed by the outside click handler as the two event listeners are attached to the same DOM element.In React 17, React attaches its event listeners to the mount root, which is a child of the document. Now, when the event propagation is stopped in the click handler (React root in DOM) it does not trigger outside click handler (
documentin DOM). For that reason the old submenu is not closed.New Behavior
The outside click handler was moved to a capture phase and is invoked before the item click handler. The old menu is closed as expected.
Related Issue(s)
Fixes #24833