-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(react-input, react-textarea): Deprecating filled with shadow appearance variants #24900
chore(react-input, react-textarea): Deprecating filled with shadow appearance variants #24900
Conversation
Can you expand on the issue a bit more please? |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b4077e2:
|
📊 Bundle size report
Unchanged fixtures
|
I just updated it :) I'm mainly preparing this PR to discuss it next week. |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 1295 | 1312 | 5000 | |
Button | mount | 933 | 949 | 5000 | |
FluentProvider | mount | 1604 | 1571 | 5000 | |
FluentProviderWithTheme | mount | 622 | 633 | 10 | |
FluentProviderWithTheme | virtual-rerender | 591 | 585 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 630 | 625 | 10 | |
MakeStyles | mount | 1886 | 1887 | 50000 | |
SpinButton | mount | 2529 | 2537 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 483f160617f1037e672fe74b8e52abfee9378517 (build) |
* master: (21 commits) chore: Migrate react-avatar to use new build (microsoft#24969) applying package updates chore(react-input, react-textarea): Deprecating filled with shadow appearance variants (microsoft#24900) fix: v8 Dropdown no longer sets incorrect and unnecessary aria-activedescendant (microsoft#24593) feat: v0 Tooltip migration from v9 (microsoft#24908) chore: bump devDeps to fix critical security vulnerability (microsoft#24891) Fixing Tree chart issues (microsoft#24752) init: new package react-avatar-context (microsoft#24968) ci(.github): add issues write permisions to triage-bot worflow (microsoft#24963) applying package updates fix(Toolbar): close previous submenu when opening another submenu (microsoft#24836) fix: update non-focus-trap Popover role to be group (microsoft#24897) feat: Avatar's aria label includes 'active' or 'inactive' when using the active prop (microsoft#24901) feat(scripts): implement triage-bot module (microsoft#24911) chore: bump @octokit/rest to v18 (microsoft#24919) stress test: add "build-fixture" command (microsoft#24928) BREAKING-CHANGE: new ChatMessageContent for style caching (microsoft#24691) bugfix: fix changefile to properly update version of react-components with a patch (microsoft#24949) feat(scripts): enable strict checking for additional sub-folders(packages) (microsoft#24526) chore: exports DialogContent as unstable (microsoft#24943) ...
…pearance variants (microsoft#24900) * fix: Deprecate filled with shadow appearance variants. * change files * wording
This PR removes the filled with shadow appearance variants. This is due to the shadow appearances not being visible when used on a background that meets our contrast ratio guidelines.
This is how our current docs show the variants:
To be able to see the shadow, a lighter background is required like this one:
This contradicts our guidelines on using a background with enough contrast ratio for accessibility requirements.