fix: update non-focus-trap Popover role to be group #24897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d4d8c58:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 62aadfe9a8429fbc5c0660c1e741e5e8171f8f23 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1584 | 1618 | 5000 | |
| Button | mount | 1179 | 1144 | 5000 | |
| FluentProvider | mount | 1912 | 1930 | 5000 | |
| FluentProviderWithTheme | mount | 767 | 760 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 715 | 732 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 766 | 769 | 10 | |
| MakeStyles | mount | 2323 | 2344 | 50000 | |
| SpinButton | mount | 3184 | 3085 | 5000 |
jurokapsiar
approved these changes
Sep 22, 2022
ling1726
approved these changes
Sep 22, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 28, 2022
* master: (21 commits) chore: Migrate react-avatar to use new build (microsoft#24969) applying package updates chore(react-input, react-textarea): Deprecating filled with shadow appearance variants (microsoft#24900) fix: v8 Dropdown no longer sets incorrect and unnecessary aria-activedescendant (microsoft#24593) feat: v0 Tooltip migration from v9 (microsoft#24908) chore: bump devDeps to fix critical security vulnerability (microsoft#24891) Fixing Tree chart issues (microsoft#24752) init: new package react-avatar-context (microsoft#24968) ci(.github): add issues write permisions to triage-bot worflow (microsoft#24963) applying package updates fix(Toolbar): close previous submenu when opening another submenu (microsoft#24836) fix: update non-focus-trap Popover role to be group (microsoft#24897) feat: Avatar's aria label includes 'active' or 'inactive' when using the active prop (microsoft#24901) feat(scripts): implement triage-bot module (microsoft#24911) chore: bump @octokit/rest to v18 (microsoft#24919) stress test: add "build-fixture" command (microsoft#24928) BREAKING-CHANGE: new ChatMessageContent for style caching (microsoft#24691) bugfix: fix changefile to properly update version of react-components with a patch (microsoft#24949) feat(scripts): enable strict checking for additional sub-folders(packages) (microsoft#24526) chore: exports DialogContent as unstable (microsoft#24943) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #21416
We do want to use a non-dialog role for the non-focus-trapping variant, but
complementaryisn't the best fit -- it refers specifically to content that is complementary to the main region, and on the same level as the main region in content hierarchy. That doesn't really apply to most popovers, so this PR updates it to thegrouprole for the following reasons:groupin particular enables thatOther roles that were considered:
note: it generally seems fine, but it would be weird to have nested notes, and it has a narrow range of expected use casesregion: this would add popovers to the landmark list. It seems too heavy for something that is probably going to be a small, transient addition to the page, but we could reconsider it based on user feedback. The benefit would be that it would be easier to find with a screen reader's virtual cursor.