fix: use trigger prop for aria-haspopup #24794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9e6dc48:
|
📊 Bundle size report🤖 This report was generated against d83195cc36e432b094af3dd79eb1792564972ae9 |
Asset size changes
Baseline commit: d83195cc36e432b094af3dd79eb1792564972ae9 (build) |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| LabelMinimalPerf.default | 323 | 274 | 1.18:1 |
| ReactionMinimalPerf.default | 313 | 276 | 1.13:1 |
| MenuButtonMinimalPerf.default | 1392 | 1245 | 1.12:1 |
| HeaderMinimalPerf.default | 285 | 261 | 1.09:1 |
| TreeWith60ListItems.default | 139 | 127 | 1.09:1 |
| AttachmentMinimalPerf.default | 122 | 113 | 1.08:1 |
| ButtonOverridesMissPerf.default | 1037 | 956 | 1.08:1 |
| AttachmentSlotsPerf.default | 945 | 885 | 1.07:1 |
| DatepickerMinimalPerf.default | 4786 | 4454 | 1.07:1 |
| FormMinimalPerf.default | 320 | 300 | 1.07:1 |
| ListMinimalPerf.default | 425 | 401 | 1.06:1 |
| PortalMinimalPerf.default | 148 | 139 | 1.06:1 |
| ChatDuplicateMessagesPerf.default | 243 | 232 | 1.05:1 |
| ChatMinimalPerf.default | 600 | 570 | 1.05:1 |
| CheckboxMinimalPerf.default | 1709 | 1635 | 1.05:1 |
| FlexMinimalPerf.default | 238 | 226 | 1.05:1 |
| StatusMinimalPerf.default | 565 | 536 | 1.05:1 |
| ItemLayoutMinimalPerf.default | 971 | 935 | 1.04:1 |
| ProviderMergeThemesPerf.default | 1032 | 991 | 1.04:1 |
| AvatarMinimalPerf.default | 159 | 155 | 1.03:1 |
| DialogMinimalPerf.default | 648 | 628 | 1.03:1 |
| DropdownMinimalPerf.default | 2230 | 2166 | 1.03:1 |
| ListCommonPerf.default | 510 | 495 | 1.03:1 |
| TooltipMinimalPerf.default | 1948 | 1900 | 1.03:1 |
| DropdownManyItemsPerf.default | 540 | 531 | 1.02:1 |
| ToolbarMinimalPerf.default | 771 | 759 | 1.02:1 |
| TreeMinimalPerf.default | 665 | 649 | 1.02:1 |
| BoxMinimalPerf.default | 278 | 274 | 1.01:1 |
| MenuMinimalPerf.default | 701 | 697 | 1.01:1 |
| RosterPerf.default | 1768 | 1756 | 1.01:1 |
| PopupMinimalPerf.default | 527 | 524 | 1.01:1 |
| SliderMinimalPerf.default | 1309 | 1301 | 1.01:1 |
| TableManyItemsPerf.default | 1557 | 1543 | 1.01:1 |
| CustomToolbarPrototype.default | 2252 | 2233 | 1.01:1 |
| HeaderSlotsPerf.default | 618 | 616 | 1:1 |
| LayoutMinimalPerf.default | 258 | 259 | 1:1 |
| ListWith60ListItems.default | 515 | 515 | 1:1 |
| TextMinimalPerf.default | 275 | 276 | 1:1 |
| CardMinimalPerf.default | 430 | 435 | 0.99:1 |
| LoaderMinimalPerf.default | 549 | 554 | 0.99:1 |
| AlertMinimalPerf.default | 216 | 220 | 0.98:1 |
| ButtonMinimalPerf.default | 122 | 125 | 0.98:1 |
| EmbedMinimalPerf.default | 2953 | 3018 | 0.98:1 |
| ProviderMinimalPerf.default | 327 | 332 | 0.98:1 |
| TextAreaMinimalPerf.default | 364 | 371 | 0.98:1 |
| VideoMinimalPerf.default | 586 | 596 | 0.98:1 |
| ButtonSlotsPerf.default | 443 | 455 | 0.97:1 |
| ImageMinimalPerf.default | 310 | 320 | 0.97:1 |
| SplitButtonMinimalPerf.default | 3495 | 3602 | 0.97:1 |
| IconMinimalPerf.default | 518 | 536 | 0.97:1 |
| AnimationMinimalPerf.default | 421 | 438 | 0.96:1 |
| SegmentMinimalPerf.default | 274 | 285 | 0.96:1 |
| ChatWithPopoverPerf.default | 289 | 303 | 0.95:1 |
| InputMinimalPerf.default | 896 | 948 | 0.95:1 |
| GridMinimalPerf.default | 252 | 270 | 0.93:1 |
| DividerMinimalPerf.default | 258 | 280 | 0.92:1 |
| ListNestedPerf.default | 410 | 446 | 0.92:1 |
| RadioGroupMinimalPerf.default | 336 | 365 | 0.92:1 |
| RefMinimalPerf.default | 163 | 178 | 0.92:1 |
| CarouselMinimalPerf.default | 344 | 380 | 0.91:1 |
| TableMinimalPerf.default | 292 | 325 | 0.9:1 |
| SkeletonMinimalPerf.default | 242 | 283 | 0.86:1 |
| AccordionMinimalPerf.default | 107 | 126 | 0.85:1 |
layershifter
approved these changes
Sep 16, 2022
ling1726
reviewed
Sep 16, 2022
ling1726
approved these changes
Sep 16, 2022
auto-merge was automatically disabled
September 19, 2022 12:57
Pull request was closed
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 19, 2022
* master: (28 commits) fix: use trigger prop for aria-haspopup (microsoft#24794) chore(react-dialog): scaffold DialogContent component (microsoft#24844) chore: Northstar screener should read from screenerStates.json (microsoft#24848) applying package updates (web components) Standardize focus treatment (microsoft#24771) Divider - allow default prop override (microsoft#24840) GroupedList: fix virtualization (unstable preview) (microsoft#24460) fix: Add explicit children prop to TeachingBubble to support React 18 (microsoft#24823) feat: Adds `visible` prop to `TableCellActions` (microsoft#24831) [Northstar][Dropdown] Fix styling mutation when merging themes (microsoft#24787) fix: export `tableCellActionsClassNames` from unstable (microsoft#24830) bugfix(react-dialog): Adds color style to DialogSurface (microsoft#24832) applying package updates Prevent group toggling from selecting the whole group (microsoft#24822) feat(react-textarea): Add shadow variant of filled appearance (microsoft#24512) applying package updates Adding lib-commonjs top-level entries to exports map (microsoft#24792) Created shim packages (microsoft#24780) feat(react-menu): replace keydown handlers by useARIAButtonShorthand on MenuItem (microsoft#24738) fix: update version mismatches triggered by v9 release (microsoft#24812) ...
khmakoto
added
Fluent UI react-northstar (v0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Fluent popup adds aria-haspopup=dialog to its trigger element even when disabled it from the consuming end
https://codesandbox.io/s/fluent-ui-example-forked-6fhu8x?file=/example.js:0-352
New Behavior
Trigger will respect if attribute is set to it