Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update version mismatches triggered by v9 release #24812

Merged
merged 4 commits into from
Sep 15, 2022
Merged

fix: update version mismatches triggered by v9 release #24812

merged 4 commits into from
Sep 15, 2022

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Sep 15, 2022 •
edited
Loading

  • manual version fixes to non v9 packages that depend on v9 packages after v9 release

@Hotell Hotell changed the title Hotell/fix/version mismatches after v9 release fix: update version mismatches triggered by v9 release Sep 15, 2022
@github-actions github-actions bot added this to the July Project Cycle Q3 2022 milestone Sep 15, 2022
@Hotell Hotell marked this pull request as ready for review September 15, 2022 10:18
@Hotell Hotell requested review from a team as code owners September 15, 2022 10:18
@Hotell Hotell removed this from the July Project Cycle Q3 2022 milestone Sep 15, 2022
@Hotell Hotell enabled auto-merge (squash) September 15, 2022 10:19
@Hotell
Copy link
Contributor Author

Hotell commented Sep 15, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 15, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8a0ce65:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@Hotell Hotell requested a review from a team as a code owner September 15, 2022 10:36
@github-actions github-actions bot added this to the July Project Cycle Q3 2022 milestone Sep 15, 2022
@DustyTheBot
Copy link

DustyTheBot commented Sep 15, 2022 •
edited
Loading

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 8a0ce65

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 15, 2022 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against a33448fe4a0f4117686c378f80b893d1406d95a8

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1309 1294 5000
Button mount 953 953 5000
FluentProvider mount 1601 1587 5000
FluentProviderWithTheme mount 628 631 10
FluentProviderWithTheme virtual-rerender 591 595 10
FluentProviderWithTheme virtual-rerender-with-unmount 632 626 10
MakeStyles mount 1897 1883 50000
SpinButton mount 2524 2493 5000

@size-auditor
Copy link

size-auditor bot commented Sep 15, 2022

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 6699e11

Possible causes

  • The baseline build 6699e11 is broken
  • The Size Auditor run for the baseline build 6699e11 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 15, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
SegmentMinimalPerf.default 293 243 1.21:1
RefMinimalPerf.default 187 156 1.2:1
TextMinimalPerf.default 284 248 1.15:1
GridMinimalPerf.default 277 243 1.14:1
CarouselMinimalPerf.default 375 333 1.13:1
ChatMinimalPerf.default 586 535 1.1:1
AttachmentMinimalPerf.default 123 114 1.08:1
ReactionMinimalPerf.default 305 285 1.07:1
TreeWith60ListItems.default 138 130 1.06:1
AttachmentSlotsPerf.default 941 900 1.05:1
FlexMinimalPerf.default 201 192 1.05:1
TableManyItemsPerf.default 1547 1470 1.05:1
ToolbarMinimalPerf.default 757 729 1.04:1
VideoMinimalPerf.default 613 592 1.04:1
DropdownManyItemsPerf.default 547 530 1.03:1
IconMinimalPerf.default 555 541 1.03:1
BoxMinimalPerf.default 280 274 1.02:1
ButtonOverridesMissPerf.default 1069 1049 1.02:1
ButtonSlotsPerf.default 456 449 1.02:1
LayoutMinimalPerf.default 299 294 1.02:1
ListWith60ListItems.default 508 499 1.02:1
MenuMinimalPerf.default 698 681 1.02:1
ProviderMinimalPerf.default 334 329 1.02:1
StatusMinimalPerf.default 570 560 1.02:1
ButtonMinimalPerf.default 137 135 1.01:1
ChatDuplicateMessagesPerf.default 232 229 1.01:1
ChatWithPopoverPerf.default 311 307 1.01:1
HeaderSlotsPerf.default 637 630 1.01:1
InputMinimalPerf.default 950 943 1.01:1
LoaderMinimalPerf.default 553 549 1.01:1
TreeMinimalPerf.default 666 662 1.01:1
AlertMinimalPerf.default 218 218 1:1
CheckboxMinimalPerf.default 1739 1735 1:1
FormMinimalPerf.default 273 273 1:1
ListCommonPerf.default 456 455 1:1
RosterPerf.default 1750 1757 1:1
SkeletonMinimalPerf.default 275 276 1:1
AnimationMinimalPerf.default 436 440 0.99:1
CardMinimalPerf.default 432 435 0.99:1
DialogMinimalPerf.default 625 632 0.99:1
DropdownMinimalPerf.default 2219 2238 0.99:1
ProviderMergeThemesPerf.default 1054 1063 0.99:1
SplitButtonMinimalPerf.default 3552 3606 0.99:1
CustomToolbarPrototype.default 2205 2229 0.99:1
AvatarMinimalPerf.default 153 156 0.98:1
DatepickerMinimalPerf.default 4586 4672 0.98:1
ItemLayoutMinimalPerf.default 921 940 0.98:1
LabelMinimalPerf.default 270 276 0.98:1
ListNestedPerf.default 441 450 0.98:1
PopupMinimalPerf.default 513 521 0.98:1
HeaderMinimalPerf.default 289 297 0.97:1
MenuButtonMinimalPerf.default 1352 1396 0.97:1
TooltipMinimalPerf.default 1856 1917 0.97:1
EmbedMinimalPerf.default 2912 3023 0.96:1
PortalMinimalPerf.default 132 137 0.96:1
AccordionMinimalPerf.default 118 124 0.95:1
ListMinimalPerf.default 392 412 0.95:1
TextAreaMinimalPerf.default 357 379 0.94:1
ImageMinimalPerf.default 290 313 0.93:1
TableMinimalPerf.default 293 322 0.91:1
RadioGroupMinimalPerf.default 321 358 0.9:1
SliderMinimalPerf.default 1188 1335 0.89:1
DividerMinimalPerf.default 244 280 0.87:1

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 15, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 774 747 5000
Breadcrumb mount 2437 2465 1000
Checkbox mount 2241 2227 5000
CheckboxBase mount 1950 1927 5000
ChoiceGroup mount 3980 4000 5000
ComboBox mount 832 832 1000
CommandBar mount 9181 10561 1000
ContextualMenu mount 10656 10864 1000
DefaultButton mount 981 947 5000
DetailsRow mount 3248 3202 5000
DetailsRowFast mount 3179 3262 5000
DetailsRowNoStyles mount 3050 3066 5000
Dialog mount 2688 2667 1000
DocumentCardTitle mount 156 162 1000
Dropdown mount 2819 2802 5000
FocusTrapZone mount 1592 1579 5000
FocusZone mount 1570 1555 5000
IconButton mount 1483 1482 5000
Label mount 293 284 5000
Layer mount 3829 3907 5000
Link mount 404 392 5000
MenuButton mount 1249 1249 5000
MessageBar mount 1818 1789 5000
Nav mount 2828 2829 1000
OverflowSet mount 940 942 5000
Panel mount 2116 2107 1000
Persona mount 861 851 1000
Pivot mount 1231 1232 1000
PrimaryButton mount 1103 1090 5000
Rating mount 6559 6610 5000
SearchBox mount 1084 1092 5000
Shimmer mount 2453 2451 5000
Slider mount 1705 1636 5000
SpinButton mount 4228 4216 5000
Spinner mount 366 383 5000
SplitButton mount 2685 2687 5000
Stack mount 435 442 5000
StackWithIntrinsicChildren mount 1915 1907 5000
StackWithTextChildren mount 4373 4308 5000
SwatchColorPicker mount 10210 10067 5000
TagPicker mount 2254 2196 5000
TeachingBubble mount 89591 92216 5000
Text mount 378 355 5000
TextField mount 1156 1685 5000
ThemeProvider mount 1107 1117 5000
ThemeProvider virtual-rerender 1949 658 5000
ThemeProvider virtual-rerender-with-unmount 4564 2041 5000
Toggle mount 692 703 5000
buttonNative mount 112 112 5000

@layershifter layershifter merged commit b111ddd into microsoft:master Sep 15, 2022
@Hotell Hotell deleted the hotell/fix/version-mismatches-after-v9-release branch September 15, 2022 13:16
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 19, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/fix/card-codesandbox-examples
3db2b04 
* master: (28 commits)
  fix: use trigger prop for aria-haspopup (microsoft#24794)
  chore(react-dialog): scaffold DialogContent component (microsoft#24844)
  chore: Northstar screener should read from screenerStates.json (microsoft#24848)
  applying package updates
  (web components) Standardize focus treatment (microsoft#24771)
  Divider - allow default prop override (microsoft#24840)
  GroupedList: fix virtualization (unstable preview) (microsoft#24460)
  fix: Add explicit children prop to TeachingBubble to support React 18 (microsoft#24823)
  feat: Adds `visible` prop to `TableCellActions` (microsoft#24831)
  [Northstar][Dropdown] Fix styling mutation when merging themes (microsoft#24787)
  fix: export `tableCellActionsClassNames` from unstable (microsoft#24830)
  bugfix(react-dialog): Adds color style to DialogSurface (microsoft#24832)
  applying package updates
  Prevent group toggling from selecting the whole group (microsoft#24822)
  feat(react-textarea): Add shadow variant of filled appearance (microsoft#24512)
  applying package updates
  Adding lib-commonjs top-level entries to exports map (microsoft#24792)
  Created shim packages (microsoft#24780)
  feat(react-menu): replace keydown handlers by useARIAButtonShorthand on MenuItem (microsoft#24738)
  fix: update version mismatches triggered by v9 release (microsoft#24812)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ling1726 ling1726 ling1726 approved these changes

@bsunderhus bsunderhus bsunderhus approved these changes

Assignees

@Hotell Hotell

Labels
CI Priority 1: High
Projects
None yet
Milestone
July Project Cycle Q3 2022
Development

Successfully merging this pull request may close these issues.
6 participants
@Hotell @DustyTheBot @fabricteam @bsunderhus @ling1726 @layershifter