Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-persona): Add bundle-size command for bundle-size fixtures #25055

Merged

Conversation

sopranopillow
Copy link
Contributor

This PR adds the missing bundle-size command to run the bundle-size fixtures.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4b8a38a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-persona
Persona
0 B
0 B
53.946 kB
15.225 kB
🆕 New entry
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.209 kB
52.401 kB
react-components
react-components: FluentProvider & webLightTheme
33.4 kB
11.008 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against b0b7f99bbbb05b0bd136432983a74fea252c7163

@size-auditor
Copy link

size-auditor bot commented Oct 3, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b0b7f99bbbb05b0bd136432983a74fea252c7163 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1463 1487 5000
Button mount 1058 1070 5000
FluentProvider mount 1790 1789 5000
FluentProviderWithTheme mount 717 721 10
FluentProviderWithTheme virtual-rerender 674 663 10
FluentProviderWithTheme virtual-rerender-with-unmount 705 720 10
MakeStyles mount 2126 2121 50000
SpinButton mount 2860 2828 5000

@sopranopillow sopranopillow merged commit 67a8c98 into microsoft:master Oct 3, 2022
@sopranopillow sopranopillow deleted the persona/bundle-size-fixtures branch October 3, 2022 21:56
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 5, 2022
* master: (62 commits)
  chore(migrate-converged): add functionality to execute various v9 package file restructuring tasks (microsoft#24458)
  chore(react-dialog): updates stories (microsoft#25070)
  refactor Progress to remove label and description slots (microsoft#25067)
  fix(SplitButton): Remove borders from hover and pressed state in primary split buttons (microsoft#25059)
  chore(react-persona): Add vr, conformance, and unit tests (microsoft#25007)
  (docs): update Icon docs with examples (microsoft#24768)
  Split button/primary hc fix (microsoft#25066)
  chore(react-utilities): restricts trigger API types (microsoft#25044)
  Add utilities export @fluentui/style-utilities v8 (microsoft#25065)
  chore: migrate whole repo to webpack 5 (microsoft#24542)
  applying package updates
  BREAKING: refactor `useTable` to be composable (microsoft#24947)
  Added shims to shim packages (microsoft#25048)
  Add Progress SPEC (microsoft#24418)
  applying package updates
  chore(react-persona): Add bundle-size command for bundle-size fixtures (microsoft#25055)
  fix(Button): Remove margin added to buttons by Safari (microsoft#25052)
  fix: Menu triggers no longer take focus when they are mounted (microsoft#25016)
  chore: deletes react-trigger package (microsoft#25042)
  Fixed a minor typo: immmediately => immediately (microsoft#25036)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
microsoft#25055)

* chore: Adding bundle-size command for bundle size fixtures.

* change file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants