fix: Menu triggers no longer take focus when they are mounted

[behowell]

Current Behavior

Menu triggers take focus when they're first mounted.

This is likely a regression from #24738. Specifically, the removal of shouldHandleKeyboardRef from useMenu.tsx is causing it to always call state.triggerRef.current?.focus() when mounted.

-    if (shouldHandleKeyboardRef.current && !open) {
+    if (!open) {
      if (shouldHandleTabRef.current && !state.isSubmenu) {
        pressedShiftRef.current ? focusBeforeMenuTrigger() : focusAfterMenuTrigger();
      } else {
        state.triggerRef.current?.focus();
      }
    }

New Behavior

Restore the shouldHandleKeyboardRef check to useMenu_unstable.

@bsunderhus I'm not familiar with the reason that it was removed in the first place. If this is not the correct fix, please assign the issue to yourself so you can make the correct fix. Thanks!

Related Issue(s)

• Fixes [Bug]: Menu triggers autofocus on mount #24981

[fabricteam]

📊 Bundle size report

Package & Exports	Baseline (minified/GZIP)	PR	Change
react-components react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	189.156 kB 52.385 kB	189.209 kB 52.401 kB	53 B 16 B
react-menu Menu (including children components)	116.718 kB 35.78 kB	116.771 kB 35.786 kB	53 B 6 B
react-menu Menu (including selectable components)	119.787 kB 36.289 kB	119.84 kB 36.296 kB	53 B 7 B

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
react-components react-components: FluentProvider & webLightTheme	33.4 kB 11.008 kB
react-portal-compat PortalCompatProvider	5.857 kB 1.978 kB

_{🤖 This report was generated against 0885025f43076ebdf3a395cfb6ae65b3304cc5b2}

[size-auditor]

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0885025f43076ebdf3a395cfb6ae65b3304cc5b2 (build)

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c01761d:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration
suspicious-cloud-ir1l1b	Issue #24981

[fabricteam]

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	1559	1565	5000
Button	mount	1121	1127	5000
FluentProvider	mount	1883	1923	5000
FluentProviderWithTheme	mount	768	769	10
FluentProviderWithTheme	virtual-rerender	703	694	10
FluentProviderWithTheme	virtual-rerender-with-unmount	742	738	10
MakeStyles	mount	2314	2293	50000
SpinButton	mount	2993	3024	5000

[ling1726]

The original issue filed by @smhigley was #24680

Let's discuss this first to make sure we know what our focus requirements are for mouse users

More discussion needed

[ling1726]

It seems this bug is more serious than I thought. I think it makes more sense to merge this PR and reopen #24680