fix: Menu trigger should be focused when menu is closed with keyboard #25165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboard handling flag was only set when the key was `Tab` this is incorrect and the keyboard handling flag should be set every time the event is a keyboard event
ling1726
commented
Oct 11, 2022
| .type('{esc}') | ||
| .get(menuSelector) | ||
| .should('not.exist') | ||
| .get(menuTriggerSelector) |
There was a problem hiding this comment.
These situations should now be caught with tests
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8954cd0e856c4fdda7745f40d3c30916a6e24f6b (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f199475:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1266 | 1269 | 5000 | |
| Button | mount | 930 | 908 | 5000 | |
| FluentProvider | mount | 1509 | 1513 | 5000 | |
| FluentProviderWithTheme | mount | 579 | 578 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 542 | 545 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 577 | 577 | 10 | |
| MakeStyles | mount | 1962 | 1947 | 50000 | |
| SpinButton | mount | 2389 | 2310 | 5000 |
bsunderhus
approved these changes
Oct 11, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 11, 2022
* master: fix: Menu trigger should be focused when menu is closed with keyboard (microsoft#25165) fix(codemods): Do not fail on empty configMod config (microsoft#25148) fix: Field should have block layout, not inline (microsoft#25126) chore: Update Griffel to latest version (microsoft#25075)
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…microsoft#25165) * fix: Menu trigger should be focused when menu is closed with keyboard keyboard handling flag was only set when the key was `Tab` this is incorrect and the keyboard handling flag should be set every time the event is a keyboard event * changefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25016 missed out on a crucial condition.
keyboard handling flag was only set when the key was
Tabthis is incorrect and the keyboard handling flag should be set every time the event is a keyboard event