Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Menu and MenuItem as new web components #26765
Adds Menu and MenuItem as new web components #26765
Changes from 44 commits
495ebcd
584ff04
052a5c4
b238618
f15b09e
05feee7
39930bd
37a69ce
485d8dd
15d29c4
29090b3
2465f7b
d9725ea
6ee366e
5b98085
811da97
5348418
dbfd608
534141e
9c1bb70
ab5f353
3d5cded
208ba81
b860811
9488f79
ff3f62c
81638aa
2f3e908
eaae97d
c4121a3
9da003b
177f05d
13ee51d
cd59148
0638b67
493a906
3199788
dceaa87
825a324
3f95049
ac429a1
97f3d97
704575b
17be9d9
cc71898
5d04627
1a69838
87125ec
b050a6a
de54feb
fe5c09c
0b4d5ef
08de7d1
929597f
7d3aaa4
4eebbf5
3a63ee4
b13f6bd
8255212
2d8796e
24d7895
f6a0d93
1c8998d
56282af
3a5370e
90ff4d7
a0ae4c7
1ae068c
5a07e7c
7c54b52
65eb87c
8c5a1d1
b24f657
57d11c5
49952b6
fd1bccb
88b06a8
d79fab8
5844949
c34ad00
92eceb9
22009f7
e8ad6b6
2c9bfc1
a5b9fd3
956eee8
2946183
550d1ab
bd5fb72
e7b2c10
e5238d7
cd2d9b7
9048956
559127a
e8d63a1
84d5738
543453a
464e97d
e683381
b84e6e9
ab5b7ca
e31be49
96e4870
1e1621e
abebe36
d7f4122
d9b27cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are still valid, create tracking issues, with Fluent UI WC (v3) tag.
fwiw, FAST already supports grouping by using a divider item between groups. Do we want to achieve parity with FUIR9 which uses
name
for the groups or are we OK with the difference?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 (divider). This has been confirmed the divider is being used in the storybook
Issue #27042: Menu Closing Behavior and Support for Menu Grouping, Header, and Split Button to MenuItem Component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fluent-menu
matchesMenuList
notMenu
.TBH, I still would rather see this being named
fluent-menu-list
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can combine this and the below using
grid-gap