-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Menu and MenuItem as new web components #26765
Merged
brianchristopherbrady
merged 107 commits into
web-components-v3
from
user/brianbrady/web-component-menu
Apr 20, 2023
Merged
Changes from 95 commits
Commits
Show all changes
107 commits
Select commit
Hold shift + click to select a range
495ebcd
menu init
brianchristopherbrady 584ff04
updates docs
brianchristopherbrady 052a5c4
menu init
brianchristopherbrady b238618
menu item init
brianchristopherbrady f15b09e
registers menu-item
brianchristopherbrady 05feee7
adds some menu styles
brianchristopherbrady 39930bd
adds default menu item icons
brianchristopherbrady 37a69ce
adds menu stories
brianchristopherbrady 485d8dd
updates default menu icons
brianchristopherbrady 15d29c4
styles menu and menu item
brianchristopherbrady 29090b3
updates readme
brianchristopherbrady 2465f7b
swaps part for class css
brianchristopherbrady d9725ea
removes dead code
brianchristopherbrady 6ee366e
adds menu and menu item to package.json
brianchristopherbrady 5b98085
removes dead code
brianchristopherbrady 811da97
updates menu styles
brianchristopherbrady 5348418
Merge branch 'web-components-v3' into user/brianbrady/web-component-menu
brianchristopherbrady dbfd608
yarn change
brianchristopherbrady 534141e
adds menu header
brianchristopherbrady 9c1bb70
updates jsdocs
brianchristopherbrady ab5f353
removes dead file
brianchristopherbrady 3d5cded
removes dead code
brianchristopherbrady 208ba81
removes split button styling
brianchristopherbrady b860811
Merge branch 'web-components-v3' into user/brianbrady/web-component-menu
brianchristopherbrady 9488f79
adds display helper
brianchristopherbrady ff3f62c
api report
brianchristopherbrady 81638aa
Merge branch 'web-components-v3' of https://github.com/microsoft/flue…
brianchristopherbrady 2f3e908
merge web-components-v3
brianchristopherbrady eaae97d
flattens menu and menu item directories
brianchristopherbrady c4121a3
removes element specification from slotted selector
brianchristopherbrady 9da003b
formatting
brianchristopherbrady 177f05d
optimizes styles
brianchristopherbrady 13ee51d
optmizes styles
brianchristopherbrady cd59148
updates disabled css selector to bool
brianchristopherbrady 0638b67
removes dead code
brianchristopherbrady 493a906
consolidates menu docs into one story
brianchristopherbrady 3199788
updates menu storybook content
brianchristopherbrady dceaa87
optimizes styling
brianchristopherbrady 825a324
revert api-report
brianchristopherbrady 3f95049
updates disabled pseudo selector
brianchristopherbrady ac429a1
fixes disabled state
brianchristopherbrady 97f3d97
fixes css syntax error
brianchristopherbrady 704575b
updates storybook content
brianchristopherbrady 17be9d9
updates storybook copy for consistency
brianchristopherbrady cc71898
merge master
brianchristopherbrady 5d04627
revert api report
brianchristopherbrady 1a69838
updates yarn change message
brianchristopherbrady 87125ec
maps component to MenuList rather than Menu
brianchristopherbrady b050a6a
fixes focus state
brianchristopherbrady de54feb
updates styles
brianchristopherbrady fe5c09c
divides accordion and accordion item readme
brianchristopherbrady 0b4d5ef
removes dead imports
brianchristopherbrady 08de7d1
Merge branch 'web-components-v3' of https://github.com/microsoft/flue…
brianchristopherbrady 929597f
Merge branch 'web-components-v3' into user/brianbrady/web-component-menu
brianchristopherbrady 7d3aaa4
fixes submenu positioning
brianchristopherbrady 4eebbf5
adds styles for icon alignment
brianchristopherbrady 3a63ee4
reverts Menu component name
brianchristopherbrady b13f6bd
cleans up storybook
brianchristopherbrady 8255212
Merge branch 'web-components-v3' of https://github.com/microsoft/flue…
brianchristopherbrady 2d8796e
merge
brianchristopherbrady 24d7895
dynamically set the menu item icon attribute when icons is true for m…
chrisdholt f6a0d93
updates Menu styles
brianchristopherbrady 1c8998d
updates icon alignment styles and docs
brianchristopherbrady 56282af
updates menu docs
brianchristopherbrady 3a5370e
adds checkmarks attribute and styles menu items
brianchristopherbrady 90ff4d7
adds conditional styling for when icons are present
brianchristopherbrady a0ae4c7
updates Menu and MenuItem docs
brianchristopherbrady 1ae068c
updates deltas in docs
brianchristopherbrady 5a07e7c
updates docs
brianchristopherbrady 7c54b52
merge
brianchristopherbrady 65eb87c
Merge branch 'web-components-v3' into user/brianbrady/web-component-menu
brianchristopherbrady 8c5a1d1
Merge branch 'web-components-v3' into user/brianbrady/web-component-menu
brianchristopherbrady b24f657
optimizes styles
brianchristopherbrady 57d11c5
optimizes css
brianchristopherbrady 49952b6
Merge branch 'user/brianbrady/web-component-menu' of https://github.c…
brianchristopherbrady fd1bccb
optimizes css
brianchristopherbrady 88b06a8
optimizes css
brianchristopherbrady d79fab8
reverts json export
brianchristopherbrady 5844949
Merge branch 'web-components-v3' of https://github.com/microsoft/flue…
brianchristopherbrady c34ad00
working (#27293)
eljefe223 92eceb9
optimizes styles
brianchristopherbrady 22009f7
adds docs to menu.ts
brianchristopherbrady e8ad6b6
updates menu logic for readability
brianchristopherbrady 2c9bfc1
Merge branch 'web-components-v3' of https://github.com/microsoft/flue…
brianchristopherbrady a5b9fd3
merge
brianchristopherbrady 956eee8
Merge branch 'web-components-v3' into user/brianbrady/web-component-menu
brianchristopherbrady 2946183
Merge branch 'web-components-v3' of https://github.com/microsoft/flue…
brianchristopherbrady 550d1ab
menu: fixes style syntax error
brianchristopherbrady bd5fb72
menu: consolidates styles
brianchristopherbrady e7b2c10
Merge branch 'web-components-v3' of https://github.com/microsoft/flue…
brianchristopherbrady e5238d7
Merge branch 'web-components-v3' into user/brianbrady/web-component-menu
brianchristopherbrady cd2d9b7
menu: updates styling
brianchristopherbrady 9048956
menu: updates styling
brianchristopherbrady 559127a
Merge branch 'web-components-v3' into user/brianbrady/web-component-menu
brianchristopherbrady e8d63a1
Merge branch 'web-components-v3' into user/brianbrady/web-component-menu
brianchristopherbrady 84d5738
Merge branch 'web-components-v3' of https://github.com/microsoft/flue…
brianchristopherbrady 543453a
Merge branch 'web-components-v3' of https://github.com/microsoft/flue…
brianchristopherbrady 464e97d
Merge branch 'web-components-v3' into user/brianbrady/web-component-menu
brianchristopherbrady e683381
Merge branch 'web-components-v3' into user/brianbrady/web-component-menu
brianchristopherbrady b84e6e9
Merge branch 'web-components-v3' of https://github.com/microsoft/flue…
brianchristopherbrady ab5b7ca
menu: merge wc3
brianchristopherbrady e31be49
yarn change
brianchristopherbrady 96e4870
Merge branch 'user/brianbrady/web-component-menu' of https://github.c…
brianchristopherbrady 1e1621e
menulist, menuitem: changes component name to MenuList
brianchristopherbrady abebe36
menulist, menuitem, updates readme
brianchristopherbrady d7f4122
menu, menuitem: fixes circular dep
brianchristopherbrady d9b27cf
menu, menuitem: alphabetize index.js
brianchristopherbrady File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@fluentui-web-components-e1aaa3a2-771d-4c16-b8d2-a56deb1fdd28.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "prerelease", | ||
"comment": "feat(menu): Add menu and menu-item web components", | ||
"packageName": "@fluentui/web-components", | ||
"email": "brianbrady@microsoft.com", | ||
"dependentChangeType": "patch" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,126 @@ | ||
# Menu Item | ||
|
||
Menu list item options displayed in a Menu component. They are invoked when users interact with a button, action, or other control. | ||
|
||
<hr /> | ||
|
||
<br /> | ||
|
||
**Remaining work items** | ||
|
||
1. Ensure divider component is styled appropriately in the context of a Menu | ||
2. Create support for menu item "grouping" | ||
3. Split button variation | ||
|
||
<br /> | ||
<hr /> | ||
<br /> | ||
|
||
## Design Spec | ||
|
||
[Link to Menu Item Design Spec in Figma](https://www.figma.com/file/jFWrkFq61GDdOhPlsz6AtX/Menu?node-id=1528%3A5102&t=XtW4laeEzgVFIl1E-0) | ||
|
||
<br /> | ||
<hr /> | ||
<br /> | ||
|
||
## Engineering Spec | ||
|
||
Fluent WC3 Menu extends from the FAST Menu [FAST Menu Item](https://explore.fast.design/components/fast-menu) and is intended to be as close to the Fluent UI React 9 Menu implementation as possible. However, due to the nature of web components there will not be 100% parity between the two. | ||
|
||
<br /> | ||
|
||
### Inputs | ||
|
||
- `role` - an enum representing the menu items' role | ||
- `menuitem` | ||
- `menuitemcheckbox` | ||
- `menuitemradio` | ||
- `disabled` - the menu item is disabled | ||
- `checked` - sets the checked value for menuitemcheckbox or menuitemradio items | ||
|
||
### Outputs | ||
|
||
- none | ||
|
||
### Events | ||
|
||
- `click` (event) - event for when the item has been clicked or invoked via keyboard | ||
- `change` (event) - event for when the item has been clicked or invoked via keyboard, and will be prevented if the menu item is disabled | ||
- `expanded-change` (event) - event for when the item has been expanded or collapsed | ||
|
||
### Slots | ||
|
||
- `before` - slot which precedes content | ||
- `default` - slot for the content (the default slot for the item) | ||
- `after` - slot which comes after content | ||
- `submenu` - the slot used to generate a submenu | ||
- `radio-indicator` - slot for radio item selection indicator | ||
- `checkbox-indicator` - slot for the checkbox selection indicator | ||
- `expand-collapse-glyph` - slot for the expand/collapse glyph for nested menus | ||
|
||
### CSS Variables | ||
|
||
- `borderRadiusMedium` | ||
- `colorCompoundBrandForeground1Hover` | ||
- `colorCompoundBrandForeground1Pressed` | ||
- `colorNeutralBackground1` | ||
- `colorNeutralBackground1Hover` | ||
- `colorNeutralBackground1Pressed` | ||
- `colorNeutralBackgroundDisabled` | ||
- `colorNeutralForeground2` | ||
- `colorNeutralForeground2Hover` | ||
- `colorNeutralForeground2Pressed` | ||
- `colorNeutralForeground3` | ||
- `colorNeutralForegroundDisabled` | ||
- `colorNeutralStrokeDisabled` | ||
- `fontFamilyBase` | ||
- `fontSizeBase200` | ||
- `fontSizeBase300` | ||
- `fontWeightRegular` | ||
- `fontWeightSemibold` | ||
- `lineHeightBase200` | ||
- `lineHeightBase300` | ||
|
||
<br /> | ||
<hr /> | ||
<br /> | ||
|
||
## Accessibility | ||
|
||
<br /> | ||
|
||
**ARIA Attributes** | ||
|
||
| Attribute | Options | Description | | ||
| ------------- | --------------------------------------------------- | --------------------------------------------------------------------------------------------------- | | ||
| aria-checked | boolean | | ||
| aria-disabled | boolean | indicates that the element is perceivable but disabled, so it is not editable or otherwise operable | | ||
| role | `menuitem` \| `menuitemcheckbox` \| `menuitemradio` | an enum representing the menu items' role | | ||
|
||
<hr /> | ||
<br /> | ||
|
||
## Preparation | ||
|
||
<br /> | ||
|
||
### **Fluent Web Component v3 v.s Fluent React 9** | ||
|
||
Due to the nature of Web Components there will not be 100% parity between component implementation in Fluent UI React v9 and Fluent Web Components v3. | ||
|
||
<br /> | ||
|
||
**Component, Slot, and Attribute Mapping** | ||
Component, Slot, or Attribute | Fluent React v9 | Fluent Web Components v3 | | ||
---------------------------------| ---------------------| ---------------------------| | ||
Menu | `<Menu>` | `<fluent-menu>` | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
Menu item |`<MenuItem>` | `<fluent-menu-item>` | | ||
Menu item with radio | `<MenuItemRadio>` | `<fluent-menu-item role="menuitemcheckbox">..` | | ||
Menu item with checkbox | `<MenuItemCheckbox>` | `<fluent-menu-item role="menuitemcheckbox">..` | | ||
Icons | `<MenuItem icon={<MyIcon />}>` | `<slot name ="start">..` <br /> `<slot name="end">..`| | ||
Menu group header | `<MenuGroupHeader>` | `<fluent-menu-item class="header">`| | ||
|
||
**Additional Deltas** | ||
|
||
In order for icons to render with appropriate styles the `icons` attribute must be present on the Menu. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import { FluentDesignSystem } from '../fluent-design-system.js'; | ||
import { definition } from './menu-item.definition.js'; | ||
|
||
definition.define(FluentDesignSystem.registry); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
export * from './menu-item.js'; | ||
export { template as MenuItemTemplate } from './menu-item.template.js'; | ||
export { styles as MenuItemStyles } from './menu-item.styles.js'; | ||
export { definition as MenuItemDefinition } from './menu-item.definition.js'; |
19 changes: 19 additions & 0 deletions
19
packages/web-components/src/menu-item/menu-item.definition.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { FluentDesignSystem } from '../fluent-design-system.js'; | ||
import { MenuItem } from './menu-item.js'; | ||
import { styles } from './menu-item.styles.js'; | ||
import { template } from './menu-item.template.js'; | ||
|
||
/** | ||
* The Fluent Menu Item Element. Implements {@link @microsoft/fast-foundation#MenuItem }, | ||
* {@link @microsoft/fast-foundation#menuItemTemplate} | ||
* | ||
* | ||
* @public | ||
* @remarks | ||
* HTML Element: <fluent-menu-item> | ||
*/ | ||
export const definition = MenuItem.compose({ | ||
name: `${FluentDesignSystem.prefix}-menu-item`, | ||
template, | ||
styles, | ||
}); |
204 changes: 204 additions & 0 deletions
204
packages/web-components/src/menu-item/menu-item.styles.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,204 @@ | ||
import { css } from '@microsoft/fast-element'; | ||
import { display } from '@microsoft/fast-foundation'; | ||
import { | ||
borderRadiusMedium, | ||
colorCompoundBrandForeground1Hover, | ||
colorCompoundBrandForeground1Pressed, | ||
colorNeutralBackground1, | ||
colorNeutralBackground1Hover, | ||
colorNeutralBackground1Selected, | ||
colorNeutralBackgroundDisabled, | ||
colorNeutralForeground2, | ||
colorNeutralForeground2Hover, | ||
colorNeutralForeground2Pressed, | ||
colorNeutralForeground3, | ||
colorNeutralForegroundDisabled, | ||
colorNeutralStrokeDisabled, | ||
fontFamilyBase, | ||
fontSizeBase200, | ||
fontSizeBase300, | ||
fontSizeBase500, | ||
fontWeightRegular, | ||
lineHeightBase200, | ||
lineHeightBase300, | ||
} from '../theme/design-tokens.js'; | ||
|
||
/** Menu styles | ||
* @public | ||
*/ | ||
export const styles = css` | ||
brianchristopherbrady marked this conversation as resolved.
Show resolved
Hide resolved
|
||
${display('grid')} | ||
|
||
:host { | ||
grid-template-columns: 20px 20px auto 20px; | ||
align-items: center; | ||
grid-gap: 4px; | ||
height: 32px; | ||
background: ${colorNeutralBackground1}; | ||
font: ${fontWeightRegular} ${fontSizeBase300} / ${lineHeightBase300} ${fontFamilyBase}; | ||
border-radius: ${borderRadiusMedium}; | ||
color: ${colorNeutralForeground2}; | ||
padding: 0 10px; | ||
cursor: pointer; | ||
overflow: visible; | ||
contain: layout; | ||
} | ||
|
||
:host(:hover) { | ||
background: ${colorNeutralBackground1Hover}; | ||
} | ||
|
||
.content { | ||
white-space: nowrap; | ||
flex-grow: 1; | ||
grid-column: auto / span 2; | ||
padding: 0 2px; | ||
} | ||
|
||
.checkbox, | ||
.radio { | ||
display: none; | ||
} | ||
|
||
.input-container, | ||
.expand-collapse-glyph-container, | ||
::slotted([slot='start']), | ||
::slotted([slot='end']), | ||
:host([checked]) .checkbox, | ||
:host([checked]) .radio { | ||
display: inline-flex; | ||
justify-content: center; | ||
align-items: center; | ||
color: ${colorNeutralForeground2}; | ||
} | ||
|
||
.expand-collapse-glyph-container, | ||
::slotted([slot='start']), | ||
::slotted([slot='end']) { | ||
height: 32px; | ||
font-size: ${fontSizeBase500}; | ||
width: fit-content; | ||
} | ||
|
||
.input-container { | ||
width: 20px; | ||
} | ||
|
||
::slotted([slot='end']) { | ||
color: ${colorNeutralForeground3}; | ||
font: ${fontWeightRegular} ${fontSizeBase200} / ${lineHeightBase200} ${fontFamilyBase}; | ||
white-space: nowrap; | ||
grid-column: 4 / span 1; | ||
justify-self: flex-end; | ||
} | ||
|
||
.expand-collapse-glyph-container { | ||
grid-column: 4 / span 1; | ||
justify-self: flex-end; | ||
} | ||
|
||
:host(:hover) .input-container, | ||
:host(:hover) .expand-collapse-glyph-container, | ||
:host(:hover) .content { | ||
color: ${colorNeutralForeground2Hover}; | ||
} | ||
|
||
:host([icon]:hover) ::slotted([slot='start']) { | ||
color: ${colorCompoundBrandForeground1Hover}; | ||
} | ||
|
||
:host(:active) { | ||
background-color: ${colorNeutralBackground1Selected}; | ||
} | ||
|
||
:host(:active) .input-container, | ||
:host(:active) .expand-collapse-glyph-container, | ||
:host(:active) .content { | ||
color: ${colorNeutralForeground2Pressed}; | ||
} | ||
|
||
:host(:active) ::slotted([slot='start']) { | ||
color: ${colorCompoundBrandForeground1Pressed}; | ||
} | ||
|
||
:host([disabled]) { | ||
background-color: ${colorNeutralBackgroundDisabled}; | ||
} | ||
|
||
:host([disabled]) .content, | ||
:host([disabled]) .expand-collapse-glyph-container, | ||
:host([disabled]) ::slotted([slot='end']), | ||
:host([disabled]) ::slotted([slot='start']) { | ||
color: ${colorNeutralForegroundDisabled}; | ||
} | ||
|
||
:host([data-indent]) { | ||
display: grid; | ||
} | ||
|
||
:host([data-indent='1']) .content { | ||
grid-column: 2 / span 1; | ||
} | ||
|
||
:host([data-indent='1'][role='menuitemcheckbox']) { | ||
display: grid; | ||
} | ||
|
||
:host([data-indent='2'][aria-haspopup='menu']) ::slotted([slot='end']) { | ||
grid-column: 4 / span 1; | ||
} | ||
|
||
:host([data-indent='2'][aria-haspopup='menu']) .expand-collapse-glyph-container { | ||
grid-column: 5 / span 1; | ||
} | ||
|
||
:host([data-indent='1']) .content { | ||
grid-column: 2 / span 1; | ||
} | ||
|
||
:host([data-indent='1'][role='menuitemcheckbox']) .content, | ||
:host([data-indent='1'][role='menuitemradio']) .content { | ||
grid-column: auto / span 1; | ||
} | ||
|
||
:host([icon]) ::slotted([slot='end']), | ||
:host([data-indent='1']) ::slotted([slot='end']) { | ||
grid-column: 4 / span 1; | ||
justify-self: flex-end; | ||
} | ||
|
||
:host([data-indent='2']) { | ||
display: grid; | ||
grid-template-columns: 20px 20px auto auto; | ||
} | ||
|
||
:host([data-indent='2']) .content { | ||
grid-column: 3 / span 1; | ||
} | ||
|
||
:host([data-indent='2']) .input-container { | ||
grid-column: 1 / span 1; | ||
} | ||
|
||
:host([data-indent='2']) ::slotted([slot='start']) { | ||
grid-column: 2 / span 1; | ||
} | ||
|
||
:host([aria-haspopup='menu']) { | ||
grid-template-columns: 20px auto auto 20px; | ||
} | ||
|
||
:host([data-indent='2'][aria-haspopup='menu']) { | ||
grid-template-columns: 20px 20px auto auto 20px; | ||
} | ||
|
||
:host([aria-haspopup='menu']) ::slotted([slot='end']) { | ||
grid-column: 3 / span 1; | ||
justify-self: flex-end; | ||
} | ||
|
||
:host([data-indent='2'][aria-haspopup='menu']) ::slotted([slot='end']) { | ||
grid-column: 4 / span 1; | ||
justify-self: flex-end; | ||
} | ||
`; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are still valid, create tracking issues, with Fluent UI WC (v3) tag.
fwiw, FAST already supports grouping by using a divider item between groups. Do we want to achieve parity with FUIR9 which uses
name
for the groups or are we OK with the difference?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 (divider). This has been confirmed the divider is being used in the storybook
Issue #27042: Menu Closing Behavior and Support for Menu Grouping, Header, and Split Button to MenuItem Component