Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add "style" to exports field #27274

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

layershifter
Copy link
Member

Previous Behavior

@import "@fluentui/react-theme-sass";

Throws 💣

File: /test-scss/styles.scss:1:9
  Error: Can't find stylesheet to import.
    ╷
  1 │ @import "~@fluentui/react-theme-sass";
    │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    styles.scss 1:9  root stylesheet

New Behavior

@import "@fluentui/react-theme-sass";

Works fine ✅

Tested in Create React App & Vite.

Related Issue(s)

Fixes #26847.

@layershifter layershifter marked this pull request as ready for review March 21, 2023 14:52
@layershifter layershifter requested a review from a team as a code owner March 21, 2023 14:52
@fabricteam
Copy link
Collaborator

fabricteam commented Mar 21, 2023

📊 Bundle size report

🤖 This report was generated against 8b3c1619b483d19e4d3a0e4c30b03cb2ab055467

@size-auditor
Copy link

size-auditor bot commented Mar 21, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8b3c1619b483d19e4d3a0e4c30b03cb2ab055467 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 21, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a9964c3:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@layershifter layershifter requested a review from Hotell April 11, 2023 08:44
@layershifter layershifter disabled auto-merge April 11, 2023 08:44
@layershifter layershifter merged commit 45cb608 into microsoft:master Apr 12, 2023
@layershifter layershifter deleted the fix/sass-import branch April 12, 2023 09:14
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 13, 2023
…t/drawer-light-dismiss-prop

* marcosmoura/feat/drawer-component: (51 commits)
  fix: upgrade react-dialog
  Doc: Add/Remove TreeItem and useFlatTree stories (microsoft#27515)
  applying package updates
  Fix accessibility labels for tree stories (microsoft#27443)
  fix: BasePickerListBelow aria-describedby with values (microsoft#27525)
  chore: Remove deprecated InputField, etc. shim components (microsoft#27492)
  [Feature]: allow aria-description attribute on v9 (microsoft#27478)
  feat(react-jsx-runtime): implements custom JSX pragma (microsoft#27472)
  chore: update generator to include "test-ssr" script (microsoft#27463)
  applying package updates
  fix: add "style" to exports field (microsoft#27274)
  applying package updates
  feat(react-datepicker-compat): Make package public (microsoft#27524)
  fix: react-combobox defines fallbackPositions for popup on small screens (microsoft#27521)
  fix: use tabster to focus on trigger, instead of manually invoking .focus (microsoft#27512)
  add cxe-red to react-shared-context ownership (microsoft#27296)
  docs: add props tables for all exported Popover controls (microsoft#27503)
  fix: Update FormFieldShim to work with Field context changes (microsoft#27436)
  Fix wrong state narration for multiple selected legends (microsoft#27429)
  add codeowners to theme designer v9 (microsoft#27311)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot import tokens from @fluentui/react-theme-sass
5 participants