fix: react-combobox defines fallbackPositions for popup on small screens #27521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 442b3b3:
|
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 108 | 113 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 704 | 674 | 5000 | |
| Button | mount | 374 | 380 | 5000 | |
| Field | mount | 1262 | 1255 | 5000 | |
| FluentProvider | mount | 883 | 889 | 5000 | |
| FluentProviderWithTheme | mount | 116 | 118 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 93 | 96 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 108 | 113 | 10 | Possible regression |
| InfoButton | mount | 21 | 18 | 5000 | |
| MakeStyles | mount | 1123 | 1148 | 50000 | |
| Persona | mount | 1993 | 1940 | 5000 | |
| SpinButton | mount | 1576 | 1585 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 841ea75d516d85b88eb826030718c19c3239ee4d (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
change/@fluentui-react-combobox-c627d0c3-82f4-4593-8a10-546a41227e16.json
Outdated
Show resolved
Hide resolved
micahgodbolt
approved these changes
Apr 11, 2023
Co-authored-by: Micah Godbolt <micahgodbolt@gmail.com>
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 13, 2023
…t/drawer-light-dismiss-prop * marcosmoura/feat/drawer-component: (51 commits) fix: upgrade react-dialog Doc: Add/Remove TreeItem and useFlatTree stories (microsoft#27515) applying package updates Fix accessibility labels for tree stories (microsoft#27443) fix: BasePickerListBelow aria-describedby with values (microsoft#27525) chore: Remove deprecated InputField, etc. shim components (microsoft#27492) [Feature]: allow aria-description attribute on v9 (microsoft#27478) feat(react-jsx-runtime): implements custom JSX pragma (microsoft#27472) chore: update generator to include "test-ssr" script (microsoft#27463) applying package updates fix: add "style" to exports field (microsoft#27274) applying package updates feat(react-datepicker-compat): Make package public (microsoft#27524) fix: react-combobox defines fallbackPositions for popup on small screens (microsoft#27521) fix: use tabster to focus on trigger, instead of manually invoking .focus (microsoft#27512) add cxe-red to react-shared-context ownership (microsoft#27296) docs: add props tables for all exported Popover controls (microsoft#27503) fix: Update FormFieldShim to work with Field context changes (microsoft#27436) Fix wrong state narration for multiple selected legends (microsoft#27429) add codeowners to theme designer v9 (microsoft#27311) ...
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
When the listbox popup doesn't fit below or above the trigger, it doesn't try left/right positions.
New Behavior
Adds before & after fallbackPositions, so now the popup will attempt to position itself first after, then before the trigger (after below & above).
Related Issue(s)