Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v8): explicitly publish dist folder after node 16 upgrade #27769

Merged
merged 4 commits into from
May 5, 2023
Merged

fix(v8): explicitly publish dist folder after node 16 upgrade #27769

merged 4 commits into from
May 5, 2023

Conversation

TristanWatanabe
Copy link
Member

Changes

  • Previous versions of v8 packages published the dist/ folder prior to the node16 upgrade. This PR will now explicitly ship the dist/ folder

Related Issue(s)

@github-actions github-actions bot added this to the May Project Cycle Q2 2023 milestone May 5, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 19bbbdf:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented May 5, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 048e93f6e918778673d196a6084ad2bfa872d5e7 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ReactionMinimalPerf.default 277 259 1.07:1
LabelMinimalPerf.default 286 269 1.06:1
SkeletonMinimalPerf.default 256 242 1.06:1
TableMinimalPerf.default 311 293 1.06:1
AlertMinimalPerf.default 197 189 1.04:1
AvatarMinimalPerf.default 135 131 1.03:1
DropdownManyItemsPerf.default 504 488 1.03:1
FlexMinimalPerf.default 202 197 1.03:1
GridMinimalPerf.default 247 239 1.03:1
MenuMinimalPerf.default 640 620 1.03:1
IconMinimalPerf.default 470 457 1.03:1
CarouselMinimalPerf.default 349 341 1.02:1
DialogMinimalPerf.default 584 572 1.02:1
LayoutMinimalPerf.default 262 258 1.02:1
PopupMinimalPerf.default 453 444 1.02:1
CustomToolbarPrototype.default 1907 1871 1.02:1
TooltipMinimalPerf.default 1685 1657 1.02:1
AnimationMinimalPerf.default 372 369 1.01:1
AttachmentSlotsPerf.default 841 833 1.01:1
ChatMinimalPerf.default 533 528 1.01:1
CheckboxMinimalPerf.default 1575 1557 1.01:1
DropdownMinimalPerf.default 1839 1813 1.01:1
EmbedMinimalPerf.default 2413 2388 1.01:1
InputMinimalPerf.default 724 720 1.01:1
ItemLayoutMinimalPerf.default 906 901 1.01:1
ListNestedPerf.default 412 408 1.01:1
LoaderMinimalPerf.default 242 240 1.01:1
MenuButtonMinimalPerf.default 1271 1258 1.01:1
ProviderMergeThemesPerf.default 967 954 1.01:1
ProviderMinimalPerf.default 277 275 1.01:1
RadioGroupMinimalPerf.default 333 330 1.01:1
AttachmentMinimalPerf.default 100 100 1:1
BoxMinimalPerf.default 252 252 1:1
ButtonOverridesMissPerf.default 823 823 1:1
ButtonSlotsPerf.default 410 408 1:1
DatepickerMinimalPerf.default 4533 4554 1:1
DividerMinimalPerf.default 261 260 1:1
FormMinimalPerf.default 277 277 1:1
ListCommonPerf.default 490 492 1:1
ListMinimalPerf.default 382 383 1:1
PortalMinimalPerf.default 116 116 1:1
SliderMinimalPerf.default 906 908 1:1
SplitButtonMinimalPerf.default 3042 3035 1:1
StatusMinimalPerf.default 506 507 1:1
TableManyItemsPerf.default 1434 1441 1:1
TextAreaMinimalPerf.default 350 349 1:1
ToolbarMinimalPerf.default 663 664 1:1
TreeWith60ListItems.default 105 105 1:1
AccordionMinimalPerf.default 104 105 0.99:1
ButtonMinimalPerf.default 103 104 0.99:1
ChatDuplicateMessagesPerf.default 187 189 0.99:1
ChatWithPopoverPerf.default 242 245 0.99:1
HeaderMinimalPerf.default 260 263 0.99:1
HeaderSlotsPerf.default 584 587 0.99:1
ImageMinimalPerf.default 277 281 0.99:1
RefMinimalPerf.default 142 143 0.99:1
ListWith60ListItems.default 466 476 0.98:1
RosterPerf.default 1805 1844 0.98:1
SegmentMinimalPerf.default 248 253 0.98:1
TreeMinimalPerf.default 587 596 0.98:1
VideoMinimalPerf.default 512 524 0.98:1
CardMinimalPerf.default 375 388 0.97:1
TextMinimalPerf.default 241 249 0.97:1

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 048e93f6e918778673d196a6084ad2bfa872d5e7

@fabricteam
Copy link
Collaborator

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 827 857 5000
Breadcrumb mount 2523 2542 1000
Checkbox mount 2282 2236 5000
CheckboxBase mount 1954 1982 5000
ChoiceGroup mount 3797 3870 5000
ComboBox mount 935 925 1000
CommandBar mount 9110 9092 1000
ContextualMenu mount 29219 30848 1000
DefaultButton mount 1021 1081 5000
DetailsRow mount 2951 2966 5000
DetailsRowFast mount 3016 2992 5000
DetailsRowNoStyles mount 2750 2765 5000
Dialog mount 3610 3718 1000
DocumentCardTitle mount 351 353 1000
Dropdown mount 2644 2640 5000
FocusTrapZone mount 1535 1584 5000
FocusZone mount 1521 1510 5000
GroupedList mount 55712 64954 2
GroupedList virtual-rerender 26605 26757 2
GroupedList virtual-rerender-with-unmount 85934 79759 2
GroupedListV2 mount 355 355 2
GroupedListV2 virtual-rerender 321 328 2
GroupedListV2 virtual-rerender-with-unmount 361 347 2
IconButton mount 1459 1453 5000
Label mount 484 492 5000
Layer mount 3803 3729 5000
Link mount 552 550 5000
MenuButton mount 1269 1269 5000
MessageBar mount 29917 29138 5000
Nav mount 2629 2619 1000
OverflowSet mount 1076 1049 5000
Panel mount 2319 2321 1000
Persona mount 1025 1025 1000
Pivot mount 1238 1230 1000
PrimaryButton mount 1125 1125 5000
Rating mount 5979 5891 5000
SearchBox mount 1231 1212 5000
Shimmer mount 2517 2474 5000
Slider mount 1819 1783 5000
SpinButton mount 3827 3836 5000
Spinner mount 551 559 5000
SplitButton mount 2458 2508 5000
Stack mount 553 550 5000
StackWithIntrinsicChildren mount 1166 1177 5000
StackWithTextChildren mount 3278 3283 5000
SwatchColorPicker mount 8383 8488 5000
TagPicker mount 2037 2091 5000
Text mount 514 529 5000
TextField mount 1239 1233 5000
ThemeProvider mount 1178 1165 5000
ThemeProvider virtual-rerender 799 809 5000
ThemeProvider virtual-rerender-with-unmount 1820 1842 5000
Toggle mount 831 829 5000
buttonNative mount 305 302 5000

@TristanWatanabe TristanWatanabe marked this pull request as ready for review May 5, 2023 12:53
Hotell
Hotell reviewed May 5, 2023
View reviewed changes
packages/common-styles/.npmignore
@@ -29,3 +29,8 @@ tsd.json
tslint.json
typings
visualtests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package will also ship /src

image

looking at some older version it seems to be expected https://unpkg.com/browse/@fluentui/common-styles@1.2.7/src/ 👀

Hotell
Hotell approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi: we have also migration generator for v8, would make sense to update it and use next time

https://github.com/microsoft/fluentui/tree/master/tools/generators/migrate-v8-pkg

@Hotell Hotell merged commit 0475089 into microsoft:master May 5, 2023
@Hotell
Copy link
Contributor

Hotell commented May 5, 2023

admin merged - approvals from v-build + pipeline is passing

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/merge-styles@v8.5.10 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/jest-serializer-merge-styles@v8.0.27 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-experiments@v8.14.78 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/keyboard-key@v0.4.9 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-charting@v5.16.27 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-docsite-components@v8.12.7 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/monaco-editor@v1.3.9 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-monaco-editor@v1.7.84 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-icon-provider@v1.3.38 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-file-type-icons@v8.8.17 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-date-time@v8.7.83 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/azure-themes@v8.6.3 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/set-version@v8.2.9 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-focus@v8.8.23 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-hooks@v8.6.24 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/common-styles@v1.2.26 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/theme-samples@v8.7.83 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react@v8.109.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-icons-mdl2-branded@v1.2.42 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/webpack-utilities@v8.1.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/theme@v2.6.29 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-window-provider@v2.2.13 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-icons-mdl2@v1.3.41 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/scheme-utilities@v8.3.30 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/style-utilities@v8.9.10 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/test-utilities@v8.3.4 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/utilities@v8.13.13 has been released which incorporates this pull request.:tada:

Handy links:

marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 10, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-header
a6a3377 
* master:
  feat(react-drawer): create DrawerBody component (microsoft#27581)
  feat(react-tree): TreeItem itemType restructure (microsoft#27799)
  feat: Implement state management for toasts (microsoft#27800)
  bugfix: fix VisibleFlatTreeItemGenerator omitting visible items (microsoft#27802)
  fix: overflowManager should always dispatch initial state (microsoft#27756)
  fix(react-badge): Remove white border around presence badge when on a dark background (microsoft#27780)
  react-tags: rename dismissable to dismissible (microsoft#27798)
  chore: update ownership of react-tags (microsoft#27795)
  applying package updates
  feat(react-tags): Replace `avatar` prop with `media`; polish styles for spacing (microsoft#27725)
  RFC appearance migration (microsoft#24181)
  chore(react-skeleton): Release react-skeleton to stable (microsoft#27767)
  fix(Coachmark): Remove positioning regression and update bounds on resize (microsoft#27782)
  applying package updates
  fix(v8): explicitly publish dist folder after node 16 upgrade (microsoft#27769)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 10, 2023
@marcosmoura
Merge branch 'feat/drawer-header' into feat/split-drawer
8c3385f 
* feat/drawer-header:
  fix: add changefiles
  feat(react-drawer): create DrawerBody component (microsoft#27581)
  feat(react-tree): TreeItem itemType restructure (microsoft#27799)
  feat: Implement state management for toasts (microsoft#27800)
  bugfix: fix VisibleFlatTreeItemGenerator omitting visible items (microsoft#27802)
  fix: overflowManager should always dispatch initial state (microsoft#27756)
  fix(react-badge): Remove white border around presence badge when on a dark background (microsoft#27780)
  react-tags: rename dismissable to dismissible (microsoft#27798)
  chore: update ownership of react-tags (microsoft#27795)
  applying package updates
  feat(react-tags): Replace `avatar` prop with `media`; polish styles for spacing (microsoft#27725)
  RFC appearance migration (microsoft#24181)
  chore(react-skeleton): Release react-skeleton to stable (microsoft#27767)
  fix(Coachmark): Remove positioning regression and update bounds on resize (microsoft#27782)
  applying package updates
  fix(v8): explicitly publish dist folder after node 16 upgrade (microsoft#27769)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 10, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-footer
ab506e5 
* master: (29 commits)
  feat(react-drawer): create DrawerBody component (microsoft#27581)
  feat(react-tree): TreeItem itemType restructure (microsoft#27799)
  feat: Implement state management for toasts (microsoft#27800)
  bugfix: fix VisibleFlatTreeItemGenerator omitting visible items (microsoft#27802)
  fix: overflowManager should always dispatch initial state (microsoft#27756)
  fix(react-badge): Remove white border around presence badge when on a dark background (microsoft#27780)
  react-tags: rename dismissable to dismissible (microsoft#27798)
  chore: update ownership of react-tags (microsoft#27795)
  applying package updates
  feat(react-tags): Replace `avatar` prop with `media`; polish styles for spacing (microsoft#27725)
  RFC appearance migration (microsoft#24181)
  chore(react-skeleton): Release react-skeleton to stable (microsoft#27767)
  fix(Coachmark): Remove positioning regression and update bounds on resize (microsoft#27782)
  applying package updates
  fix(v8): explicitly publish dist folder after node 16 upgrade (microsoft#27769)
  applying package updates
  fix: do not use outlineStyle: none in createCustomFocusIndicatorStyle (microsoft#26089)
  fix: Scale pulse animation with percentages and flip wave animation's direction (microsoft#27654)
  Publish dist folder that got removed due to node 16 upgrade (microsoft#27764)
  fix(scripts-update-release-notes): properly handle git for-each-ref cmd call to not fail release notes update (microsoft#27757)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hotell Hotell Hotell approved these changes

@ling1726 ling1726 ling1726 approved these changes

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT GeoffCoxMSFT is a code owner

@khmakoto khmakoto Awaiting requested review from khmakoto khmakoto is a code owner

@dzearing dzearing Awaiting requested review from dzearing dzearing is a code owner

@Jahnp Jahnp Awaiting requested review from Jahnp Jahnp is a code owner

@bigbadcapers bigbadcapers Awaiting requested review from bigbadcapers bigbadcapers is a code owner

@Jacqueline-ms Jacqueline-ms Awaiting requested review from Jacqueline-ms Jacqueline-ms is a code owner

@robtaft-ms robtaft-ms Awaiting requested review from robtaft-ms

Assignees

@bsunderhus bsunderhus

Labels
None yet
Projects
None yet
Milestone
May Project Cycle Q2 2023
Development

Successfully merging this pull request may close these issues.
6 participants
@TristanWatanabe @fabricteam @Hotell @msft-fluent-ui-bot @ling1726 @bsunderhus