fix: BreadcrumbItem should use makeResetStyles for base styles #29278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 62304fb:
|
📊 Bundle size report🤖 This report was generated against a56c408d4ed860a48e22780289e5c4a00ebec6c4 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a56c408d4ed860a48e22780289e5c4a00ebec6c4 (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
marcosmoura
approved these changes
Sep 25, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 26, 2023
* master: fix(react-dialog): use makeResetStyles for base dialog components styles (microsoft#29280) chore(react-tags-preview): update props descriptions (microsoft#29287) chore: bump swc core to mitigate transpilation memory leaks (microsoft#29253) feat: adds customizeSelector to createCustomFocusIndicatorStyle method (microsoft#29209) applying package updates Updated TooltipBestPractices to include accessibility best practices (microsoft#29284) fix: BreadcrumbItem should use makeResetStyles for base styles (microsoft#29278)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
makeStylesdisabledFocusableNew Behavior
BreadcrumbItem uses
makeResetStylesfor base stylesBreadcrumbButton supports
disabledFocusableFixes BreadcrumbItem should use makeResetStyles for base styles #29258