-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated TooltipBestPractices to include new best practices #29284
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3f7c1ec:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one suggestion, otherwise it LGTM!
packages/react-examples/src/react/Tooltip/docs/TooltipBestPractices.md
Outdated
Show resolved
Hide resolved
…tices.md Co-authored-by: Sarah Higley <smhigley@users.noreply.github.com>
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
📊 Bundle size report🤖 This report was generated against 5b6536c989c9ebb2bf4010fbf18dfb50b570b2c6 |
Asset size changesUnable to find bundle size details for Baseline commit: 5b6536c Possible causes
Recommendations
|
* master: fix(react-dialog): use makeResetStyles for base dialog components styles (microsoft#29280) chore(react-tags-preview): update props descriptions (microsoft#29287) chore: bump swc core to mitigate transpilation memory leaks (microsoft#29253) feat: adds customizeSelector to createCustomFocusIndicatorStyle method (microsoft#29209) applying package updates Updated TooltipBestPractices to include accessibility best practices (microsoft#29284) fix: BreadcrumbItem should use makeResetStyles for base styles (microsoft#29278)
Previous Behavior
Tooltip read me best practices did not have guidelines on non-interactive elements.
New Behavior
Tooltip read me best practices now has guidelines on non-interactive elements.
Related Issue(s)