Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated TooltipBestPractices to include new best practices #29284

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

tabithahsia
Copy link
Contributor

@tabithahsia tabithahsia commented Sep 25, 2023

Previous Behavior

Tooltip read me best practices did not have guidelines on non-interactive elements.

New Behavior

Tooltip read me best practices now has guidelines on non-interactive elements.

Related Issue(s)

@tabithahsia tabithahsia marked this pull request as ready for review September 25, 2023 19:41
@tabithahsia tabithahsia requested a review from a team as a code owner September 25, 2023 19:41
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 25, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3f7c1ec:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

Copy link
Contributor

@smhigley smhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one suggestion, otherwise it LGTM!

…tices.md

Co-authored-by: Sarah Higley <smhigley@users.noreply.github.com>
@smhigley smhigley enabled auto-merge (squash) September 25, 2023 20:55
@smhigley
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 5b6536c989c9ebb2bf4010fbf18dfb50b570b2c6

@size-auditor
Copy link

size-auditor bot commented Sep 25, 2023

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 5b6536c

Possible causes

  • The baseline build 5b6536c is broken
  • The Size Auditor run for the baseline build 5b6536c was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@smhigley smhigley merged commit dbf9aca into microsoft:master Sep 25, 2023
23 checks passed
@tabithahsia tabithahsia deleted the tooltipReadmeUpdate branch September 25, 2023 23:32
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 26, 2023
* master:
  fix(react-dialog): use makeResetStyles for base dialog components styles (microsoft#29280)
  chore(react-tags-preview): update props descriptions (microsoft#29287)
  chore: bump swc core to mitigate transpilation memory leaks (microsoft#29253)
  feat: adds customizeSelector to createCustomFocusIndicatorStyle method (microsoft#29209)
  applying package updates
  Updated TooltipBestPractices to include accessibility best practices (microsoft#29284)
  fix: BreadcrumbItem should use makeResetStyles for base styles (microsoft#29278)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing accessibility best practices information for Tooltip on non-focusable UI
4 participants