Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to nx 19.2.3 #31828

Merged
merged 3 commits into from
Jul 2, 2024
Merged

chore: migrate to nx 19.2.3 #31828

merged 3 commits into from
Jul 2, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 26, 2024 •
edited
Loading

Previous Behavior

New Behavior

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Jun 26, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 26, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

fabricteam
fabricteam reviewed Jun 26, 2024
View reviewed changes
.gitignore Show resolved Hide resolved
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 26, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
InputMinimalPerf.default 533 523 1.02:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 96 80 1.2:1
AccordionMinimalPerf.default 93 78 1.19:1
BoxMinimalPerf.default 214 189 1.13:1
AttachmentMinimalPerf.default 87 78 1.12:1
DividerMinimalPerf.default 219 198 1.11:1
VideoMinimalPerf.default 460 423 1.09:1
CardMinimalPerf.default 329 305 1.08:1
FormMinimalPerf.default 231 214 1.08:1
ButtonMinimalPerf.default 93 88 1.06:1
LoaderMinimalPerf.default 198 186 1.06:1
PortalMinimalPerf.default 88 84 1.05:1
CheckboxMinimalPerf.default 1156 1116 1.04:1
GridMinimalPerf.default 197 189 1.04:1
ListMinimalPerf.default 319 306 1.04:1
RefMinimalPerf.default 115 111 1.04:1
AttachmentSlotsPerf.default 635 616 1.03:1
ButtonOverridesMissPerf.default 655 638 1.03:1
DialogMinimalPerf.default 446 434 1.03:1
EmbedMinimalPerf.default 1883 1836 1.03:1
HeaderMinimalPerf.default 212 206 1.03:1
LayoutMinimalPerf.default 212 205 1.03:1
ListNestedPerf.default 328 319 1.03:1
ListWith60ListItems.default 376 366 1.03:1
RosterPerf.default 1619 1570 1.03:1
TableManyItemsPerf.default 1123 1089 1.03:1
DropdownManyItemsPerf.default 396 389 1.02:1
DropdownMinimalPerf.default 1449 1421 1.02:1
MenuMinimalPerf.default 514 504 1.02:1
SegmentMinimalPerf.default 201 198 1.02:1
SplitButtonMinimalPerf.default 2310 2272 1.02:1
IconMinimalPerf.default 391 384 1.02:1
TableMinimalPerf.default 242 237 1.02:1
TreeMinimalPerf.default 488 477 1.02:1
ChatDuplicateMessagesPerf.default 154 152 1.01:1
HeaderSlotsPerf.default 463 457 1.01:1
ImageMinimalPerf.default 224 222 1.01:1
ItemLayoutMinimalPerf.default 706 701 1.01:1
LabelMinimalPerf.default 225 222 1.01:1
ProviderMergeThemesPerf.default 653 647 1.01:1
SkeletonMinimalPerf.default 198 196 1.01:1
StatusMinimalPerf.default 401 399 1.01:1
CustomToolbarPrototype.default 1476 1462 1.01:1
ButtonSlotsPerf.default 322 322 1:1
ChatWithPopoverPerf.default 192 192 1:1
MenuButtonMinimalPerf.default 953 956 1:1
RadioGroupMinimalPerf.default 262 263 1:1
ReactionMinimalPerf.default 218 219 1:1
ToolbarMinimalPerf.default 546 545 1:1
ListCommonPerf.default 380 384 0.99:1
PopupMinimalPerf.default 348 352 0.99:1
ProviderMinimalPerf.default 196 198 0.99:1
TooltipMinimalPerf.default 1250 1257 0.99:1
AlertMinimalPerf.default 157 161 0.98:1
AvatarMinimalPerf.default 112 114 0.98:1
DatepickerMinimalPerf.default 3531 3601 0.98:1
SliderMinimalPerf.default 716 732 0.98:1
TextMinimalPerf.default 191 194 0.98:1
ChatMinimalPerf.default 430 444 0.97:1
CarouselMinimalPerf.default 256 269 0.95:1
TextAreaMinimalPerf.default 274 289 0.95:1
AnimationMinimalPerf.default 277 296 0.94:1
FlexMinimalPerf.default 151 162 0.93:1

fabricteam
fabricteam reviewed Jun 26, 2024
View reviewed changes
.gitignore Show resolved Hide resolved
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 26, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 26, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 636 645 5000
Breadcrumb mount 1781 1807 1000
Checkbox mount 1712 1736 5000
CheckboxBase mount 1497 1491 5000
ChoiceGroup mount 3036 2999 5000
ComboBox mount 714 686 1000
CommandBar mount 6935 7081 1000
ContextualMenu mount 17398 17356 1000
DefaultButton mount 781 818 5000
DetailsRow mount 2246 2264 5000
DetailsRowFast mount 2263 2258 5000
DetailsRowNoStyles mount 2032 2075 5000
Dialog mount 2740 2768 1000
DocumentCardTitle mount 225 227 1000
Dropdown mount 2000 2000 5000
FocusTrapZone mount 1170 1157 5000
FocusZone mount 1080 1101 5000
GroupedList mount 42999 43184 2
GroupedList virtual-rerender 18403 20871 2
GroupedList virtual-rerender-with-unmount 54073 53852 2
GroupedListV2 mount 236 236 2
GroupedListV2 virtual-rerender 223 226 2
GroupedListV2 virtual-rerender-with-unmount 241 241 2
IconButton mount 1143 1188 5000
Label mount 354 356 5000
Layer mount 2764 2775 5000
Link mount 399 415 5000
MenuButton mount 1007 994 5000
MessageBar mount 22482 22340 5000
Nav mount 2071 2072 1000
OverflowSet mount 809 781 5000
Panel mount 1871 1848 1000
Persona mount 756 772 1000
Pivot mount 933 918 1000
PrimaryButton mount 930 959 5000
Rating mount 4672 4681 5000
SearchBox mount 926 921 5000
Shimmer mount 1909 1918 5000
Slider mount 1368 1374 5000
SpinButton mount 2970 2983 5000
Spinner mount 403 411 5000
SplitButton mount 1867 1870 5000
Stack mount 433 426 5000
StackWithIntrinsicChildren mount 889 882 5000
StackWithTextChildren mount 2790 2740 5000
SwatchColorPicker mount 6391 6461 5000
TagPicker mount 1469 1447 5000
Text mount 402 396 5000
TextField mount 989 953 5000
ThemeProvider mount 882 873 5000
ThemeProvider virtual-rerender 602 581 5000
ThemeProvider virtual-rerender-with-unmount 1315 1329 5000
Toggle mount 628 615 5000
buttonNative mount 192 198 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 28, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 76 73 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 640 636 5000
Button mount 312 306 5000
Field mount 1126 1135 5000
FluentProvider mount 708 702 5000
FluentProviderWithTheme mount 83 90 10
FluentProviderWithTheme virtual-rerender 36 38 10
FluentProviderWithTheme virtual-rerender-with-unmount 76 73 10 Possible regression
MakeStyles mount 866 863 50000
Persona mount 1785 1688 5000
SpinButton mount 1419 1396 5000
SwatchPicker mount 1642 1665 5000

fabricteam
fabricteam reviewed Jun 28, 2024
View reviewed changes
.gitignore Show resolved Hide resolved
@Hotell Hotell marked this pull request as ready for review June 28, 2024 14:27
@Hotell Hotell requested a review from a team as a code owner June 28, 2024 14:27
@Hotell Hotell mentioned this pull request Jul 1, 2024
Merged
@Hotell Hotell merged commit 284ff3c into microsoft:master Jul 2, 2024
21 checks passed
@Hotell Hotell deleted the nx/migrate/19_2 branch July 2, 2024 12:24
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jul 3, 2024
@marcosmoura
Merge branch 'master' into rfc/z-index-handling
1001741 
* master: (45 commits)
  Added unit testcases for sparkline chart. (microsoft#31843)
  release: applying package updates - react v8
  release: applying package updates - web-components
  fix(web-components): fix enterkey interaction on menu (microsoft#31894)
  chore(web-components): expose field to package exports (microsoft#31904)
  fix(web-components): slotted elements within fluent-text-input can't be focused (microsoft#31903)
  fix(web-components): fix menu positioning in firefox (microsoft#31895)
  chore: bump @types/node types to v20 and @tsconfig to v18 (microsoft#31510)
  chore: migrate to nx 19.2.3 (microsoft#31828)
  chore: fix install verdacio command (microsoft#31897)
  fix(scripts-prettier): escape file names that are being passed to prettier bin via shell (microsoft#31889)
  release: applying package updates - react-components
  feat:(docs) Adds pattern doc on Basic Recomposition (microsoft#31861)
  chore:(docs) Archive the wiki 🎉 (microsoft#31202)
  feat:(react-nav-preview) Adds NavDivider implementation (microsoft#31848)
  ci(.github): resolve due_on UTC time creation issues (microsoft#31890)
  release: applying package updates - web-components
  fix: update internal usage of useModalAttributes to use legacyTrapFocus by default (microsoft#31801)
  chore: make utils a package export (microsoft#31865)
  fix: add live region around scroll index update (microsoft#31863)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@dmytrokirpa dmytrokirpa dmytrokirpa approved these changes

Assignees
No one assigned
Labels
NX: core
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@Hotell @fabricteam @dmytrokirpa