Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts-prettier): escape file names that are being passed to prettier bin via shell #31889

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix(scripts-prettier): escape file names that are being passed to prettier bin via shell #31889

merged 1 commit into from
Jul 2, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jul 1, 2024

Previous Behavior

we don't escape special characters when passing file list to prettier bin

New Behavior

we properly escape special characters when passing file list to prettier bin

Related Issue(s)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 70 75 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 619 682 5000
Button mount 297 295 5000
Field mount 1162 1100 5000
FluentProvider mount 721 726 5000
FluentProviderWithTheme mount 80 76 10
FluentProviderWithTheme virtual-rerender 36 39 10
FluentProviderWithTheme virtual-rerender-with-unmount 70 75 10 Possible regression
MakeStyles mount 852 842 50000
Persona mount 1766 1724 5000
SpinButton mount 1367 1412 5000
SwatchPicker mount 1639 1680 5000

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AccordionMinimalPerf.default 80 86 0.93:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FlexMinimalPerf.default 165 148 1.11:1
CarouselMinimalPerf.default 274 250 1.1:1
ButtonMinimalPerf.default 94 86 1.09:1
ChatDuplicateMessagesPerf.default 156 144 1.08:1
ProviderMergeThemesPerf.default 680 638 1.07:1
TextMinimalPerf.default 204 192 1.06:1
BoxMinimalPerf.default 201 191 1.05:1
PortalMinimalPerf.default 88 84 1.05:1
RefMinimalPerf.default 113 108 1.05:1
TableManyItemsPerf.default 1129 1077 1.05:1
VideoMinimalPerf.default 435 413 1.05:1
HeaderSlotsPerf.default 479 461 1.04:1
ImageMinimalPerf.default 221 212 1.04:1
ListCommonPerf.default 398 382 1.04:1
LoaderMinimalPerf.default 192 185 1.04:1
SliderMinimalPerf.default 761 734 1.04:1
TableMinimalPerf.default 233 225 1.04:1
AnimationMinimalPerf.default 305 296 1.03:1
DialogMinimalPerf.default 444 431 1.03:1
DropdownManyItemsPerf.default 391 378 1.03:1
FormMinimalPerf.default 229 223 1.03:1
InputMinimalPerf.default 546 532 1.03:1
LabelMinimalPerf.default 220 213 1.03:1
ProviderMinimalPerf.default 200 194 1.03:1
TextAreaMinimalPerf.default 288 279 1.03:1
TreeMinimalPerf.default 487 475 1.03:1
ChatMinimalPerf.default 438 428 1.02:1
ChatWithPopoverPerf.default 193 189 1.02:1
CheckboxMinimalPerf.default 1155 1136 1.02:1
ItemLayoutMinimalPerf.default 714 703 1.02:1
ListMinimalPerf.default 304 297 1.02:1
SegmentMinimalPerf.default 197 193 1.02:1
AttachmentSlotsPerf.default 642 637 1.01:1
DropdownMinimalPerf.default 1443 1435 1.01:1
HeaderMinimalPerf.default 209 206 1.01:1
ListNestedPerf.default 313 309 1.01:1
MenuButtonMinimalPerf.default 969 961 1.01:1
SkeletonMinimalPerf.default 204 202 1.01:1
CustomToolbarPrototype.default 1466 1455 1.01:1
AttachmentMinimalPerf.default 78 78 1:1
CardMinimalPerf.default 303 304 1:1
LayoutMinimalPerf.default 199 200 1:1
ListWith60ListItems.default 355 355 1:1
RosterPerf.default 1592 1588 1:1
AlertMinimalPerf.default 160 161 0.99:1
AvatarMinimalPerf.default 108 109 0.99:1
DatepickerMinimalPerf.default 3578 3627 0.99:1
PopupMinimalPerf.default 344 346 0.99:1
TreeWith60ListItems.default 82 83 0.99:1
ButtonSlotsPerf.default 306 311 0.98:1
EmbedMinimalPerf.default 1852 1891 0.98:1
GridMinimalPerf.default 180 183 0.98:1
MenuMinimalPerf.default 500 512 0.98:1
RadioGroupMinimalPerf.default 260 266 0.98:1
SplitButtonMinimalPerf.default 2244 2298 0.98:1
StatusMinimalPerf.default 389 397 0.98:1
ButtonOverridesMissPerf.default 645 666 0.97:1
ToolbarMinimalPerf.default 512 530 0.97:1
IconMinimalPerf.default 389 407 0.96:1
TooltipMinimalPerf.default 1232 1287 0.96:1
DividerMinimalPerf.default 194 206 0.94:1
ReactionMinimalPerf.default 206 219 0.94:1

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 622 640 5000
Breadcrumb mount 1697 1671 1000
Checkbox mount 1705 1752 5000
CheckboxBase mount 1492 1480 5000
ChoiceGroup mount 3001 2969 5000
ComboBox mount 710 671 1000
CommandBar mount 6648 6644 1000
ContextualMenu mount 12267 12571 1000
DefaultButton mount 799 808 5000
DetailsRow mount 2240 2242 5000
DetailsRowFast mount 2244 2207 5000
DetailsRowNoStyles mount 2062 2081 5000
Dialog mount 2833 2775 1000
DocumentCardTitle mount 228 219 1000
Dropdown mount 2000 1973 5000
FocusTrapZone mount 1161 1211 5000
FocusZone mount 1087 1077 5000
GroupedList mount 37447 42003 2
GroupedList virtual-rerender 17814 19988 2
GroupedList virtual-rerender-with-unmount 50134 51191 2
GroupedListV2 mount 216 226 2
GroupedListV2 virtual-rerender 208 204 2
GroupedListV2 virtual-rerender-with-unmount 235 219 2
IconButton mount 1129 1135 5000
Label mount 334 340 5000
Layer mount 2713 2749 5000
Link mount 386 392 5000
MenuButton mount 956 1011 5000
MessageBar mount 21091 21193 5000
Nav mount 2034 2029 1000
OverflowSet mount 789 787 5000
Panel mount 1784 1728 1000
Persona mount 724 747 1000
Pivot mount 873 875 1000
PrimaryButton mount 935 943 5000
Rating mount 4582 4607 5000
SearchBox mount 928 936 5000
Shimmer mount 1927 1940 5000
Slider mount 1354 1325 5000
SpinButton mount 2926 3020 5000
Spinner mount 394 391 5000
SplitButton mount 1880 1827 5000
Stack mount 420 418 5000
StackWithIntrinsicChildren mount 884 915 5000
StackWithTextChildren mount 2733 2811 5000
SwatchColorPicker mount 6406 6340 5000
TagPicker mount 1455 1480 5000
Text mount 383 384 5000
TextField mount 924 958 5000
ThemeProvider mount 838 859 5000
ThemeProvider virtual-rerender 580 592 5000
ThemeProvider virtual-rerender-with-unmount 1274 1283 5000
Toggle mount 602 596 5000
buttonNative mount 185 186 5000

@Hotell Hotell marked this pull request as ready for review July 1, 2024 11:38
@Hotell Hotell requested a review from a team as a code owner July 1, 2024 11:38
@github-actions github-actions bot added this to the July Project Cycle Q3 2024 milestone Jul 1, 2024
@Hotell Hotell merged commit 88db367 into microsoft:master Jul 2, 2024
21 checks passed
@Hotell Hotell deleted the scripts/prettier/fix/escaping-files branch July 2, 2024 07:29
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jul 3, 2024
@marcosmoura
Merge branch 'master' into rfc/z-index-handling
1001741 
* master: (45 commits)
  Added unit testcases for sparkline chart. (microsoft#31843)
  release: applying package updates - react v8
  release: applying package updates - web-components
  fix(web-components): fix enterkey interaction on menu (microsoft#31894)
  chore(web-components): expose field to package exports (microsoft#31904)
  fix(web-components): slotted elements within fluent-text-input can't be focused (microsoft#31903)
  fix(web-components): fix menu positioning in firefox (microsoft#31895)
  chore: bump @types/node types to v20 and @tsconfig to v18 (microsoft#31510)
  chore: migrate to nx 19.2.3 (microsoft#31828)
  chore: fix install verdacio command (microsoft#31897)
  fix(scripts-prettier): escape file names that are being passed to prettier bin via shell (microsoft#31889)
  release: applying package updates - react-components
  feat:(docs) Adds pattern doc on Basic Recomposition (microsoft#31861)
  chore:(docs) Archive the wiki 🎉 (microsoft#31202)
  feat:(react-nav-preview) Adds NavDivider implementation (microsoft#31848)
  ci(.github): resolve due_on UTC time creation issues (microsoft#31890)
  release: applying package updates - web-components
  fix: update internal usage of useModalAttributes to use legacyTrapFocus by default (microsoft#31801)
  chore: make utils a package export (microsoft#31865)
  fix: add live region around scroll index update (microsoft#31863)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@mainframev mainframev mainframev approved these changes

Assignees
No one assigned
Labels
Area: Build System CI
Projects
None yet
Milestone
July Project Cycle Q3 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@Hotell @fabricteam @mainframev