fix(web-components): fix for setTheme in Firefox #31911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jul 3, 2024
change/@fluentui-web-components-5704d052-a860-40bb-b956-9b445a49e171.json
Show resolved
Hide resolved
marchbox
reviewed
Jul 3, 2024
marchbox
approved these changes
Jul 3, 2024
chrisdholt
approved these changes
Jul 3, 2024
eljefe223
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The default theme was not being set in Firefox. Firefox currently
SUPPORTS_ADOPTED_STYLESHEETSbut does notSUPPORTS_REGISTER_PROPERTY. The CSSStylesheet being adopted on the first pass was an empty stylesheet. And because there were no tokens registered, styles weren't applied.New Behavior
This change will always update the stylesheet to the new theme and then adopt the stylesheet if it hasn't been adopted already.
Related Issue(s)