Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web-components): fix for setTheme in Firefox #31911

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix(web-components): fix for setTheme in Firefox #31911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f6bfc4
fix(web-components): fix for setTheme in firefox
davatron5000 Jul 3, 2024
fa89bc9
add changefile
davatron5000 Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-web-components-5704d052-a860-40bb-b956-9b445a49e171.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
davatron5000 marked this conversation as resolved.
Show resolved Hide resolved
"type": "prerelease",
"comment": "fix for setTheme in Firefox",
"packageName": "@fluentui/web-components",
"email": "rupertdavid@microsoft.com",
"dependentChangeType": "patch"
}
9 changes: 4 additions & 5 deletions packages/web-components/src/theme/set-theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,12 @@ export const setTheme = (theme: Theme) => {
themeStyleTextMap.set(theme, `html{${tokenDeclarations.join('')}}`);
}

// Update the CSSStyleSheet with the new theme
themeStyleSheet.replaceSync(themeStyleTextMap.get(theme)!);
marchbox marked this conversation as resolved.
Show resolved Hide resolved

// Adopt the updated CSSStyleSheet if it hasn't been adopted yet
if (!document.adoptedStyleSheets.includes(themeStyleSheet)) {
document.adoptedStyleSheets.push(themeStyleSheet);
} else {
// The very first call to `setTheme()` within a document doesn’t need to
// call `replaceSync()`, because `CSS.registerProperty()` above is
// sufficient to set the tokens.
themeStyleSheet.replaceSync(themeStyleTextMap.get(theme)!);
}
};

Expand Down
Loading