Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage class instantiation #1582

Merged
merged 7 commits into from
Jan 3, 2025

Conversation

jgbradley1
Copy link
Collaborator

@jgbradley1 jgbradley1 commented Jan 3, 2025

Description

This PR addresses bugs first reported in #1540 and #1539, due to some recent code refactoring.

Itegration tests have been added to catch and prevent future changes from breaking the expected behavior of the StorageFactory class.

Notes

Closes #1539
Closes #1540

Checklist

  • I have tested these changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation (if necessary).
  • I have added appropriate unit tests (if applicable).

Verified

This commit was signed with the committer’s verified signature. The key has expired.
sei-vsarvepalli Vijay Sarvepalli
@jgbradley1 jgbradley1 requested review from a team as code owners January 3, 2025 21:02

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jgbradley1 jgbradley1 merged commit cbb8f87 into main Jan 3, 2025
15 checks passed
@jgbradley1 jgbradley1 deleted the joshbradley/fix-storage-instantiation branch January 3, 2025 22:39
natoverse pushed a commit that referenced this pull request Jan 6, 2025
natoverse added a commit that referenced this pull request Jan 6, 2025
* Unify Workflow and Verb callbacks interfaces

* Semver

* Fix storage class instantiation (#1582)

---------

Co-authored-by: Josh Bradley <joshbradley@microsoft.com>
Aglaia11 pushed a commit to Aglaia11/graphrag that referenced this pull request Jan 14, 2025
* Unify Workflow and Verb callbacks interfaces

* Semver

* Fix storage class instantiation (microsoft#1582)

---------

Co-Authored-By: Josh Bradley <joshbradley@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants