Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up job object options for unit tests #1335

Merged
merged 1 commit into from
Mar 24, 2022

Commits on Mar 24, 2022

  1. Fix up job object options for unit tests

    Most of the `jobobject` package tests we have ask for options that aren't
    actually needed/used. This change makes it so that any test that doesn't need
    a named job object doesn't ask for one and any test that doesn't plan on
    using the iocp messages doesn't flip the notifications field either. This
    wasn't causing any issues, but it's probably best to filter down what's
    being tested to only what's needed.
    
    Additionally fixes TestExecsWithJob that used log.Fatal instead of t.Fatal
    in the test.
    
    Signed-off-by: Daniel Canter <dcanter@microsoft.com>
    dcantah committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    7fa0910 View commit details
    Browse the repository at this point in the history