Fix up job object options for unit tests #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helsaawy
approved these changes
Mar 23, 2022
dcantah
force-pushed
the
noname-jobobjtests
branch
from
4bc01ae to
0749a73
Compare
anmaxvl
approved these changes
Mar 23, 2022
Most of the `jobobject` package tests we have ask for options that aren't actually needed/used. This change makes it so that any test that doesn't need a named job object doesn't ask for one and any test that doesn't plan on using the iocp messages doesn't flip the notifications field either. This wasn't causing any issues, but it's probably best to filter down what's being tested to only what's needed. Additionally fixes TestExecsWithJob that used log.Fatal instead of t.Fatal in the test. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
force-pushed
the
noname-jobobjtests
branch
from
0749a73 to
7fa0910
Compare
|
Re-pushing as the CI was stuck on reporting status and re-running didn't seem to do anything.. |
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Most of the `jobobject` package tests we have ask for options that aren't actually needed/used. This change makes it so that any test that doesn't need a named job object doesn't ask for one and any test that doesn't plan on using the iocp messages doesn't flip the notifications field either. This wasn't causing any issues, but it's probably best to filter down what's being tested to only what's needed. Additionally fixes TestExecsWithJob that used log.Fatal instead of t.Fatal in the test. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the
jobobjectpackage tests we have ask for options that aren't actually needed/used. This change makes it so that any test that doesn't need a named job object doesn't ask for one and any test that doesn't plan on using the iocp messages doesn't flip the notifications field either. This wasn't causing any issues, but it's probably best to filter down what's being tested to only what's needed.