Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use T.TempDir to create temporary test directory #1308

Merged
merged 2 commits into from
Mar 1, 2022
Merged

test: use T.TempDir to create temporary test directory #1308

merged 2 commits into from
Mar 1, 2022

Conversation

Juneezee
Copy link
Contributor

A small testing enhancement.

We can use the T.TempDir function from the testing package to create temporary directory. The directory created by T.TempDir is automatically removed when the test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.TempDir

@Juneezee
test: use T.TempDir to create temporary test directory
a840dd8 
The directory created by `T.TempDir` is automatically removed when the
test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@Juneezee Juneezee requested a review from a team as a code owner February 26, 2022 09:20
@anmaxvl
Copy link
Contributor

anmaxvl commented Mar 1, 2022

Thanks for the PR!

dcantah
dcantah approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! One comment

@Juneezee
test: remove redundant Close()
335403f 
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@dcantah dcantah merged commit 643ef46 into microsoft:master Mar 1, 2022
anmaxvl pushed a commit that referenced this pull request Feb 7, 2023
@ambarve
Merged PR 5895108: update ADO to d36cc7c
6a5be6f 
Related work items: #1240, #1241, #1258, #1260, #1270, #1271, #1272, #1279, #1286, #1288, #1289, #1292, #1293, #1294, #1295, #1297, #1298, #1299, #1301, #1305, #1307, #1308, #1309, #1310, #1313, #1314, #1315, #1318, #1320, #1321, #1322, #1324, #1326, #1328, #1332, #1333, #1334, #1335, #1337
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
@Juneezee
test: use T.TempDir to create temporary test directory (microsoft#1308
35be7ce 
)

* test: use `T.TempDir` to create temporary test directory

The directory created by `T.TempDir` is automatically removed when the
test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcantah dcantah dcantah approved these changes

@anmaxvl anmaxvl anmaxvl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Juneezee @anmaxvl @dcantah