Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip test for updating VM cpugroup membership for now #1298

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Skip test for updating VM cpugroup membership for now #1298

merged 1 commit into from
Feb 18, 2022

Conversation

katiewasnothere
Copy link
Contributor

@katiewasnothere katiewasnothere commented Feb 15, 2022 •
edited
Loading

Skipping for now to prevent failures during package creation.

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

@katiewasnothere katiewasnothere requested a review from a team as a code owner February 15, 2022 19:47
@anmaxvl
Copy link
Contributor

anmaxvl commented Feb 15, 2022

Curious why skipping vs an azureHost feature flag?

@anmaxvl
Copy link
Contributor

anmaxvl commented Feb 15, 2022

I guess azure host isn't really a "feature"

@katiewasnothere
Copy link
Contributor Author

@anmaxvl that's a good idea. Moving forward though I imagine we'll need a more specific way of gating the tests by azurehost version, which we don't have today.

@anmaxvl
Copy link
Contributor

anmaxvl commented Feb 15, 2022

@anmaxvl that's a good idea. Moving forward though I imagine we'll need a more specific way of gating the tests by azurehost version, which we don't have today.

makes sense

@katiewasnothere
Skip test for updating VM cpugroup membership for now
53deaa7 
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
anmaxvl
anmaxvl approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@anmaxvl anmaxvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@katiewasnothere katiewasnothere merged commit c7fa7ed into microsoft:master Feb 18, 2022
@katiewasnothere katiewasnothere deleted the skip_cpu_group_tests branch February 18, 2022 18:20
anmaxvl pushed a commit that referenced this pull request Feb 7, 2023
@ambarve
Merged PR 5895108: update ADO to d36cc7c
6a5be6f 
Related work items: #1240, #1241, #1258, #1260, #1270, #1271, #1272, #1279, #1286, #1288, #1289, #1292, #1293, #1294, #1295, #1297, #1298, #1299, #1301, #1305, #1307, #1308, #1309, #1310, #1313, #1314, #1315, #1318, #1320, #1321, #1322, #1324, #1326, #1328, #1332, #1333, #1334, #1335, #1337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcantah dcantah dcantah approved these changes

@anmaxvl anmaxvl anmaxvl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katiewasnothere @anmaxvl @dcantah