Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test for updating VM cpugroup membership for now #1298

Merged

Conversation

katiewasnothere
Copy link
Contributor

@katiewasnothere katiewasnothere commented Feb 15, 2022

Skipping for now to prevent failures during package creation.

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

@katiewasnothere katiewasnothere requested a review from a team as a code owner February 15, 2022 19:47
@anmaxvl
Copy link
Contributor

anmaxvl commented Feb 15, 2022

Curious why skipping vs an azureHost feature flag?

@anmaxvl
Copy link
Contributor

anmaxvl commented Feb 15, 2022

I guess azure host isn't really a "feature"

@katiewasnothere
Copy link
Contributor Author

@anmaxvl that's a good idea. Moving forward though I imagine we'll need a more specific way of gating the tests by azurehost version, which we don't have today.

@anmaxvl
Copy link
Contributor

anmaxvl commented Feb 15, 2022

@anmaxvl that's a good idea. Moving forward though I imagine we'll need a more specific way of gating the tests by azurehost version, which we don't have today.

makes sense

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Copy link
Contributor

@anmaxvl anmaxvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@katiewasnothere katiewasnothere merged commit c7fa7ed into microsoft:master Feb 18, 2022
@katiewasnothere katiewasnothere deleted the skip_cpu_group_tests branch February 18, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants